alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
6,485 Commits 1 Branch 0 Tags 40 MiB
e193b7eab0
Commit Graph

183 Commits

Author SHA1 Message Date
Aaron J. Seigo
2b762d0581 fix the "figure out which layout to use" codepath 
svn path=/trunk/KDE/kdelibs/; revision=1034850
 2009-10-13 17:42:32 +00:00
Darío Andrés Rodríguez
59296fb520 - Fix several minor issues reported by Krazy2 
(http://reviewboard.kde.org/r/1837/)


svn path=/trunk/KDE/kdelibs/; revision=1034756
 2009-10-13 12:40:13 +00:00
Chani Armitage
cd65144478 rightclick on popupapplet's dialog behaves like 
rightclick on the applet itself

svn path=/trunk/KDE/kdelibs/; revision=1029866
 2009-09-30 23:07:42 +00:00
Marco Martin
9936c19eae when setting a new widget or graphicswidget, update the main layout or the 
dialog, depending the status of the applet was collapsed or not

svn path=/trunk/KDE/kdelibs/; revision=1027670
 2009-09-24 13:28:56 +00:00
Aaron J. Seigo
6297027cba harmonize this code a bit 
svn path=/trunk/KDE/kdelibs/; revision=1022541
 2009-09-12 00:18:57 +00:00
Aaron J. Seigo
1e6aaec27f extenders into a subdir 
svn path=/trunk/KDE/kdelibs/; revision=1019570
 2009-09-03 21:53:56 +00:00
Marco Martin
72df46a81d no view->no popup 
BUG:194570

svn path=/trunk/KDE/kdelibs/; revision=1019493
 2009-09-03 18:37:27 +00:00
Marco Martin
acfd2a83fa Add PopupConstraintEvent, tells popupapplets (and applets with popups) 
that the position has to be changed

svn path=/trunk/KDE/kdelibs/; revision=1019486
 2009-09-03 18:11:49 +00:00
Aaron J. Seigo
cbf532055d ensure popups are on all desktops 
svn path=/trunk/KDE/kdelibs/; revision=1016274
 2009-08-27 11:50:56 +00:00
Marco Martin
e2e97757ca check the parentlayoutitem too 
svn path=/trunk/KDE/kdelibs/; revision=1013416
 2009-08-19 20:06:47 +00:00
Marco Martin
32ac2f11fb when an applet is in another applet return a constrained formfactor if 
the parent applet is too little
popupapplet uses the parent size insted of the containment to decide the
switch between full and popup, in all normal cases parent is the
containment, except for the ugly applet in applet cases

svn path=/trunk/KDE/kdelibs/; revision=1008775
 2009-08-08 11:34:49 +00:00
Aaron J. Seigo
c7be859522 now that we actually have the effect, we don't need this useless bit of comment :) 
svn path=/trunk/KDE/kdelibs/; revision=1002811
 2009-07-27 02:40:38 +00:00
Richard Dale
695168a4bd Add getters and setters for PopupApplet::widget() and PopupApplet::graphicsWidget() 
for use in scripting languages. Add a initScriptingExtenderItem() signal for script
engines to connect to and call their versions of Applet::initExtenderItem()


svn path=/trunk/KDE/kdelibs/; revision=998323
 2009-07-17 12:31:08 +00:00
Marco Martin
a3c54b201c move the status stuff into Applet, constify and also put a bit of apidox 
(forgotten from the previous commit:))

svn path=/trunk/KDE/kdelibs/; revision=993912
 2009-07-09 17:19:00 +00:00
Marco Martin
1300eea396 api to show/hide plasmoids from the systray, like NotificationItems 
this REALLY needs api review
CCMAIL:plasma-devel@kde.org

svn path=/trunk/KDE/kdelibs/; revision=993364
 2009-07-08 14:55:59 +00:00
Marco Martin
ed562d82dd reposition the popup when the containment geometry changes 
partially addresses 197522 (still have to manage cases where the view
just moves or the screen resizes without resizing the containment)
CCBUG:197522

svn path=/trunk/KDE/kdelibs/; revision=987082
 2009-06-25 14:13:14 +00:00
Aaron J. Seigo
42de815ffb catch the case where the widget goes from a QWidget to a QGraphicsWidget 
svn path=/trunk/KDE/kdelibs/; revision=979515
 2009-06-10 02:05:31 +00:00
Aaron J. Seigo
921f3a436b don't reset the window flags right after setting them so carefull; don't activate the window if we're passive and bypassing window management 
svn path=/trunk/KDE/kdelibs/; revision=979098
 2009-06-08 22:15:48 +00:00
Aaron J. Seigo
fc3c550a85 SVN_SILENT: what is so difficult about following code style standards? gah. 
svn path=/trunk/KDE/kdelibs/; revision=979040
 2009-06-08 19:52:21 +00:00
Marco Martin
067892f5e9 emit sizehintchanged on popup constraint events 
svn path=/trunk/KDE/kdelibs/; revision=977617
 2009-06-04 20:17:24 +00:00
Björn Ruberg
784fb1229b This fix makes it possible to have a popup that does not steal window focus when opened or used. 
Therefor you need to set Qt::X11BypassWindowManagerHint on the widget shown in the popup. This does 
NOT affect widgets that do not set the Flag. This fix is needed vor the virtual keyboard plasmoid "plasmaboard",
which can only work if the focus is untouched when being opened


svn path=/trunk/KDE/kdelibs/; revision=976221
 2009-06-01 10:33:41 +00:00
Aaron J. Seigo
53476746bc activate the window; since we're half-managing it ourselves, we need to take this extra step otherwise it can end up minimized. not what we want. 
BUG:191691

svn path=/trunk/KDE/kdelibs/; revision=964490
 2009-05-06 18:40:44 +00:00
Aaron J. Seigo
43629ac0f6 remove some dead code 
svn path=/trunk/KDE/kdelibs/; revision=964488
 2009-05-06 18:38:50 +00:00
Aaron J. Seigo
91a65043c1 use isEmpty() to figure out if an extender is empty or not; prevents popping up empty dialogs just because there are groups in the extender even though they have no items 
svn path=/trunk/KDE/kdelibs/; revision=964315
 2009-05-06 14:22:15 +00:00
Aaron J. Seigo
7fc1a201ff i can't get work done with this noise 
svn path=/trunk/KDE/kdelibs/; revision=959950
 2009-04-27 16:04:28 +00:00
Aaron J. Seigo
2e1ca49249 * handle the activate()->setFocus() ourselves 
* if we have a popup that is the extender and the extender is empty, don't show anything
BUG:190834

svn path=/trunk/KDE/kdelibs/; revision=959935
 2009-04-27 15:25:02 +00:00
Gustavo P. Boiko
86c869be37 Make the QX11Info include conditional 
svn path=/trunk/KDE/kdelibs/; revision=955379
 2009-04-17 13:21:41 +00:00
Aurélien Gâteau
7ff77020cc Do not let plasma popup appear over screensaver. 
BUG: 179924

svn path=/trunk/KDE/kdelibs/; revision=955241
 2009-04-17 08:45:46 +00:00
Aaron J. Seigo
8cb32d8ff9 SVN_SILENT: a code sketch 
svn path=/trunk/KDE/kdelibs/; revision=954622
 2009-04-16 04:54:19 +00:00
Aaron J. Seigo
0523f17be2 SVN_SILENT: ocd strikes again 
svn path=/trunk/KDE/kdelibs/; revision=954621
 2009-04-16 04:47:48 +00:00
Aaron J. Seigo
81cc419de6 actually show when not animating; faster show when animating 
svn path=/trunk/KDE/kdelibs/; revision=954620
 2009-04-16 04:33:55 +00:00
Aaron J. Seigo
406a0fac5f animated shows as well 
svn path=/trunk/KDE/kdelibs/; revision=954617
 2009-04-16 04:19:03 +00:00
Aaron J. Seigo
2dab71aaa7 try using the animated hiding in edge docked cases.. let's see how this goes :) 
svn path=/trunk/KDE/kdelibs/; revision=954612
 2009-04-16 03:20:29 +00:00
Aaron J. Seigo
dd3aed2f3b revert commit#946749 as it causes way too many side effects including: widgets not getting focus (kickoff no longer puts focus on the line edit), popups not going away when clicking elsewhere ... 
will need another fix for BR#179924
CCMAIL:aurelien.gateau@canonical.com
CCBUG:179924

svn path=/trunk/KDE/kdelibs/; revision=951366
 2009-04-09 04:18:10 +00:00
Aurélien Gâteau
d10641c35d Use Qt::Tool window flags for popups to avoid having them shown over screensaver. 
BUG:179924

I do not have a working copy of kdelibs 4.2 at the moment. Can someone backport
the fix?

svn path=/trunk/KDE/kdelibs/; revision=946749
 2009-03-30 09:00:16 +00:00
Aaron J. Seigo
14869d0fb8 don't put the popup applet group in the widget's Configuration group; that's for the subclasses alone 
svn path=/trunk/KDE/kdelibs/; revision=937998
 2009-03-10 23:03:38 +00:00
Marco Martin
a409afab79 better syncing between dialog graphicswidget and the dialog 
(popups shows up at a sane size now)

svn path=/trunk/KDE/kdelibs/; revision=935167
 2009-03-04 15:47:59 +00:00
Rob Scheepmaker
5105554bc1 2nd fixed regression! You can now again drop into extenders when hovering over popupapplets. 
svn path=/trunk/KDE/kdelibs/; revision=924031
 2009-02-09 22:10:35 +00:00
Rob Scheepmaker
fe805eb338 Massive refactoring of extender drag&drop handling. This should avoid bugs with the old way of doing things (toplevel view on an offscreen widget can lose 
mouse events while dragging), and is generally shorter and cleaner. There are still some regressions I'll be working on fixing, but it basically works, avoids 
crashes and is even faster.


svn path=/trunk/KDE/kdelibs/; revision=923915
 2009-02-09 18:10:45 +00:00
Ambroz Bizjak
476fd1a6a3 Added signals appletTransformedByUsed and appletTransformedItself to 
Plasma::Applet. This makes it easier for layouts to know when applets 
are transformed (moved/resized/rotated), and know whether the change
was by the user or the applet itself.

svn path=/trunk/KDE/kdelibs/; revision=923848
 2009-02-09 15:09:28 +00:00
Ambroz Bizjak
5e46bcc2ef Don't wait for startup complete, it makes the applet obtain 
proper geometry too late, which causes the desktop applet positioning
algorithm to calculate a wrong initial position.
CCBUG: 181854


svn path=/trunk/KDE/kdelibs/; revision=916941
 2009-01-26 14:29:55 +00:00
Aaron J. Seigo
029154f2ff return whether the popup is shown as a popup, not whether the popup is at all visible at all 
svn path=/trunk/KDE/kdelibs/; revision=916812
 2009-01-26 03:15:50 +00:00
Aaron J. Seigo
14ac4a4271 a lot less popup flickering and repainting. if there are no sideeffects to this discovered, this needs to be backported to the 4.2 branch. 
CCMAIL:plasma-devel@kde.org

svn path=/trunk/KDE/kdelibs/; revision=915488
 2009-01-23 07:33:30 +00:00
Aaron J. Seigo
8620f483d8 always make a layout no matter what 
svn path=/trunk/KDE/kdelibs/; revision=906713
 2009-01-06 18:08:58 +00:00
Aaron J. Seigo
93a5168b01 allow popups to be shown in any form factor; it really only depends on whether or not there is a dialog 
svn path=/trunk/KDE/kdelibs/; revision=903182
 2008-12-30 05:35:18 +00:00
Aaron J. Seigo
f6ac5f6052 technically probably more accurate, since in the case of no dialog .... we are showing the popup! 
svn path=/trunk/KDE/kdelibs/; revision=903161
 2008-12-30 02:11:10 +00:00
Aaron J. Seigo
f58b012cee make it harder for popupapplets to get tooltips wrong by hiding it for them 
svn path=/trunk/KDE/kdelibs/; revision=903160
 2008-12-30 02:07:57 +00:00
Aaron J. Seigo
7c7218cf89 having two methods named the same thing was a bit insane.. WHICH togglePopup? =) 
svn path=/trunk/KDE/kdelibs/; revision=903159
 2008-12-30 02:06:06 +00:00
Aaron J. Seigo
52ad594971 allow checking if the applet has a popup showing associated with it. not BC, but we haven't released 4.2.0 yet and this is the least ucky way of doig it ;) 
svn path=/trunk/KDE/kdelibs/; revision=902770
 2008-12-29 06:03:43 +00:00
Marco Martin
996a1277bc better manage save and restore of popup size of popupapplets when the 
content is a qgraphicswidget (i.e it works now), also ensure the default
size when it first pops up is the gwidget's preferred size

svn path=/trunk/KDE/kdelibs/; revision=902439
 2008-12-28 12:54:48 +00:00
Marco Martin
548b02c948 adjust the dialog size right after showing, this makes the clock popup 
to actually show when the popup is in the panel

svn path=/trunk/KDE/kdelibs/; revision=902184
 2008-12-27 16:26:19 +00:00
Aaron J. Seigo
173a19d10d don't show the dialog until it's position is settled which fixes the "i'm seeing flashes of kickoff at the top of the screen when i first open it". this also happens to fix a bug where sometimes a popup would show in the taskbar 
BUG:177675

svn path=/trunk/KDE/kdelibs/; revision=901338
 2008-12-25 08:36:01 +00:00
Marco Martin
9598dc5982 remove the offscreenwidget before putting it on screen again. this fixes 
the popupapplet crash  the second time it's dragged from desktop to
panel

svn path=/trunk/KDE/kdelibs/; revision=901241
 2008-12-24 19:13:05 +00:00
Marco Martin
38ab27d842 applets without an icon can have their own aspect ratio (clocks :)) 
svn path=/trunk/KDE/kdelibs/; revision=900421
 2008-12-22 20:32:37 +00:00
Marco Martin
3027146fc9 another sad qgraphicslayout workaround 
CCBUG:178288

svn path=/trunk/KDE/kdelibs/; revision=899800
 2008-12-21 16:19:47 +00:00
Aaron J. Seigo
ffead9de07 SVN_SILENT document why this is, as it's not immediately obvious why that would be needed there, and obviously got missed previously 
svn path=/trunk/KDE/kdelibs/; revision=898229
 2008-12-17 19:56:25 +00:00
Marco Martin
1ff5d76fca move the popup before its fist show, even if the show isn't triggered by 
a click, this should fix the first random position in devicenotifier
popup

svn path=/trunk/KDE/kdelibs/; revision=898214
 2008-12-17 18:37:21 +00:00
Marco Martin
78d7967cea set the layout hint in the popup considering the relative position of the popup icon 
with the popup position, this makes for instance the favourites icon in
kickof to be always as near the mouse as possible

svn path=/trunk/KDE/kdelibs/; revision=897521
 2008-12-16 11:43:21 +00:00
Marco Martin
06e7a940b0 don't try to reimplement popupPosition() but base on that, otherwise its 
bugs would be just duplicated, like 
CCBUG:177621 and CCBUG:177580

svn path=/trunk/KDE/kdelibs/; revision=896192
 2008-12-12 20:07:51 +00:00
Marco Martin
4b75b49f06 switch between popup and full on a startup complete constraint 
svn path=/trunk/KDE/kdelibs/; revision=896126
 2008-12-12 15:15:40 +00:00
Rob Scheepmaker
1b3d372062 (re)Add some kDebug lines temporarily to help me debug a bug I can't reproduce myself. 
svn path=/trunk/KDE/kdelibs/; revision=896123
 2008-12-12 15:03:18 +00:00
Aaron J. Seigo
7ccd4fb64f SVN_SILENT: probably don't need that debug in there anymore ;) 
svn path=/trunk/KDE/kdelibs/; revision=895577
 2008-12-11 03:06:46 +00:00
Rob Scheepmaker
72eaf8c5f7 No longer use a QGraphicsGridLayout to manage offscreen widgets in corona. Instead position them manually and give each one a spot where they can grow up to QWIDGETSIZEMAX. This has the advantage of not requiring hacks to work around QGL problems, and it avoids having to move all views when one item resizes. It feels snappier and the code looks cleaner. 
svn path=/trunk/KDE/kdelibs/; revision=895118
 2008-12-10 00:57:42 +00:00
Marco Martin
d0e899603c not all popupapplets are based on extenders :) 
svn path=/trunk/KDE/kdelibs/; revision=894991
 2008-12-09 19:07:21 +00:00
Aaron J. Seigo
e42452e847 * update the direction on location changes 
* update the dialog, if it exists, when checking the border of the extender
BUG:177113

svn path=/trunk/KDE/kdelibs/; revision=894469
 2008-12-08 18:03:23 +00:00
Marco Martin
212a4238bd reposition the popup after saving, so won't jump always to the old size 
svn path=/trunk/KDE/kdelibs/; revision=894071
 2008-12-07 20:20:28 +00:00
Marco Martin
ac9356bd85 update the popup position right after creating the popup itself 
BUG:177035

svn path=/trunk/KDE/kdelibs/; revision=893271
 2008-12-06 12:15:49 +00:00
Rob Scheepmaker
5ba015fa56 Removed obsolete call to updateDialogPosition, and use this function in dialogSizeChanged() for consistent dialog position. This solves the problem of the dialog being moved twice when the size of the widget changes. 
svn path=/trunk/KDE/kdelibs/; revision=892689
 2008-12-04 23:57:47 +00:00
Rob Scheepmaker
103f1db668 First showing the dialog and then updating it's position solves the problem of the calendars not appearing anymore unless an inconvenient set of circumstances occur. 
svn path=/trunk/KDE/kdelibs/; revision=890887
 2008-11-30 15:56:06 +00:00
Aaron J. Seigo
e16ba8fed0 * make popupEvent protected, like other events 
* allow marking the popup dialog as passive

CCBUG:176114

svn path=/trunk/KDE/kdelibs/; revision=889543
 2008-11-27 06:09:00 +00:00
Aaron J. Seigo
4659724790 don't create an unused button 
svn path=/trunk/KDE/kdelibs/; revision=889542
 2008-11-27 06:03:53 +00:00
Rob Scheepmaker
926dae37a7 Also hide dialogs of applets on the desktop. 
Use topleft of extenderitem to check if we're over a containment, since that point is also used when instantiating an extenderapplet, and otherwise the dropzone could be at a different position then the actual applet being created.


svn path=/trunk/KDE/kdelibs/; revision=888951
 2008-11-25 15:26:13 +00:00
Marco Martin
6743e12499 never set big minimum sizes in panels 
and don't use scrollbars in the popup views

svn path=/trunk/KDE/kdelibs/; revision=888095
 2008-11-23 19:24:49 +00:00
Marco Martin
902fb25a82 SVN_SILENT: comments++ 
svn path=/trunk/KDE/kdelibs/; revision=888075
 2008-11-23 17:55:40 +00:00
Marco Martin
fd0e2e8fc2 unbreak size save/restore in popupapplets 
svn path=/trunk/KDE/kdelibs/; revision=887782
 2008-11-22 21:09:34 +00:00
Marco Martin
ff6030e4f4 sanitize sizing of widgets displayed in popupapplet 
svn path=/trunk/KDE/kdelibs/; revision=887767
 2008-11-22 20:22:22 +00:00
Marco Martin
a46f365dcd resize based on preferred size 
svn path=/trunk/KDE/kdelibs/; revision=887707
 2008-11-22 16:23:11 +00:00
Rob Scheepmaker
6ce288cc0e Make showPopup a slot to be consistent with hidePopup and add a togglepopup slot just for convenience. 
svn path=/trunk/KDE/kdelibs/; revision=885723
 2008-11-17 20:03:20 +00:00
Aaron J. Seigo
4b08c03726 change KDE includes to use the .h style now that we're in libs 
svn path=/trunk/KDE/kdelibs/; revision=879795
 2008-11-04 02:04:34 +00:00
Aaron J. Seigo
1b523b9054 ok, this time JUST the plasma dir ;) 
svn path=/trunk/KDE/kdelibs/; revision=879759
 2008-11-03 23:08:39 +00:00
Aaron J. Seigo
fa5a2d87d9 bum-de-dum! plasma to kdelibs. 
svn path=/trunk/KDE/kdelibs/; revision=879757
 2008-11-03 23:03:26 +00:00
Rob Scheepmaker
babf165d5d A last couple of api changes before the move to kdelibs: 
* in class Extender rename setExtenderAppearance to setAppearance.
* in class ExtenderItem rename moveBackToSource to returnToSource.
* in class ExtenderItem addition of showCloseAction() and hideCloseAction().
... and some minor tweaks in the implementation.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=879670
 2008-11-03 19:49:14 +00:00
Kevin Ottens
f66b4d819b API changes as announced: 
* ConfigXml becomes ConfigLoader
  * Containment::(add|remove)ToolBoxTool(QAction *action) becomes
    Containment::(add|remove)ToolBoxAction(QAction *action)
  * Flash becomes FlashingLabel
  * Icon becomes IconWidget
  * PanelSvg becomes FrameSvg

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=877504
 2008-10-29 17:46:33 +00:00
Guillaume Pothier
bd7e7b10c9 Added screen management methods to Corona and removed usage of QDesktopWidget in plasmalibs. 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=877451
 2008-10-29 15:22:38 +00:00
Rob Scheepmaker
08b16a80dc Fixed extender appearence in dialogs of applets on the desktop. 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=875773
 2008-10-25 14:49:31 +00:00
Marco Martin
caef45dcf9 syncronize the minimum size with the one of graphicsWidget() or widget() 
upon containment change

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=875720
 2008-10-25 11:28:06 +00:00
Aaron J. Seigo
116a1d690c * always create a layout if possible 
* trying to set the minimum size here is not helpful; this should be handle by layouts

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=874992
 2008-10-23 00:16:07 +00:00
Marco Martin
1facd63fcc reparent before deleting the dialog, or the widget gets deleted 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=874911
 2008-10-22 18:51:59 +00:00
Aaron J. Seigo
1dc982c466 be safe (view can be null!) and don't call view() repeatedly as it requires tromping through all the views. not a killer in most situations, but nice to avoide unecessary work 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=874045
 2008-10-20 16:42:37 +00:00
Rob Scheepmaker
a26b73b6bb Give extenders the 'stacked' look from Pinheiro's mockup. It still needs some minor tweaks, but it allready looks quite sexy. 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=873867
 2008-10-20 10:58:37 +00:00
Alessandro Diaferia
7f51dcbf62 * better behavior with aspectRatioMode. 
* one important line more than the diff in reviewboard
  needed to correctly restore the aspectratio.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=872574
 2008-10-17 13:49:11 +00:00
Aaron J. Seigo
025d33adab minimum size fixes 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=871187
 2008-10-14 05:20:20 +00:00
Aaron J. Seigo
020c81e647 don't get caught with our layout pants down: re-check the layout after calling graphicsWidget() 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=871184
 2008-10-14 05:02:29 +00:00
Allen Winter
81d09742bb fix spelling 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870322
 2008-10-12 11:12:24 +00:00
Allen Winter
a7aebfa60a a bunch more coding style fixes. still some lines longer than 100 chars. 
this is definitely helping me find false positives in the Krazy style checker.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870161
 2008-10-11 22:48:38 +00:00
Chani Armitage
0d99586a04 removed a function that shouldn't be there. we must *never* call setParent on that dialog. 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870095
 2008-10-11 18:14:45 +00:00
Rob Scheepmaker
3824adb381 Allow theming the background of ExtenderItems, and react to theme changes. Capabilities still 
have to be improved to make it look like the lovely pinheiro mockup.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=868933
 2008-10-07 16:15:33 +00:00
Marco Martin
b765b0c711 always be a popup when the icon is null 
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=867521
 2008-10-03 18:01:55 +00:00
Aaron J. Seigo
22919a4b27 * remove an unused member (d->layout) 
* try harder to create a layout when we might need one
* remove the "setting a default icon" stuff in the ctor; it was misguided and really just covering up for a bug in popupConstraintsEvent
* fix said bug in popupConstraintsEvent (don't check for icon before laying things out in non-vert/horiz formfactors)
* don't put an event filter on the graphics item. i have no idea what the idea behind that was (hooray for no comments! =), perhaps Richard S. can enlighten us as it was one of his commits ..

CCMAIL:r.scheepmaker@student.utwente.nl

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=867506
 2008-10-03 17:20:01 +00:00
Jason Stubbs
3ecd0da73e Any PopupApplet that manages its appearance was failing if it happened to 
use a layout. I guess my applet is the only one attempting to do so. ;)

This code should perhaps be moved elsewhere? I can't tell what its purpose
is from looking at the surrounding code - I just know that it shouldn't be
removing items from my layout.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863216
 2008-09-21 13:13:20 +00:00