Commit Graph

7306 Commits

Author SHA1 Message Date
Aaron Seigo
3948cfb8cf use d->setWidget which notes that it's not a palette customization 2011-12-04 14:00:32 +01:00
Aaron Seigo
e34c70415e git rid of the native member, it's redundant; use d->setWidget which notes that it's not a palette customization 2011-12-04 14:00:32 +01:00
Aaron Seigo
27531a3173 the palette gets updated by all sorts of events on the scene now (incl. reparenting!), so make sure the palette is _really_ changing before marking it as custom
this fixes widget colours not updating with theme changes -> if, for instance, an offscreen widget is created, this results in a reparenting (to null)
and that in turn creates a palette changed event ... which was being intepretted as a custom palette being set and that would disable future updates
due to theme changes.

this also introduces a small helper which computes the palettes once for use by all widgets as a small performance improvement.

BUG:261967
2011-12-04 14:00:32 +01:00
Jaime Torres
4aa690ccc8 return a double usind qMin
qMin is a template, use the right datatype for it.
part of review 103323
2011-12-04 12:28:04 +01:00
Jaime Torres
2c5ec1a56a change return by break and then add a common return
removing dead code (part of review 103323)
2011-12-04 12:27:01 +01:00
Jaime Torres
be08974bfe remove dead code
remove dead code (see review 103323)
2011-12-04 12:25:46 +01:00
Jaime Torres
ab8e956d57 remove a break; after a return
there is no need for a break; after a return (dead code)

REVIEW: 103323
2011-12-04 12:24:35 +01:00
Aaron Seigo
97e4bd53d3 don't delete the kns3 dialog on application shutdown
BUG:288153
2011-12-03 21:22:45 +01:00
Aaron Seigo
086c669d47 m_corona does not exist in the libplasma2 version of tooltipmanager 2011-12-03 18:09:13 +01:00
Aaron Seigo
b7e335265f catch another possible mimetype identification
BUG:252612
2011-12-03 17:46:20 +01:00
Script Kiddy
66f3acefb9 SVN_SILENT made messages (.desktop file) 2011-12-03 14:30:23 +01:00
Aaron Seigo
96cdb27080 use the default corona in case the widget doesn't provide one
we need a different solution for libplasma2, however.

BUG:281759
2011-12-02 21:53:08 +01:00
Aaron Seigo
b556753ecd constrained square makes sense for vertical but not horizontal panels
BUG:282706
2011-12-02 21:53:07 +01:00
Aaron Seigo
feb6a53659 containmentType() .. NOT type()!
and now we know the source of the "panel covers the entire screen" bug

BUG:259704
2011-12-02 21:53:07 +01:00
Aaron Seigo
1b9bf08082 fix spinboxes
BUG:285224
2011-12-02 21:53:07 +01:00
Aaron Seigo
109453976a while properties are cool and all, let's not take the slow path just because we can. 2011-12-02 21:53:07 +01:00
Aaron Seigo
34376c31b1 animate transitions when an svg is used as well. 2011-12-02 21:53:07 +01:00
Aaron Seigo
c546b3d47d set the parent of the config skeleton object to be the dialog
BUG:287324
2011-12-02 21:49:24 +01:00
Aaron Seigo
ea8d0dcce2 get rid of the text halos
they are (relatively) expensive and should be unnecessary now:
we have blur, it works well, and when we don't blur we use different backgrounds.

one more "take one thing off" while i'm futzing around in tooltips
2011-12-02 21:48:34 +01:00
Aaron Seigo
464bab7a68 handle titles a little nicer: centered, no wrap for short titles 2011-12-02 21:48:34 +01:00
Aaron Seigo
61cdb24cdb force of habit :) 2011-12-02 21:48:34 +01:00
Aaron Seigo
d1cdb6c7d2 hide the label completely when no image is set. makes sure there isn't layout().spacing() extra padding 2011-12-02 21:48:34 +01:00
Aaron Seigo
3956daeb58 don't allocate 1k chunks of memory for a few longs here and there 2011-12-02 21:48:34 +01:00
Aaron Seigo
7074f1b74f grab the source name before removing the iterator
the previous fix, which i accidentally reverted while cleaning up this code,
was actually wrong (so in a way i'm glad i caught it): the signal MUST be emitted
AFTER the item is removed from the collection otherwise any code that checks to
see if that source exists will see that it does still exist even though it was
just signaled as being removed. order sometimes really matters :)

CCMAIL:kde@rusu.info
BUG:287795
2011-12-02 21:48:34 +01:00
Marco Martin
523ef55a7b remove the iterator after accessing it 2011-12-02 21:48:32 +01:00
Jeremy Whiting
ea1f079c34 KTar already supports xz and lzma files, also support them in Plasma::Package.
BUG:287913
(cherry picked from commit 897b07485a8cd70f831b8f586dc84859016b2572)
2011-12-02 12:03:42 -07:00
Aaron Seigo
1ba3ec0d04 use the default corona in case the widget doesn't provide one
we need a different solution for libplasma2, however.

BUG:281759
2011-12-02 19:01:46 +01:00
Aaron Seigo
e0cd24f83a constrained square makes sense for vertical but not horizontal panels
BUG:282706
2011-12-02 17:30:59 +01:00
Aaron Seigo
c3cb35739c containmentType() .. NOT type()!
and now we know the source of the "panel covers the entire screen" bug

BUG:259704
2011-12-02 17:00:29 +01:00
Aaron Seigo
f0498a9973 fix spinboxes
BUG:285224
2011-12-02 10:45:47 +01:00
Aaron Seigo
dd15c33c2b while properties are cool and all, let's not take the slow path just because we can. 2011-12-02 10:45:47 +01:00
Aaron Seigo
a97d486876 animate transitions when an svg is used as well. 2011-12-02 10:45:47 +01:00
Jeremy Whiting
2313cc258b KTar already supports xz and lzma files, also support them in Plasma::Package.
BUG:287193
2011-12-01 15:52:44 -07:00
Aaron Seigo
ed31f2aaee set the parent of the config skeleton object to be the dialog
BUG:287324
2011-12-01 17:13:30 +01:00
Aaron Seigo
822243288d get rid of the text halos
they are (relatively) expensive and should be unnecessary now:
we have blur, it works well, and when we don't blur we use different backgrounds.

one more "take one thing off" while i'm futzing around in tooltips
2011-11-30 15:44:29 +01:00
Aaron Seigo
7e4883f3bb handle titles a little nicer: centered, no wrap for short titles 2011-11-30 15:39:29 +01:00
Aaron Seigo
3c401cd360 force of habit :) 2011-11-30 15:19:58 +01:00
Aaron Seigo
3bf1d0d63d hide the label completely when no image is set. makes sure there isn't layout().spacing() extra padding 2011-11-30 15:19:29 +01:00
Aaron Seigo
7498fe207a don't allocate 1k chunks of memory for a few longs here and there 2011-11-30 13:43:52 +01:00
Aaron Seigo
b31a05c41e get rid of the source limiting; wasn't used, only overhead 2011-11-30 12:58:20 +01:00
Aaron Seigo
fee7b32974 allow ui/main.qml to be the default for plasmoids, and code/main.js for plasmoids, dataengines, runners 2011-11-30 12:58:20 +01:00
Aaron Seigo
6cd33ae4a0 grab the source name before removing the iterator
the previous fix, which i accidentally reverted while cleaning up this code,
was actually wrong (so in a way i'm glad i caught it): the signal MUST be emitted
AFTER the item is removed from the collection otherwise any code that checks to
see if that source exists will see that it does still exist even though it was
just signaled as being removed. order sometimes really matters :)

CCMAIL:kde@rusu.info
BUG:287795
2011-11-30 09:23:03 +01:00
Marco Martin
58b6cc3e43 remove the iterator after accessing it 2011-11-29 15:53:17 +01:00
Aaron Seigo
5727ade508 Merge remote branch 'origin/KDE/4.7' into frameworks
Conflicts:
	kio/kfile/kfilemetadatareaderprocess.cpp
2011-11-28 11:00:27 +01:00
Aaron Seigo
e7ffcacf1f emit sourceRemoved when the container is deleted outside of removeSource 2011-11-28 10:42:40 +01:00
Aaron Seigo
e500cd4bd7 make removeAllSources match removeSource closer 2011-11-28 10:37:21 +01:00
Aaron Seigo
2f5d8e4e7f the graphics widget may not have been into a layout, or may be null
BUG:287548
2011-11-28 09:43:22 +01:00
Stephen Kelly
846426335f Move libkarchive to kdecore.
It still depends on kdecore, and too much stuff depends on it for
it to be commented out for now.
2011-11-23 11:32:18 +01:00
Stephen Kelly
6117d99a7b Make plasma build. 2011-11-22 22:56:29 +01:00
Script Kiddy
b71636fb5b SVN_SILENT made messages (.desktop file) 2011-11-22 21:19:16 +01:00