Commit Graph

2405 Commits

Author SHA1 Message Date
Marco Martin
f06d25a00c API reviews:
globalName(), instanceName()->pimpl

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802135
2008-04-28 16:22:01 +00:00
Marco Martin
9bee311b96 API reviews:
ThemeChanged()->Q_PRIVATE_SLOT

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802130
2008-04-28 15:55:13 +00:00
Marco Martin
48be92bdab API reviews:
checkImmutability()->Q_PRIVATE_SLOT
added a q-pointer into Applet needed for this and themeChanged the other
Q_PRIVATE_SLOT that will be added

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802124
2008-04-28 15:41:18 +00:00
Anne-Marie Mahfouf
e985e96129 API review: pathChanged() not needed
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802098
2008-04-28 14:41:59 +00:00
Marco Martin
dfa4623a68 don't try to set StandardBackground if FormFactor is Horizontal or
Vertical
this fixes the panel layout on the first load when there is no
plasma-appletsrc

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802089
2008-04-28 14:18:19 +00:00
Robert Knight
cdb840d200 Print warnings if trying to assign invalid sizes to a panel or trying to generate a panel background with an invalid size. Prevents attempts to paint on an invalid pixmap leading to XRender errors.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801852
2008-04-27 22:34:24 +00:00
Robert Knight
ebdd9d4f99 Fix uninitialized variable.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801838
2008-04-27 21:49:09 +00:00
Aaron J. Seigo
b00807cee8 * containments should never have the applet background by default
* always call updateConstraints, not constraintsEvent directly to avoid unecessary multiple calls

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801817
2008-04-27 20:35:23 +00:00
Aaron J. Seigo
85f7ded2b4 SVN_SILENT: get rid of some dead code; with all the api changing happening, no point in keeping stuff around that isn't compiled
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801808
2008-04-27 20:09:20 +00:00
Anne-Marie Mahfouf
26a01ffb64 API review Plasma::Package::knownPackages() -> Plasma::Package::listInstalled()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801796
2008-04-27 19:22:29 +00:00
Aaron J. Seigo
df1ba079e8 go back is isContainment. ActAs is just ugly ugly. i don't think anyone really gets confused over isContainment (e.g. confusing it with IsA ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801792
2008-04-27 19:05:06 +00:00
Marco Martin
7b8860b462 API reviews:
static constants now in pimpl
also, don't make assumptions on icon size

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801766
2008-04-27 17:09:48 +00:00
Davide Bettio
4845197db5 API REVIEW: protected slots -> not slots
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801707
2008-04-27 13:52:59 +00:00
Davide Bettio
3210ad5beb API REVIEW: contructor -> protected
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801701
2008-04-27 13:50:49 +00:00
Davide Bettio
370d6b0b7e protected slots -> not slots
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801699
2008-04-27 13:47:59 +00:00
Davide Bettio
1474ed7cbc API REVIEW: color() --> die
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801697
2008-04-27 13:37:53 +00:00
Davide Bettio
7672b1620c constraintsUpdated() -> constraintsEvent()
Probably it should be protected and we need also updateConstraints() like in applet.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801661
2008-04-27 11:23:09 +00:00
Davide Bettio
8cd95e4ae7 API REVIEW: updated containment to the new API (constraintsUpdated() -> constraintsEvent() + protected)
CCMAIL: aseigo@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801659
2008-04-27 11:13:43 +00:00
Davide Bettio
ff16201431 API REVIEW: constraintsUpdated() -> constraintsEvent()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801656
2008-04-27 11:04:43 +00:00
Davide Bettio
5bc429daa9 API REVIEW: topLeft() -> dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801647
2008-04-27 10:26:42 +00:00
Davide Bettio
41d2aa43e4 watchForFocus() dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801641
2008-04-27 09:53:49 +00:00
Davide Bettio
624f8d0fb3 API REVIEW: needsFocus()->dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801640
2008-04-27 09:29:25 +00:00
Davide Bettio
55881aa054 API REVIEW: requestFocus() dies
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801637
2008-04-27 09:18:44 +00:00
Davide Bettio
7e5915f398 API REVIEW: FPS -> Fps
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801635
2008-04-27 09:02:18 +00:00
Script Kiddy
b4e4ff7ecb SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801563
2008-04-26 20:50:45 +00:00
Marco Martin
6989fb4388 adapt to api changes:
Animator::movementComplete() -> Animator movementFinished()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801556
2008-04-26 20:24:02 +00:00
Marco Martin
311d2bafd2 added toggled() signal in the toolbox emitted upon mouse click.
will be needed for the panel toolbox.
and removing two pure virtual methods already declared in QGraphicsItem

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801445
2008-04-26 17:31:49 +00:00
Marco Martin
694c822bb0 API reviews:
flushUpdatedConstraints()->flushPendingCostraintEvents()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801443
2008-04-26 17:13:59 +00:00
Albert Astals Cid
4068f45cf9 const & in foreach
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801430
2008-04-26 16:19:00 +00:00
Marco Martin
6d8a1752a7 API review:
isContainment(), setIsContainment() -> actAsContainment(),
setActAsContainment()
 set is protected

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801425
2008-04-26 15:52:48 +00:00
Anne-Marie Mahfouf
b21b9380de API review: remove icon as parameter in write()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801424
2008-04-26 15:48:47 +00:00
Anne-Marie Mahfouf
dc044b79c2 API review: isComplete() -> isValid()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801421
2008-04-26 15:37:42 +00:00
Marco Martin
62aa54b4e7 oops reverting an incomplete api change for now :(
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801420
2008-04-26 15:33:10 +00:00
Marco Martin
26732125cc removed unused Private::applyBackgroundHints
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801416
2008-04-26 15:27:17 +00:00
Anne-Marie Mahfouf
eff92e33d7 API review: required() -> isRequired()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801415
2008-04-26 15:26:40 +00:00
Davide Bettio
5ad0e12cdd API REVIEW: load() -> loadAll()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801377
2008-04-26 13:10:37 +00:00
Anne-Marie Mahfouf
0b12fc3a5e API review: sourceRequested() -> sourceRequestEvent()
updateSource() -> updateSourceEvent()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801373
2008-04-26 12:59:44 +00:00
Davide Bettio
444c2f6b49 API REVIEW: createMatchOptions() -> createRunOptions()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801372
2008-04-26 12:54:25 +00:00
Davide Bettio
e576ed397b API REVIEW: (set)hasMatchOptions -> (set)hasRunOptions()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801367
2008-04-26 12:41:16 +00:00
Anne-Marie Mahfouf
a522992e06 API review: clearSources()-> removeAllSources()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801363
2008-04-26 12:30:42 +00:00
Davide Bettio
451dc3b8cd API REVIEW: runnerName() -> name()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801360
2008-04-26 12:20:29 +00:00
Anne-Marie Mahfouf
254077afa4 API review clearData() -> removeAllData()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801353
2008-04-26 12:12:37 +00:00
Marco Martin
cda992682a API reviews:
constructors protected

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801349
2008-04-26 12:06:18 +00:00
Davide Bettio
a36939ee2c API REVIEW: config() -> protected
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801342
2008-04-26 11:59:23 +00:00
Davide Bettio
6b0b1e0dc4 API REVIEW: ctors -> protected
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801340
2008-04-26 11:55:02 +00:00
Davide Bettio
b976255bf3 API REVIEW: http://techbase.kde.org/index.php?title=Projects/Plasma/Tokamak1
SlowSpeed before NormalSpeed

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801339
2008-04-26 11:49:59 +00:00
Marco Martin
0c283924be API reviews:
killed drawStandardBackground() and shadowShown()
now the two properties are merged in backgroundHints() and
setBackgroundHints() using the combination of BackgroundHints flags

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801282
2008-04-26 09:13:57 +00:00
Aaron J. Seigo
8cdde181c5 signal typos
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801237
2008-04-26 03:33:41 +00:00
Pino Toscano
77b9bc893c extra ';'
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801227
2008-04-26 00:12:31 +00:00
Alexis Ménard
2b235d2906 +hasUpdates()->pimpl ok
+setNeedsUpdate()->protected used in dataengine line 306
+checkUsage()->protected used in dataengine line 293

protected or pimpl/modification in dataengine too?

CCMAIL : ervin@kde.org
 

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801168
2008-04-25 20:33:46 +00:00