Commit Graph

15464 Commits

Author SHA1 Message Date
Aleix Pol
c33fcaa8d7 Consistently define the tooltip delay
Summary: Set the right value on the Kirigami.Units and use it from tooltip.

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25918
2019-12-13 15:03:24 +01:00
David Edmundson
c5a3d7cd54 [PC3] Complete plasma progress bar animation
Summary:
Otherwside if we toggle indeterminate the bar resizes to 50% of the view
and X stops on the current value of the animation. Resulting in
something that looks super odd.

Test Plan: Plasma Components manual uit test looks sane

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25927
2019-12-12 22:18:12 +01:00
David Edmundson
e91ba953ea [PC3] Only show progress bar indicator when the ends won't overlap
Summary:
If the width is smaller than LeftMargin + Right Margin the two ends
overlap and it looks super weird

Test Plan: Progressbar manual unit test looks sane

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25926
2019-12-12 22:18:12 +01:00
Nate Graham
5172b920f9 [RFC] Fix Display Configuration icon margins
Summary:
The icon's old margins were too large, causing it to stick out.

BUG: 400087
FIXED-IN: 5.66

Test Plan:
{F7813886, size=full}

{F7813885, size=full}

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: trickyricky26, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25296
2019-12-12 18:16:21 +01:00
David Edmundson
fecb716b87 Add test for combobox from QQC2 2019-12-12 15:29:42 +00:00
Aleix Pol
a1880d1e56 Fix warning 2019-12-12 13:04:17 +01:00
Aleix Pol
e32d28e548 fix warnings, remove unused captured variables 2019-12-12 11:33:48 +01:00
Kai Uwe Broulik
8f7b2c9ae0 [ColorScope] Work with plain QObjects again
Otherwise colorScope doesn't attach to things like Plasma.Svg.
Also remove superfluous cast as parentItem() returns a QQuickItem *.

Differential Revision: https://phabricator.kde.org/D25887
2019-12-11 16:02:11 +01:00
Kai Uwe Broulik
e44cab6ab5 [Breeze Desktop Theme] Add monochrome user-desktop icon
This ensures the "show desktop" plasmoid remains monochrome in the panel at any size.

Differential Revision: https://phabricator.kde.org/D25885
2019-12-11 15:56:30 +01:00
Aleix Pol
7a9b50c8dc Remove default width from PlasmaComponents3.Button
Reviewed by Marco Martin
2019-12-11 15:36:44 +01:00
Aleix Pol
2649878108 Fix some bits in the Plasma style
Use properties that exist
Remove unused warningy code
Make sure we don't call null objects

Reviewed by Marco
2019-12-11 14:43:37 +01:00
Filip Fila
e4e1613b0f [PC3 ToolButton] Have the label take into account complementary color schemes
Summary:
We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button).

The SDDM theme uses a complementary color scheme, which is something the PC2 ToolButton respects and turns the labels white.

Therefore I just copy pasted PC2's label color code to its PC3 counterpart.

BUG: 414929
FIXED-IN: 5.66

Test Plan:
```
import QtQuick 2.13
import org.kde.plasma.components 3.0 as PlasmaComponents
import org.kde.plasma.core 2.0 as PlasmaCore

PlasmaCore.ColorScope {
    colorGroup: PlasmaCore.Theme.ComplementaryColorGroup

    Rectangle {
        height: 80
        width: 100
        color: "red"

        PlasmaComponents.ToolButton{
            anchors.fill: parent
            text: "sup"
        }
    }
}
```

The label was white instead of black.

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: mart, davidedmundson, fvogt, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25699
2019-12-11 13:50:11 +01:00
David Edmundson
a3acfbfce6 Add manual test for changing colorscope in components
Summary: For quickly other bugs in PC3

Test Plan:
Opened qmlscene on some files
It's only for unit tests anyway

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25822
2019-12-09 20:59:57 +00:00
Noah Davis
7e52c869de Added background colors to active and inactive icon view
Summary:
Added:
- Semi-transparent blue background color for active window
- Semi-transparent gray background color for inactive but not minimized window

Changed:
- Reduced opacity for minimized background

BUG: 370465
FIXED-IN: 5.66

Test Plan:
Before:
{F7804957}
After:
{F7805236}

Reviewers: #vdg, ngraham, niccolove

Reviewed By: #vdg, ngraham

Subscribers: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25340
2019-12-09 13:00:43 -05:00
l10n daemon script
d2fba8a760 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-12-09 05:18:11 +01:00
l10n daemon script
e19cb44cd4 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.65.0 release. 2019-12-07 19:46:32 +00:00
Marco Martin
af861eb2a4 move backgroundhints managment in Applet
Summary:
Applet is the more proper way to do it (and will make easier porting
to KF6) this also make it possible for the scripting interface to
access userBackgroundHints

Test Plan: everything behaves the same in plasmashell, the background button in the handle works

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25742
2019-12-05 10:41:57 +01:00
Marco Martin
1da69dd751 use the file selector in the interceptor
we still need at least for kf5 lifetime to use PackageUrlInterceptor
so use the selector there
this fixes a regression where old plasmoids with javascript in /code/
did break
2019-12-03 11:05:47 +01:00
Marco Martin
7a301be293 more use of ColorScope 2019-11-29 14:57:21 +01:00
Marco Martin
09e7a5a6bb also monitor window changes
fixes some scopes not finding their parent and
never getting notified when it changes
2019-11-29 13:44:58 +01:00
Marco Martin
57fdb56790 support for user removing background and automatic shadow
Summary:
add the ability for the user to override the background hints anddecide
about applets having background or a shadow
A new handle button will be added to manually enable/disable background for
plasmoids that support it
if they don't, the ImmutableBackground flag is set in the hints.

PlasmaCore.ColorScope has been expanded to work more like Kirigami.Theme (which will be replaced by) even if it's oòld behavior still works. This makes the complementary colorscope in applets with shadow actually work (and at the same time gives a clearer porting path for kf6)

Test Plan: Tested the functionality and correct save/restore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25590
2019-11-29 10:45:08 +01:00
Marco Martin
15e3d10ef8 support file selectors 2019-11-26 10:25:32 +01:00
Marco Martin
c79118e907 support qml file selectors 2019-11-25 18:21:26 +01:00
Marco Martin
24702a5353 remove stray qgraphicsview stuff 2019-11-22 16:18:54 +01:00
Marco Martin
4089bba04a remove dead files
fullscreensheet and fullscreenwindow were leftovers from porting to kf5
and have not been built since years, remove them
2019-11-22 16:14:50 +01:00
David Faure
6de88ef932 Port away from deprecated method authorizeKAction, renamed to authorizeAction 2019-11-20 23:51:59 +01:00
l10n daemon script
e0b70205f7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-13 05:39:52 +01:00
Yuri Chornoivan
052a81f755 Fix minor issues found by EBN and typos 2019-11-10 12:06:10 +02:00
l10n daemon script
14f0508478 GIT_SILENT Upgrade KF5 version to 5.65.0. 2019-11-10 02:18:09 +00:00
Marco Martin
b58d7c7752 don't delete and recreate wallpaperinterface if not needed
Summary:
the wallpaperinterface instance already reacts to wallpaper package
change and loads the current one.
containemtninterface deleted it every time the wallpaper changed
and recreated, effectively loading the wallpaper two times every time
the plugin was changed

Test Plan: switching plugins still works, but it's actually visible faster on slow hardware

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25217
2019-11-08 16:28:36 +01:00
Méven Car
000022b668 MobileTextActionsToolBar check if controlRoot is undefined before using it
Summary:
Prevents warning such as

qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
qml/org/kde/plasma/components.3/mobiletextselection/MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25164
2019-11-06 15:20:31 +01:00
l10n daemon script
876dafaedb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-06 05:33:56 +01:00
Konrad Materka
96b7fc21f5 Add hideOnWindowDeactivate to PlasmaComponents.Dialog
Summary: When using Dialog or QueryDialog it should be possible to set hideOnWindowDeactivate flag.

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24825
2019-11-04 10:09:16 +01:00
David Faure
e3abfcfc16 GIT_SILENT QT_DEPRECATED_WARNINGS_SINCE will be done by ECM 2019-11-03 21:15:03 +01:00
l10n daemon script
7c1d16ac85 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.64.0 release. 2019-11-02 11:47:13 +00:00
l10n daemon script
29104614ef SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-11-01 05:25:32 +01:00
l10n daemon script
1928390d1f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-10-30 05:30:22 +01:00
Marco Martin
1f6d7591e9 map disabledTextColor to ColorScope 2019-10-29 12:30:15 +01:00
Marco Martin
5f46dd6bd5 add DisabledTextColor to Theme 2019-10-29 11:29:12 +01:00
David Edmundson
12edce87bb [PC3/button] Elide text always
Summary:
We always want the label to have the width managed by the layout to fill
all available space.

Test Plan:
In tests/components/button3.qml the test

"long text but constrained, should be 150px and elided" now is correctly
elided rather than the text spewing past the end of the button. The text
does not overlap the icon.

Reviewers: #plasma, apol, ngraham

Reviewed By: apol, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24909
2019-10-25 15:44:46 +01:00
David Faure
1076864048 GIT_SILENT enable Qt deprecation warnings 2019-10-25 00:31:17 +02:00
Friedrich W. H. Kossebau
d70eadb977 API dox: adapt kapidox & ecm_add_qch settings to new deprecation macros
GIT_SILENT
2019-10-22 19:41:15 +02:00
Björn Feber
bbe0148db5 Improve panel options menu entries
Summary:
- Move "Panel Options" context menu items out of submenu
- Rename "Configure Panel..." option

See M144, T10047, T10190. This makes the panel customization options much more discoverable.

Test Plan: Open the panel context menu.

Reviewers: #plasma, #vdg, mart

Reviewed By: #plasma, #vdg, mart

Subscribers: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D23951
2019-10-21 19:53:46 +02:00
Marco Martin
acbb200ac2 edit mode action
Summary: needed for the context menu entry

Test Plan: with the p-w- portion the action shows in the context menu

Reviewers: #plasma, #vdg, GB_2, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10190, T11094, T10402

Differential Revision: https://phabricator.kde.org/D24263
2019-10-21 13:06:01 +02:00
Friedrich W. H. Kossebau
573b9a439f Enable KF_* group deprecation macros
GIT_SILENT
2019-10-20 03:46:32 +02:00
Friedrich W. H. Kossebau
df7f981890 Use ECMGenerateExportHeader to manage deprecated API better
Summary:
Allows
* projects linking to Plasma to hide deprecated API up to a
  given version or silence deprecation warnings after a given version,
  using
  * -DPLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMA_NO_DEPRECATED
  * -DPLASMA_DEPRECATED_WARNINGS_SINCE
  * -DPLASMA_NO_DEPRECATED_WARNINGS
  * -DPLASMAQUICK_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DPLASMAQUICK_NO_DEPRECATED
  * -DPLASMAQUICK_DEPRECATED_WARNINGS_SINCE
  * -DPLASMAQUICK_NO_DEPRECATED_WARNINGS

  or
  * -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
  * -DKF_NO_DEPRECATED
  * -DKF_DEPRECATED_WARNINGS_SINCE
  * -DKF_NO_DEPRECATED_WARNINGS

Reviewers: #plasma, mart, davidedmundson, apol, mlaurent

Reviewed By: #plasma, mart, mlaurent

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24678
2019-10-19 00:42:13 +02:00
Friedrich W. H. Kossebau
ab8e63a5a5 Use new INCLUDE_DIRS with ecm_add_qch, to have doxygen see more includes
GIT_SILENT
2019-10-19 00:39:53 +02:00
Friedrich W. H. Kossebau
7f52e22deb Include KDE CMake settings macros as first
GIT_SILENT
2019-10-15 17:58:10 +02:00
Noah Davis
15ed55b4cb [icons/media.svg] Add 16 & 32px icons, update style
Summary: Fixes blurry icons in the desktop shell

Test Plan:
{F7593397, size=full}

Examples of fuzzy icons:

task manager {F7593494, size=full}
media player widget {F7593497, size=full}

Fixed:

{F7593493, size=full}
{F7593509, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24627
2019-10-14 22:28:49 -04:00
l10n daemon script
e5b81587a5 GIT_SILENT Upgrade KF5 version to 5.64.0. 2019-10-12 21:26:10 +00:00