alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1,843 Commits 1 Branch 0 Tags 40 MiB
f4c0653174
Commit Graph

48 Commits

Author SHA1 Message Date
Sebastian Gottfried
db1d3d37e9 Plasma QML components: fix internal anchoring in Button and ToolButton 
There is a bug in the tool button and button components resulting in
layout breakage if one clears and sets the text property of the
component when not visible, see the attached screenshot.

I have tried to solve the issue without changing the existing
anchoring system, but without success. The only working solution
was to put the icon and the label item into Row item. That way I was
able to fix the bug and even get rid of the ugly explicit
non-declarative anchor assignments.

I have also removed the preferredWidth property of the label item,
that one always evaluated to paintedWidth, anyway.

REVIEW: 107813
 2012-12-19 16:07:50 +01:00
Marco Martin
ed4504f731 PlasmaCore.IconItem 
remove the old private IconLoader
this takes care of rendering at the proper size, using a Svg when needed and animation when
 2012-11-26 20:49:16 +01:00
Aaron Seigo
cdfd8688f4 styl ocd 2012-11-07 12:45:57 +01:00
Marco Martin
575b817c97 consider the case wen right or bottom margins are disabled 2012-11-06 13:52:36 +01:00
Aaron Seigo
3fb4a78ed5 replace tabs with space. 2012-10-25 13:14:53 +02:00
Marco Martin
6b32e0426c add missing property preferredWidth 2012-10-18 17:22:34 +02:00
Marco Martin
58d9657594 binding loop-- 2012-10-18 16:50:59 +02:00
Sebastian Kügler
d3f8c0683b Fix two typos introduced with 29a2ed 
It's delegate.margins of course.

Reviewed-By: Marco Martin
 2012-10-17 17:36:55 +02:00
Marco Martin
05936e77d8 kill the ToolButton duplication for touch 2012-10-14 20:05:40 +02:00
Marco Martin
b794f94286 draw attached ToolButtons in ButtonRow/Column 
but only if the theme composes over borders (needed to be pixel perfect)
if the toolbuttons are not flat and if the ButtonRow is large enough
 2012-10-14 20:05:40 +02:00
Marco Martin
6209ca2527 proper icon margins 2012-10-11 13:30:24 +02:00
Marco Martin
9f0d2338b1 never draw disabled flat buttons 2012-10-11 12:32:58 +02:00
Marco Martin
d8116afac3 round only when square 2012-10-10 18:47:56 +02:00
Marco Martin
78a87b1da3 always use round buttons on toolbuttons without text 2012-10-10 18:35:06 +02:00
Marco Martin
322bf6ab6c round toolbuttons when not flat and no text 2012-09-10 22:11:15 +02:00
David Edmundson
650258aa88 Fix spelling typo in comment 2012-08-14 18:05:57 +01:00
Johannes Tröscher
796211bbd5 Plasma qml-Components ToolButton: change text-color on hover more fluently 
REVIEW: 105375
REVIEWED-BY: troscher aseigo
 2012-06-28 19:40:33 +02:00
David Edmundson
2030c05cf1 Remove text scaling on ToolButton 
BUG: 302077
Reviewed-by: Marco Martin
 2012-06-23 03:19:47 +01:00
Aurélien Gâteau
fc0f700c9d Fix text colors on TabButton and ToolButton 
When the widgets use the button background frame, use buttonTextColor.
When they do not use any background frame, use textColor.

Avoids unreadable text with Oxygen

REVIEW: 105163
 2012-06-09 10:12:05 +02:00
Sebastian Kügler
e27c827fba Mention enabled property in ToolButton's APIDOC 2012-06-08 12:49:36 +02:00
Sebastian Gottfried
5b567230e6 buttons: first focus, than emit clicked() signal 
Otherwise a client wanting to give another QML component the focus in
reaction to a clicked button has no chance doing so because the button
will steal the focus again right after the event handler has finished
executing.

REVIEW: 104893
 2012-05-10 00:48:53 +02:00
Aurélien Gâteau
2b8a7b32c5 Toolbutton: Fix layout issues 
- Improve spacing between icon and text
- Do not enforce a minimum width

Having a minimum width does not make much sense for a ToolButton:
1. It should aim at using the minimum amount of horizontal space when
   used in a ToolBar.
2. It looks unbalanced when used with an icon because the content is
   flushed to the left, leaving a large amount of white-space on the right.

REVIEW: 104735
 2012-04-26 15:12:03 +02:00
Aurélien Gâteau
90bddbf61e ToolButton: Improve keyboard navigation support 
Use the hover frame to indicate focus, do not give focus if keyboard
navigation is not defined.

REVIEW: 104727
 2012-04-26 09:21:02 +02:00
David Edmundson
cfc76b8144 Fix padding in toolbutton and tab buttons 
REVIEW: 104319
 2012-03-20 00:57:54 +00:00
Marco Martin
05571febc3 never use alias 2012-01-12 11:05:42 +01:00
Marco Martin
4bf3597b2d fix button icon sizing 2012-01-03 21:16:25 +01:00
Marco Martin
0a3b3d849c document iconSource a bit more 2011-12-28 18:02:44 +01:00
Giorgos Tsiapaliwkas
4c627ff830 Merge branch 'master' of git://anongit.kde.org/kde-runtime 
Conflicts:
	plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml
 2011-12-22 18:39:21 +02:00
Marco Martin
bcc26fb73b fix import names 2011-12-22 14:58:11 +01:00
Giorgos Tsiapaliwkas
9a1e332b9b move the private components into a private subdir 2011-12-22 15:16:01 +02:00
Marco Martin
de666a6fd3 Documentanted -> Documented 2011-12-22 11:53:15 +01:00
Marco Martin
d72f2d7c3c Merge branch 'master' into plasma-components-doc 
Conflicts:
	plasma/declarativeimports/plasmacomponents/qml/Button.qml
 2011-12-16 18:53:25 +01:00
Marco Martin
13a3d33681 use onclicked 
it gets canceled when it should
 2011-11-28 21:42:27 +01:00
Marco Martin
d5167f2529 pressed effect for the label 2011-11-28 13:49:28 +01:00
Marco Martin
3734ab5658 less height 2011-11-17 20:14:47 +01:00
Marco Martin
a5b16a856c fix button width 2011-11-17 20:03:08 +01:00
Giorgos Tsiapaliwkas
72f52c5d29 Merge branch 'master' into plasma-components-doc 2011-11-16 18:06:25 +02:00
Marco Martin
63eb84ce80 left text alignment if icon 2011-11-10 14:27:35 +01:00
Marco Martin
96a7efd027 square toolbuttons if without text 2011-11-10 11:33:36 +01:00
Marco Martin
0c2995f8e8 give typical items the same (font based) height 
this way everything will look exactly vertically aligned
 2011-11-09 22:31:39 +01:00
Marco Martin
869afade06 different paint for flat toolbuttons in touchscreens 2011-11-08 20:48:33 +01:00
Marco Martin
82bbcc139a better logic for button pressed handling 2011-11-08 19:27:44 +01:00
Giorgos Tsiapaliwkas
29c50400fd Init docu for ToolButton.qml 2011-11-08 09:33:08 +02:00
Marco Martin
6eba438a89 PlasmaCore.Theme is registered by the inport 
no more need to declare it every time -> memory saving
 2011-10-30 17:53:20 +01:00
Marco Martin
f32fc24694 use IconLoader 2011-10-29 21:41:45 +02:00
Marco Martin
be1068709a an item to load icons 
still private, load icons either by absolute path, icon name, svg
 2011-10-29 21:19:51 +02:00
Marco Martin
486fbf6f82 use all font properties from Theme all around 2011-10-13 18:23:40 +02:00
Marco Martin
b44e60daa3 ToolButton 2011-10-13 12:18:14 +02:00