alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
13,054 Commits 1 Branch 0 Tags 40 MiB
f75eb2d984
Commit Graph

348 Commits

Author SHA1 Message Date
Aleix Pol
f75eb2d984 Don't connect to signals until the class has been initialized 
While profiling plasmashell memory usage with Vishesh we realized that most
of the usage came from loading the Background image repeatedly.

We traced it back to this change, where we were connecting to
wallpaperChanged before initializing it, so it would initialize it again,
loading the wallpaper twice. It's not that we were leaking the object,
AFAIK, but loading an image using QQuickImage already raises the memory
quite a bit.

This change alone reduces by 15% the memory usage of my plasmashell (with 2
screens, that makes it a bit worse, because there's 2 DesktopViews then).

REVIEW: 119216
 2014-07-10 19:53:03 +02:00
l10n daemon script
8afadc6410 SVN_SILENT made messages (.desktop file) 2014-07-10 04:23:58 +00:00
l10n daemon script
ee230c4d21 SVN_SILENT made messages (.desktop file) 2014-07-09 03:37:24 +00:00
Marco Martin
9218543b65 QCoreApplication::closingDown() becomes true too late 
restore the disconnect: sometimes appletRemovedForward gets executed after
aboutToQuit is emitted, but before closingDown returns true
this prevents configuration to be forgotten
 2014-07-08 12:49:04 +02:00
Marco Martin
a5ecb2e0ff fix a crash sometimes happening on close 
the problem is that sometimes when QCoreApplication::aboutToQuit the containment is already deleted (the order is not really deterministic), therefore appletScript::applet() will hit an assert.
using a qpointer should solve it, its data being already 0ed in the cases the containment is already deleted at :aboutToquit time.
 2014-07-08 11:04:05 +02:00
Marco Martin
0dba9044bf actions() returns the complete list 
the disabled/invisible actions already have it as properties.
this fixes the add widgets action sometimes not being available
in the toolbox
Reviewed by: Bhushan Shah <bhush94@gmail.com>
 2014-07-07 19:36:30 +02:00
l10n daemon script
29908f145a SVN_SILENT made messages (.desktop file) 2014-07-01 12:38:20 +00:00
l10n daemon script
b06bb52100 SVN_SILENT made messages (.desktop file) 2014-06-29 08:42:52 +00:00
Marco Martin
e09a2eb44a check pointer validity, crash-- 
even if that code path shouldn't be hit, always better avoiding a crash
(proper fix coming)
CCBUG:336491
 2014-06-23 14:50:06 +02:00
l10n daemon script
ac4f519188 SVN_SILENT made messages (.desktop file) 2014-06-23 08:35:39 +00:00
Marco Martin
55b5e815b5 ignore inactive containment in containmentAt 
Reviewed by: Bhushan Shah <bhush94@gmail.com>
BUG:336168
 2014-06-20 17:32:36 +02:00
Aleix Pol
97cf403288 Reduce Applet::containment calls 
It's not a cheap call, and there's no need to re-calculate it every time.
 2014-06-17 16:02:43 +02:00
Marco Martin
34226faec1 one occasion less to crash 
(on debug builds an assert is still possible)
 2014-06-17 11:49:23 +02:00
l10n daemon script
b092bbed31 SVN_SILENT made messages (.desktop file) 2014-06-12 08:31:04 +00:00
Aleix Pol
8ab91f219d Expose the screenGeometry on the applet interface 
It's useful to be able to figure out information about the current screen
without having to ask the corona.
 2014-06-05 15:24:26 +02:00
Marco Martin
9d1727a1a4 Plasma1 behavior: no remove action in panels 
the remove context menu for applets is only visible when the panel controller is open
less accidental removal
 2014-06-03 16:35:01 +02:00
Marco Martin
223fe9b431 stop forwarding appletRemoved on application close 
the containment must not save geometries without the applets that are being deleted

BUG:335742
 2014-06-03 11:59:57 +02:00
l10n daemon script
9e45440ae7 SVN_SILENT made messages (.desktop file) 2014-05-29 08:11:19 +00:00
l10n daemon script
fd1674450e SVN_SILENT made messages (.desktop file) 2014-05-25 08:47:48 +00:00
l10n daemon script
2ba1a0c90f SVN_SILENT made messages (.desktop file) 2014-05-23 08:16:11 +00:00
l10n daemon script
db8da9ff8d SVN_SILENT made messages (.desktop file) 2014-05-20 10:48:03 +00:00
Aleix Pol
35d1dd2d65 Don't try to delete null objects 
Fixes a warning in Qt and makes sense of what the code it's actually doing.
At least it was not crashing!
 2014-05-16 03:08:11 +02:00
l10n daemon script
1b3060649c SVN_SILENT made messages (.desktop file) 2014-05-14 08:29:33 +00:00
Aleix Pol
da190fa711 Reduce calls to ShellCorona::screenForContainment 
Just store some values instead of calling repeatedly without reason.
 2014-05-13 14:15:46 +02:00
Aleix Pol
cc661dfdd6 Save some calls to ShellCorona::screenGeometry 
It's not an especially cheap function and it didn't make sense doing
it twice
 2014-05-13 14:03:46 +02:00
Marco Martin
3f516ddda6 adapt api change 2014-05-13 13:45:32 +02:00
Marco Martin
34b86471d0 fix screen region mapping 
BUG:334670
 2014-05-13 13:42:44 +02:00
Marco Martin
55514d28c7 Merge branch 'mart/plasmoidMove' 2014-05-13 12:47:49 +02:00
Marco Martin
64cff59a31 api to add an existing applet and position mapping 2014-05-13 12:46:17 +02:00
Marco Martin
cdb9c8c1cc addApplet function 
offers a crude support to applet migration between containments
 2014-05-12 21:07:41 +02:00
Marco Martin
895c5b6b2b close the menu if it was already open 
sometimes on plasma start, other context events may be triggered
while the menu is in its exec(), byt the qqmlincubator.
if so, close the already existing menu.

BUG:334562
 2014-05-12 11:02:56 +02:00
Marco Martin
97831b616f experim API to move plamoids between containments 2014-05-09 18:43:33 +02:00
Marco Martin
759036e19f remove dead code 2014-05-09 14:24:05 +02:00
Marco Martin
ea3544deb7 remove unused function 2014-05-09 14:21:23 +02:00
Marco Martin
53893e8d0b make the toolbox directly child of containmentinterface 2014-05-07 20:27:51 +02:00
Marco Martin
f21851548c new api for availablescreensize/region 2014-05-07 15:18:21 +02:00
Eike Hein
1805bb7496 Make sure the args part of Containment::createApplet(..., args) ends up in the applet. 2014-05-06 20:52:42 +02:00
Aleix Pol
556c1e321a Remove random qDebug output 
Makes it easier to spot the actual problems on the output. If there's
something that's actually indicating a problem, we should make it a
qWarning.
 2014-05-06 19:57:37 +02:00
Marco Martin
ac963b8a27 emit externalData only after the ui is here 2014-05-06 19:28:44 +02:00
Marco Martin
a7928f29dd if there are args, emit externalData 2014-05-06 19:06:31 +02:00
l10n daemon script
5713f72542 SVN_SILENT made messages (.desktop file) 2014-05-03 08:34:24 +00:00
l10n daemon script
d55335d2a9 SVN_SILENT made messages (.desktop file) 2014-05-02 08:52:44 +00:00
Marco Martin
4851be6e1e don't crash if destroy happens before first sync 2014-04-29 18:21:28 +02:00
l10n daemon script
238bc54c5b SVN_SILENT made messages (.desktop file) 2014-04-29 10:13:52 +00:00
l10n daemon script
012b0681c9 SVN_SILENT made messages (.desktop file) 2014-04-29 04:51:45 +00:00
l10n daemon script
d2f752597f SVN_SILENT made messages (.desktop file) 2014-04-28 15:59:04 +00:00
Aleix Pol
94dc5c30c9 Remove unneeded statements 2014-04-28 17:18:11 +02:00
l10n daemon script
8fcd320f27 SVN_SILENT made messages (.desktop file) 2014-04-28 12:45:07 +00:00
l10n daemon script
b9130c7c24 SVN_SILENT made messages (.desktop file) 2014-04-28 09:02:00 +00:00
l10n daemon script
880da9b195 SVN_SILENT made messages (.desktop file) 2014-04-28 05:09:56 +00:00