Commit Graph

13621 Commits

Author SHA1 Message Date
David Edmundson
4233f7f38e Warning --
Change-Id: I7649fc9f9209816be909217f1c71e7bbe60ab10f
2014-10-01 03:04:52 +02:00
Marco Martin
5d639b0a00 dialogtest is valid only on X11
Change-Id: I20fc562d08545a242d36d2e87776be56f8eea52b
2014-09-30 19:03:54 +02:00
Marco Martin
656582eb66 make sure the cache dir is empty
Change-Id: I916bc173fe3b257705b698d1fe66c5b2bdeb8d3e
QStandardPaths::enableTestMode and clean the cache folder
2014-09-30 18:12:26 +02:00
Marco Martin
ff9703aabf consistent border size
make the dialogs borders the same for composite and non composite mode
more consistent behavior -and- fixes a test on openbox

Change-Id: Idd687a1f3b44f89d35886e1f9a86c2543741cbdb
2014-09-30 17:48:53 +02:00
Marco Martin
792c39a9bb Merge "queue change of minimum/maximum size" 2014-09-30 17:02:46 +02:00
Marco Martin
afe0524fa7 queue change of minimum/maximum size
the layout size hints can change all together, in any order possible.
the only way to have a deterministic behavior is to compress them
and do the sync of the size all at once.
also being sure to do a single adjustGeometry (one X call) instead of
separate setWidth/setHeight

a test for the issue is dialog_resizeWithParent.qml

BUG:339478
Change-Id: Ia7c3c55e40ff89971beb734dcd205df05bfba687
2014-09-30 16:34:21 +02:00
l10n daemon script
f0ad60f7cf SVN_SILENT made messages (.desktop file) 2014-09-30 10:54:42 +00:00
Andrew Lake
8a3742b78a fix button shadow. Buttons on lock, logout screen should look better when focused. 2014-09-29 22:06:09 -07:00
Andrew Lake
07289d9bd4 add more icon sizes for battery, klipper and network tooltip icons.
- tooltip icon use appears to be inconsistent but at least the icons are now available.
2014-09-29 21:18:14 -07:00
Andrew Lake
b798be64fa use 10% increments for battery icons and
update matadata.desktop versions using suggested version numbering
2014-09-29 14:39:17 -07:00
Andrew Lake
86b62039cb add missing Fill0 battery icon 2014-09-29 10:41:51 -07:00
David Edmundson
55368fac23 Update breeze-dark version to match breeze
Otherwise caches don't get cleaned when the SVGs change

Change-Id: I112a1f7305b1f1113ec531a8eaf081b76f0a22af
2014-09-29 15:24:34 +02:00
Marco Martin
1dfd55d999 test that messes with size hints
changine the minimum and maximum heights, causes the dialog to not be repositioned
at the correct position with the visual parent

Change-Id: Ib67e6b842f5b4e3563da2ae826aa0c358cc208f4
2014-09-29 10:28:31 +02:00
Andrew Lake
c6ebb64379 update theme version after icon updates 2014-09-29 00:34:13 -07:00
Andrew Lake
cc8b47553d update theme icons based on feedback:
- Consistent stroke width
- 22x22 replaces 24x24 sizes
- align most icons to pixel grid
- changed some icon designs based of feedback of plasma dev team
2014-09-29 00:21:55 -07:00
Volker Krause
ca77cad251 Make constants const, saves a few symbols in the .data section. 2014-09-28 12:40:40 +02:00
David Edmundson
489ca7b76a Test progress bars
Change-Id: Iab1be67dc4ab059ab85ba2833df0da80775ed61f
2014-09-26 17:37:53 +02:00
David Edmundson
94c4bff3da Merge "Add component tests" 2014-09-26 17:20:33 +02:00
David Edmundson
56e1c9c48a warnings--
Change-Id: If41d2ebcec822002edb5282dd401b84fc2d40a10
2014-09-26 17:05:30 +02:00
David Edmundson
f5b8b164c3 Warnings--
Change-Id: I97e12f614c677914306594170435a7d3ddac102a
2014-09-26 17:03:45 +02:00
David Edmundson
0d209f9d2a Make KWindowSystem a public dependency of plasmaquick
Dialog.h uses netwm_def.h in the header so it should be included by apps
that use plasmaquick implicitly

Change-Id: I55507f552025468dde32e4830a78e34dc35c03af
2014-09-26 16:47:46 +02:00
David Edmundson
d9bf760c14 warnings--
Change-Id: Ide6d4301162f617ae0846df8ea2ef938982f9a7f
2014-09-26 16:34:09 +02:00
David Edmundson
62d240b7d6 Only update real visibility when component has finished completion
We only want to toggle our visibility until after all window flags have
been set, as some flags can only be set before the window is shown.

This patch caches and proxies the visibility flag and only update the
real visibility when the component is complete.

Change-Id: I4ce7744dc48afecf35db6679ca0991b7042e45a2
2014-09-26 16:17:33 +02:00
David Edmundson
9bafdb6ed6 Dialog auto tests
Add a test that checks all dialog flags are set when a dialog becomes
visible.

Renamed existing dialog test for clarity

Change-Id: I3677816877860cab3303122e81f9ee30fc563e39
2014-09-26 16:17:28 +02:00
Marco Martin
87e3240f72 don't make the progressbar smaller than its borders
BUG:338225
Change-Id: Ia5926206b9185c82bcdf96956bc7f586c3b2d50e
2014-09-25 18:31:19 +02:00
Marco Martin
5b50373b37 if rootObject exists, component is here and ready
Change-Id: I37deb527a04dde9ce458c5aea8e178b3d08b1b46
2014-09-25 18:02:59 +02:00
Marco Martin
a71697e68d the qquickitem con be resized before qml is created
AppletQuickItemPrivate::compactRepresentationCheck() must not be executed before
the qml parse is over and rootObject is here: the creation of the full or compact representation
would go very wrong in that case

Change-Id: Ib72f7d25f570a1ae34ada3330080350384d5c1e8
CCBUG:339329
2014-09-25 17:57:14 +02:00
Marco Martin
09e30e5f31 Merge "share icon rounding code between Units/IconItem" 2014-09-25 14:52:27 +02:00
Marco Martin
8aab4ac9c7 share icon rounding code between Units/IconItem
it should ensure both share the same behavior

Change-Id: I2de37f5fb43bdcdd482ede9252c68fc207efbe39
2014-09-25 14:48:45 +02:00
David Edmundson
565cc50ca2 Remove rather outdated .svn install exclusion
Change-Id: Ia5c5fca18e3ca0d18a272cd641569d5ed50594a4
2014-09-25 13:16:28 +02:00
David Edmundson
71e9de7ce4 Don't install developer notes in plasma_install_package
In the SDDM theme (and a few other places) I leave some notes for other
developers; I need to add one to the workspace components too.

As plasma_package blindly copies everything it seems to annoy packagers.

Change-Id: I77765f96f1a5fb24a7788f69eae1bbffaf14210b
2014-09-25 13:15:04 +02:00
David Edmundson
40fbd5f13c Add component tests
The rationale is to build simple tests which cover most combos of
components

Change-Id: I771a511eb3589c3815600697a800d4250e50175d
2014-09-25 12:37:44 +02:00
Marco Martin
18b57ffc29 fix tooltips
use adjustSize in updateMinimumWidth et al.
changing tooltip content updates sizeHints
using setGeometry is immediate, and will kill the animations.
for dialogs other than tooltips there is no change since adjustGeometry
is just setGeometry

Change-Id: I3e6310f12f76e400f2663b8409a2bbc7e7398f39
2014-09-24 14:07:30 +02:00
Marco Martin
e3fd010166 don't update the minimum size when not visible
since when is not visible the dialog doesn't update its size
from the mainItem size, the minimum size should not be
updated as well, or the initial mainitem size will get lost
and the dialog will be initialized to a wrong size

Patch by: Vishesh Handa <vhanda@kde.org>

Change-Id: I272727fb4732474b102de64c9bfdddb7fc3906c8
2014-09-23 17:05:09 +02:00
Marco Martin
d28871cb65 Merge "fix availableScreenGeometryForPosition()" 2014-09-23 12:50:55 +02:00
David Edmundson
8a70067e8c Don't duplicate background resizing to contents
The code in Button is
panel.implicitWidth: max(label+borders, backgroundImplicitSize)

by setting the background implicitSize to be max(size, labels+borders)
we just duplicate the functionality.

This worked, but icon only buttons became smaller because we weren't
setting the implicitHeight of the label properly.

(two wrongs were making a right)

We need to move the RowLayout inside an Item as we are modiyfing the
preferredHeight of RowLayout, but this doesn't sync back to updating the
implicitHeight which Button.qml uses.

This fixes all binding loops and the rather broken icon only flat
button.

Change-Id: Id2f9c2ab37b2280ee69dc1473f388fe686e3327e
2014-09-23 10:22:35 +02:00
David Edmundson
b2a5ebc926 Update hover effect to match QtQuickControls port
Change-Id: Ib3ad938f24d2a7c9e5d8c6cdd5d6717b3574351a
2014-09-22 19:01:31 +02:00
l10n daemon script
88ccf7be3d SVN_SILENT made messages (.desktop file) 2014-09-22 08:34:39 +00:00
Marco Martin
b98fdd7753 introduce roundToIconSize(int size)
return a size rounded tothe nearest inferior standard icon size.
sizes larger than iconSizes.huge, it will be returned unmodified
Reviewed by: Kai Uwe Broulik <kde@privat.broulik.de>

Change-Id: I85c575ea1cc7965ae9bede9e5a8b7b4cb342580e
2014-09-19 16:38:22 +02:00
Marco Martin
cd8c134578 increase version number
systray icons have changed, increase the version number
(correct and will force a cahce drop)

Change-Id: I46bd169e1e221daf16d7c45ab12370437b74688d
2014-09-19 14:38:31 +02:00
l10n daemon script
f12eb638f0 SVN_SILENT made messages (.desktop file) 2014-09-19 09:02:03 +00:00
Marco Martin
60a7419746 fix availableScreenGeometryForPosition()
when we check if a position is in a screen, we need
the whole screen geometry, panels included, otherwise if we pass
a coordinate under a panel, it will think no screen is there

Change-Id: I802a2bec4ae44b583eafdc309934e67b620cc463
2014-09-18 17:35:18 +02:00
Marco Martin
dff792a86b Update the size in two ways
A dialog can be resized for two reasons: the mainItem size changes, or the dialog size changes.

the first can happen programmatically, caused by the Layout, or just by assigning the width.

the second can be caused either programmatically, assigning the size of the dialog or externally by the windowmanager, that is the only one theat in the end has the only final control of the window size

Change-Id: Ifc5c7f683039f83d13a5046c10d6dd0227169542
REVIEW:120235
2014-09-18 17:25:48 +02:00
David Edmundson
4a95748249 Don't redeclare QQuickItem properties for implicitSizes
Change-Id: I96a8e6acd23cdee77048bc064963c7735b6615db
2014-09-17 23:23:15 +02:00
Marco Martin
ac0c457b65 partly revert last commit
revert part of
306e353fe6

if a framesvgitem has an implicitsize explicitly set, it shouldn't be overwritten

Change-Id: I931ca8acafdc2f6908945d03fca97487ced22988
2014-09-17 20:21:34 +02:00
Marco Martin
306e353fe6 take into account device pixel ratio
make sure framesvgitem returns the proper implicitWidth/height

Change-Id: I6d756e474c69bb32d2abef1a34d989c339d28ef9
2014-09-17 20:04:17 +02:00
Marco Martin
a393284338 get rid of internal ShellPackage
ShellPackage is a plugin in plasma-workspace now, don't duplicate

Change-Id: I77edf63acf6c99314f6062d7ef2f55a129727013
2014-09-17 14:47:13 +02:00
Marco Martin
0ec9ea7d04 make sure applets are sorted by id
As with containment, make sure Containment::applets()
is always sorted by id, to have the least sursprises possible

it adds a test

Change-Id: Ib1aeeff7c70bb6969b32b2fef8557889a43edf09
2014-09-17 14:47:13 +02:00
Marco Martin
9957652d15 Ensure corona::containments() is ordered
the order in which containments were restored used to be quite random:
ensure that's ordered by id this makes the shell startups be more reproduceable
from one to another, if a new containment arrives, ensure it's inserted
maintaining id order

containment::appelts() will need the same treatment

adds a test as well that checks the order is right

Change-Id: Ie1b278e5b83d7e3645f7293bf6d030aa7f43a221
2014-09-17 14:47:13 +02:00
Marco Martin
edef5c1dc1 base on screen() to see what containment is loading
if a containment's lastScreen is not -1 (and a valid screen)
*and* its activity() is not the current one, its QML
will *not* be loaded, therefore it would dangle blocking
corona::startupCompleted until the activity is selected

Change-Id: I6757d29240a012377e9ff0a22fe16541ea712ee6
2014-09-17 14:47:13 +02:00