/* * Copyright 2007 by Aaron Seigo * Copyright 2007 by Riccardo Iaconelli * Copyright 2007 by Matt Broadstone * Copyright 2006-2007 Fredrik Höglund * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU Library General Public License as * published by the Free Software Foundation; either version 2, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details * * You should have received a copy of the GNU Library General Public * License along with this program; if not, write to the * Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "icon.h" #include "icon_p.h" #include #include #include #include #include #include #include //#define BACKINGSTORE_BLUR_HACK #ifdef BACKINGSTORE_BLUR_HACK #include #endif #include #include #include #include #include #include #include #include "phase.h" #include "svg.h" #include "effects/blur.cpp" namespace Plasma { Icon::Private::Private() : svg("widgets/iconbutton"), svgElements(0), size(48*1.1, 48*1.1), iconSize(48, 48), state(Private::NoState), orientation(Qt::Vertical), calculateSizeRequested(true) // First time always true { svg.setContentType(Plasma::Svg::ImageSet); svg.resize(size); //TODO: recheck when svg changes checkSvgElements(); } Icon::Private::~Private() { qDeleteAll(cornerActions); } void Icon::Private::checkSvgElements() { if (svg.elementExists("background")) { svgElements |= SvgBackground; } if (svg.elementExists("background-hover")) { svgElements |= SvgBackgroundHover; } if (svg.elementExists("background-pressed")) { svgElements |= SvgBackgroundPressed; } if (svg.elementExists("foreground")) { svgElements |= SvgForeground; } if (svg.elementExists("foreground-hover")) { svgElements |= SvgForegroundHover; } if (svg.elementExists("foreground-pressed")) { svgElements |= SvgForegroundPressed; } if (svg.elementExists("minibutton")) { svgElements |= SvgMinibutton; } if (svg.elementExists("minibutton-hover")) { svgElements |= SvgMinibuttonHover; } if (svg.elementExists("minibutton-pressed")) { svgElements |= SvgMinibuttonPressed; } } IconAction::IconAction(Icon* icon, QAction *action) : m_icon(icon), m_action(action), m_hovered(false), m_pressed(false), m_visible(false), m_animationId(-1) { } void IconAction::show() { if (m_animationId) { Phase::self()->stopElementAnimation(m_animationId); } rebuildPixmap(); m_animationId = Phase::self()->animateElement(m_icon, Phase::ElementAppear); Phase::self()->setAnimationPixmap(m_animationId, m_pixmap); m_visible = true; } void IconAction::hide() { if (m_animationId) { Phase::self()->stopElementAnimation(m_animationId); } rebuildPixmap(); m_animationId = Phase::self()->animateElement(m_icon, Phase::ElementDisappear); Phase::self()->setAnimationPixmap(m_animationId, m_pixmap); m_visible = false; } bool IconAction::isVisible() const { return m_visible; } bool IconAction::isPressed() const { return m_pressed; } bool IconAction::isHovered() const { return m_hovered; } void IconAction::setSelected(bool selected) { m_selected = selected; } bool IconAction::isSelected() const { return m_selected; } void IconAction::setRect(const QRectF &rect) { m_rect = rect; } QRectF IconAction::rect() const { return m_rect; } void IconAction::rebuildPixmap() { // Determine proper QIcon mode based on selection status QIcon::Mode mode = QIcon::Normal; if (m_selected) { mode = QIcon::Selected; } // Draw everything m_pixmap = QPixmap(26, 26); m_pixmap.fill(Qt::transparent); int element = Icon::Private::SvgMinibutton; if (m_pressed) { element = Icon::Private::SvgMinibuttonPressed; } else if (m_hovered) { element = Icon::Private::SvgMinibuttonHover; } QPainter painter(&m_pixmap); m_icon->drawActionButtonBase(&painter, m_pixmap.size(), element); m_action->icon().paint(&painter, 2, 2, 22, 22, Qt::AlignCenter, mode); } bool IconAction::event(QEvent::Type type, const QPointF &pos) { switch (type) { case QEvent::MouseButtonPress: { setSelected(m_rect.contains(pos)); return isSelected(); } break; case QEvent::MouseMove: { bool wasSelected = isSelected(); bool active = m_rect.contains(pos); setSelected(wasSelected && active); return (wasSelected != isSelected()) || active; } break; case QEvent::MouseButtonRelease: { // kDebug() << "IconAction::event got a QEvent::MouseButtonRelease, " << isSelected(); bool wasSelected = isSelected(); setSelected(false); if (wasSelected) { m_action->trigger(); } return wasSelected; } break; case QEvent::GraphicsSceneHoverEnter: m_pressed = false; m_hovered = true; break; case QEvent::GraphicsSceneHoverLeave: m_pressed = false; m_hovered = false; break; default: break; } return false; } Phase::AnimId IconAction::animationId() const { return m_animationId; } QAction* IconAction::action() const { return m_action; } void IconAction::paint(QPainter *painter) const { painter->drawPixmap(m_rect.toRect(), Phase::self()->animationResult(m_animationId)); } Icon::Icon(QGraphicsItem *parent) : Plasma::Widget(parent), d(new Private) { init(); } Icon::Icon(const QString &text, QGraphicsItem *parent) : Plasma::Widget(parent), d(new Private) { setText(text); init(); } Icon::Icon(const QIcon &icon, const QString &text, QGraphicsItem *parent) : Plasma::Widget(parent), d(new Private) { setText(text); setIcon(icon); init(); } Icon::~Icon() { delete d; } void Icon::init() { // setAcceptedMouseButtons(Qt::LeftButton); setAcceptsHoverEvents(true); int focusHMargin = QApplication::style()->pixelMetric(QStyle::PM_FocusFrameHMargin); int focusVMargin = QApplication::style()->pixelMetric(QStyle::PM_FocusFrameVMargin); // Margins for horizontal mode (list views, tree views, table views) d->setHorizontalMargin(Private::TextMargin, focusHMargin, focusVMargin); d->setHorizontalMargin(Private::IconMargin, focusHMargin, focusVMargin); d->setHorizontalMargin(Private::ItemMargin, 0, 0); // Margins for vertical mode (icon views) d->setVerticalMargin(Private::TextMargin, 6, 2); d->setVerticalMargin(Private::IconMargin, focusHMargin, focusVMargin); d->setVerticalMargin(Private::ItemMargin, 0, 0); calculateSize(); } void Icon::addAction(QAction *action) { int count = d->cornerActions.count(); if (count > 3) { kDebug() << "Icon::addAction(QAction*) no more room for more actions!"; } IconAction* iconAction = new IconAction(this, action); d->cornerActions.append(iconAction); connect(action, SIGNAL(destroyed(QObject*)), this, SLOT(actionDestroyed(QObject*))); //TODO: fewer magic numbers, please =) 38, 32, 6, etc... needs to go. // at the very least static const ints with nice names. switch (count) { case Private::TopLeft: iconAction->setRect(QRectF(6, 6, 32, 32)); break; case Private::TopRight: iconAction->setRect(QRectF(d->size.width() - 38, 6, 32, 32)); break; case Private::BottomLeft: iconAction->setRect(QRectF(6, d->size.height() - 38, 32, 32)); break; case Private::BottomRight: iconAction->setRect(QRectF(d->size.width() - 38, d->size.height() - 38, 32, 32)); break; } } void Icon::actionDestroyed(QObject* action) { QList::iterator it = d->cornerActions.begin(); while (it != d->cornerActions.end()) { if ((*it)->action() == action) { d->cornerActions.erase(it); break; } } update(); // redraw since an action has been deleted. } QSizeF Icon::Private::displaySizeHint(const QStyleOptionGraphicsItem *option) const { QString label = text; // const qreal maxWidth = (orientation == Qt::Vertical) ? iconSize.width() + 10 : 32757; // NOTE: find a way to use the other layoutText, it currently returns nominal width, when // we actually need the actual width. // To compute the nominal size for the label + info, we'll just append // the information string to the label const QString info = infoText; if (!info.isEmpty()) label += QString(QChar::LineSeparator) + info; QTextLayout layout; setLayoutOptions(layout, option); QSizeF size = layoutText(layout, option, label, QSizeF(iconSize.width() + 10, 32757)); return addMargin(size, TextMargin); } void Icon::calculateSize() { if (d->calculateSizeRequested = true) { // We do this to get size hint information before the icon has been drawn, as // we have no access to the style option before that time. So we create a dummy. QStyleOptionGraphicsItem option; option.state = QStyle::State_None; option.rect = boundingRect().toRect(); calculateSize(&option); } else { d->calculateSizeRequested = true; } } void Icon::calculateSize(const QStyleOptionGraphicsItem *option) { if (!d->calculateSizeRequested) return; prepareGeometryChange(); d->setActiveMargins(); const QSizeF displaySize = d->displaySizeHint(option); const QSizeF decorationSize = d->addMargin(d->iconSize, Private::IconMargin); QSizeF newSize; if (d->orientation == Qt::Vertical) { newSize.rwidth() = qMax(decorationSize.width(), displaySize.width()); newSize.rheight() = decorationSize.height() + displaySize.height() + 1; } else { newSize.rwidth() = decorationSize.width() + displaySize.width() + 1; newSize.rheight() = qMax(decorationSize.height(), displaySize.height()); } d->size = d->addMargin(newSize, Private::ItemMargin); d->svg.resize(d->size); d->calculateSizeRequested = false; int count = 0; foreach (IconAction* iconAction, d->cornerActions) { //TODO: fewer magic numbers, please =) 38, 32, 6, etc... needs to go. // at the very least static const ints with nice names. switch (count) { case Private::TopLeft: // top left never changes, so don't bother setting it //iconAction->setRect(QRectF(6, 6, 32, 32)); break; case Private::TopRight: iconAction->setRect(QRectF(d->size.width() - 38, 6, 32, 32)); break; case Private::BottomLeft: iconAction->setRect(QRectF(6, d->size.height() - 38, 32, 32)); break; case Private::BottomRight: iconAction->setRect(QRectF(d->size.width() - 38, d->size.height() - 38, 32, 32)); break; } ++count; } update(); } QRectF Icon::boundingRect() const { return QRectF(QPointF(0, 0), d->size); } void Icon::Private::drawBackground(QPainter *painter) { QString element; if (svgElements & Private::SvgBackground) { element = "background"; } switch (state) { case Private::NoState: break; case Private::HoverState: if (svgElements & Private::SvgBackgroundHover) { element = "background-hover"; } break; case Private::PressedState: if (svgElements & Private::SvgBackgroundPressed) { element = "background-pressed"; } else if (svgElements & Private::SvgBackgroundHover) { element = "background-hover"; } break; } if (!element.isEmpty()) { svg.paint(painter, 0, 0, element); } } void Icon::Private::drawForeground(QPainter *painter) { QString element; if (svgElements & Private::SvgForeground) { element = "foreground"; } switch (state) { case Private::NoState: break; case Private::HoverState: if (svgElements & Private::SvgForegroundHover) { element = "foreground-hover"; } break; case Private::PressedState: if (svgElements & Private::SvgForegroundPressed) { element = "foreground-pressed"; } else if (svgElements & Private::SvgForegroundHover) { element = "foreground-hover"; } break; } if (!element.isEmpty()) { svg.paint(painter, 0, 0, element); } } QPixmap Icon::Private::decoration(const QStyleOptionGraphicsItem *option) const { QPixmap result; QIcon::Mode mode = option->state & QStyle::State_Enabled ? QIcon::Normal : QIcon::Disabled; QIcon::State state = option->state & QStyle::State_Open ? QIcon::On : QIcon::Off; const QSize size = icon.actualSize(iconSize.toSize(), mode, state); result = icon.pixmap(size, mode, state); if (!result.isNull()) { // Apply the configured hover effect NOTE: This has no visible effect because we // do drawForeground() -MB if (option->state & QStyle::State_MouseOver) { KIconEffect *effect = KIconLoader::global()->iconEffect(); // Note that in KIconLoader terminology, active = hover. // ### We're assuming that the icon group is desktop/filemanager, since this // is KFileItemDelegate. if (effect->hasEffect(KIconLoader::Desktop, KIconLoader::ActiveState)) { result = effect->apply(result, KIconLoader::Desktop, KIconLoader::ActiveState); } } } return result; } QPointF Icon::Private::iconPosition(const QStyleOptionGraphicsItem *option, const QPixmap &pixmap) const { const QRectF itemRect = subtractMargin(option->rect, Private::ItemMargin); Qt::Alignment alignment = Qt::AlignHCenter | Qt::AlignTop; // NOTE: This assumes always top-center -MB // Compute the nominal decoration rectangle const QSizeF size = addMargin(iconSize, Private::IconMargin); const QRect iconRect = QStyle::alignedRect(option->direction, alignment, size.toSize(), itemRect.toRect()); // Position the pixmap in the center of the rectangle QRect pixmapRect = pixmap.rect(); pixmapRect.moveCenter(iconRect.center()); // add a gimmicky margin of 5px to y, TEMP TEMP TEMP // pixmapRect = pixmapRect.adjusted(0, 5, 0, 0); return QPointF(pixmapRect.topLeft()); } QRectF Icon::Private::labelRectangle(const QStyleOptionGraphicsItem *option, const QPixmap &icon, const QString &string) const { Q_UNUSED(string) if (icon.isNull()) return option->rect; const QSizeF decoSize = addMargin(iconSize, Private::IconMargin); const QRectF itemRect = subtractMargin(option->rect, Private::ItemMargin); QRectF textArea(QPointF(0, 0), itemRect.size()); textArea.setTop(decoSize.height() + 1); textArea.translate(itemRect.topLeft()); return QRectF(QStyle::visualRect(option->direction, option->rect, textArea.toRect())); } // Lays the text out in a rectangle no larger than constraints, eliding it as necessary QSizeF Icon::Private::layoutText(QTextLayout &layout, const QStyleOptionGraphicsItem *option, const QString &text, const QSizeF &constraints) const { const QSizeF size = layoutText(layout, text, constraints.width()); if (size.width() > constraints.width() || size.height() > constraints.height()) { const QString elided = elidedText(layout, option, constraints); return layoutText(layout, elided, constraints.width()); } return size; } // Lays the text out in a rectangle no wider than maxWidth QSizeF Icon::Private::layoutText(QTextLayout &layout, const QString &text, qreal maxWidth) const { QFontMetricsF metrics(layout.font()); qreal leading = metrics.leading(); qreal height = 0.0; qreal widthUsed = 0.0; QTextLine line; layout.setText(text); layout.beginLayout(); while ((line = layout.createLine()).isValid()) { line.setLineWidth(maxWidth); height += leading; line.setPosition(QPointF(0.0, height)); height += line.height(); widthUsed = qMax(widthUsed, line.naturalTextWidth()); } layout.endLayout(); return QSizeF(widthUsed, height); } // Elides the text in the layout, by iterating over each line in the layout, eliding // or word breaking the line if it's wider than the max width, and finally adding an // ellipses at the end of the last line, if there are more lines than will fit within // the vertical size constraints. QString Icon::Private::elidedText(QTextLayout &layout, const QStyleOptionGraphicsItem *option, const QSizeF &size) const { Q_UNUSED(option) QFontMetricsF metrics(layout.font()); const QString text = layout.text(); qreal maxWidth = size.width(); qreal maxHeight = size.height(); qreal height = 0; // If the string contains a single line of text it shouldn't be word wrapped if (text.indexOf(QChar::LineSeparator) == -1) return metrics.elidedText(text, Qt::ElideRight, maxWidth); // Elide each line that has already been laid out in the layout. QString elided; elided.reserve(text.length()); for (int i = 0; i < layout.lineCount(); i++) { QTextLine line = layout.lineAt(i); int start = line.textStart(); int length = line.textLength(); height += metrics.leading(); if (height + line.height() + metrics.lineSpacing() > maxHeight) { // Unfortunately, if the line ends because of a line separator, elidedText() will be too // clever and keep adding lines until it finds one that's too wide. if (line.naturalTextWidth() < maxWidth && text[start + length - 1] == QChar::LineSeparator) elided += text.mid(start, length - 1); else elided += metrics.elidedText(text.mid(start), Qt::ElideRight, maxWidth); break; } else if (line.naturalTextWidth() > maxWidth) elided += metrics.elidedText(text.mid(start, length), Qt::ElideRight, maxWidth); else elided += text.mid(start, length); height += line.height(); } return elided; } void Icon::Private::layoutTextItems(const QStyleOptionGraphicsItem *option, const QPixmap &icon, QTextLayout *labelLayout, QTextLayout *infoLayout, QRectF *textBoundingRect) const { bool showInformation = false; setLayoutOptions(*labelLayout, option); QFontMetricsF fm(labelLayout->font()); const QRectF textArea = labelRectangle(option, icon, text); QRectF textRect = subtractMargin(textArea, Private::TextMargin); // Sizes and constraints for the different text parts QSizeF maxLabelSize = textRect.size(); QSizeF maxInfoSize = textRect.size(); QSizeF labelSize; QSizeF infoSize; // If we have additional info text, and there's space for at least two lines of text, // adjust the max label size to make room for at least one line of the info text if (!infoText.isEmpty() && textRect.height() >= fm.lineSpacing() * 2) { infoLayout->setFont(labelLayout->font()); infoLayout->setTextOption(labelLayout->textOption()); maxLabelSize.rheight() -= fm.lineSpacing(); showInformation = true; } // Lay out the label text, and adjust the max info size based on the label size labelSize = layoutText(*labelLayout, option, text, maxLabelSize); maxInfoSize.rheight() -= labelSize.height(); // Lay out the info text if (showInformation) infoSize = layoutText(*infoLayout, option, infoText, maxInfoSize); else infoSize = QSizeF(0, 0); // Compute the bounding rect of the text const Qt::Alignment alignment = labelLayout->textOption().alignment(); const QSizeF size(qMax(labelSize.width(), infoSize.width()), labelSize.height() + infoSize.height()); *textBoundingRect = QStyle::alignedRect(option->direction, alignment, size.toSize(), textRect.toRect()); // Compute the positions where we should draw the layouts labelLayout->setPosition(QPointF(textRect.x(), textBoundingRect->y())); infoLayout->setPosition(QPointF(textRect.x(), textBoundingRect->y() + labelSize.height())); } QBrush Icon::Private::foregroundBrush(const QStyleOptionGraphicsItem *option) const { const QPalette::ColorGroup group = option->state & QStyle::State_Enabled ? QPalette::Normal : QPalette::Disabled; // Always use the highlight color for selected items if (option->state & QStyle::State_Selected) return option->palette.brush(group, QPalette::HighlightedText); return option->palette.brush(group, QPalette::Text); } QBrush Icon::Private::backgroundBrush(const QStyleOptionGraphicsItem *option) const { const QPalette::ColorGroup group = option->state & QStyle::State_Enabled ? QPalette::Normal : QPalette::Disabled; QBrush background(Qt::NoBrush); // Always use the highlight color for selected items if (option->state & QStyle::State_Selected) background = option->palette.brush(group, QPalette::Highlight); return background; } void Icon::Private::drawTextItems(QPainter *painter, const QStyleOptionGraphicsItem *option, const QTextLayout &labelLayout, const QTextLayout &infoLayout) const { QPen pen(foregroundBrush(option), 0); painter->setPen(pen); labelLayout.draw(painter, QPointF()); if (!infoLayout.text().isEmpty()) { QColor color; if (option->state & QStyle::State_Selected) { color = option->palette.color(QPalette::HighlightedText); color.setAlphaF(.5); } else color = option->palette.color(QPalette::Highlight); painter->setPen(color); infoLayout.draw(painter, QPointF()); } } void Icon::paintWidget(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget) { Q_UNUSED(option) Q_UNUSED(widget) #ifdef BACKINGSTORE_BLUR_HACK if (d->state == Private::HoverState && scene()) { QList views = scene()->views(); if (views.count() > 0) { QPixmap* pix = static_cast(views[0]->windowSurface()->paintDevice()); QImage image(boundingRect().size().toSize(), QImage::Format_ARGB32_Premultiplied); { QPainter p(&image); p.drawPixmap(image.rect(), *pix, sceneBoundingRect()); } expblur<16,7>(image, 8); painter->drawImage(0, 0, image); } } #endif calculateSize(option); d->setActiveMargins(); // Compute the metrics, and lay out the text items // ======================================================================== QPixmap icon = d->decoration(option); const QPointF iconPos = d->iconPosition(option, icon); QTextLayout labelLayout, infoLayout; QRectF textBoundingRect; d->layoutTextItems(option, icon, &labelLayout, &infoLayout, &textBoundingRect); d->svg.resize(d->size); d->drawBackground(painter); // draw icon painter->drawPixmap(iconPos, icon); d->drawForeground(painter); // Draw corner actions foreach (IconAction *action, d->cornerActions) { if (action->animationId()) { action->paint(painter); } } // Draw text last because its overlayed d->drawTextItems(painter, option, labelLayout, infoLayout); } void Icon::drawActionButtonBase(QPainter* painter, const QSize &size, int element) { // Determine proper svg element QString id; if (d->svgElements & Private::SvgMinibutton) { id = "minibutton"; } if (element == Private::SvgMinibuttonPressed) { if (d->svgElements & Private::SvgMinibuttonPressed) { id = "minibutton-pressed"; } else if (d->svgElements & Private::SvgMinibuttonHover) { id = "minibutton-hover"; } } else if (element == Icon::Private::SvgMinibuttonHover && d->svgElements & Private::SvgMinibuttonHover) { id = "minibutton-hover"; } if (!id.isEmpty()) { d->svg.resize(size); d->svg.paint(painter, 0, 0, id); } } void Icon::setText(const QString& text) { d->text = text; calculateSize(); } QString Icon::text() const { return d->text; } void Icon::setInfoText(const QString& text) { d->infoText = text; calculateSize(); } QString Icon::infoText() const { return d->infoText; } QIcon Icon::icon() const { return d->icon; } void Icon::setIcon(const QString& icon) { if (icon.isEmpty()) { setIcon(QIcon()); return; } setIcon(KIcon(icon)); } void Icon::setIcon(const QIcon& icon) { d->icon = icon; calculateSize(); } QSizeF Icon::iconSize() const { return d->iconSize; } void Icon::setIconSize(const QSizeF& s) { d->iconSize = s; calculateSize(); } void Icon::setIconSize(int w, int h) { setIconSize(QSizeF(w, h)); } bool Icon::isDown() { return d->state == Private::PressedState; } void Icon::mousePressEvent(QGraphicsSceneMouseEvent *event) { //kDebug(); foreach (IconAction *action, d->cornerActions) { action->event(event->type(), event->pos()); } d->state = Private::PressedState; emit pressed(true); emit pressed(true, event); event->accept(); update(); } void Icon::mouseReleaseEvent(QGraphicsSceneMouseEvent *event) { //kDebug(); bool inside = boundingRect().contains(event->pos()); Private::ButtonState was = d->state; if (inside) { d->state = Private::HoverState; foreach (IconAction *action, d->cornerActions) { if (action->event(event->type(), event->pos())) { inside = false; break; } } } else { d->state = Private::NoState; } if (was == Private::PressedState) { emit pressed(false); emit pressed(false, event); if (inside) { emit clicked(); emit clicked(event); } d->state = Private::NoState; } event->ignore(); update(); } void Icon::hoverEnterEvent(QGraphicsSceneHoverEvent *event) { foreach (IconAction *action, d->cornerActions) { action->show(); action->event(event->type(), event->pos()); } d->state = Private::HoverState; Widget::hoverEnterEvent(event); } void Icon::hoverLeaveEvent(QGraphicsSceneHoverEvent *event) { foreach (IconAction *action, d->cornerActions) { action->hide(); action->event(event->type(), event->pos()); } d->state = Private::NoState; Widget::hoverLeaveEvent(event); } void Icon::mouseMoveEvent(QGraphicsSceneMouseEvent *event) { if (d->state == Private::PressedState) { d->state = Private::HoverState; } Widget::mouseMoveEvent(event); } QSizeF Icon::sizeHint() const { return d->size; } Qt::Orientations Icon::expandingDirections() const { return 0; } /* QSizeF Icon::sizeHint() const { return d->size; } QSizeF Icon::minimumSize() const { return d->size; // probably should be more flexible on this =) } QSizeF Icon::maximumSize() const { return d->size; } Qt::Orientations Icon::expandingDirections() const { return Qt::Horizontal; } bool Icon::hasHeightForWidth() const { return true; } qreal Icon::heightForWidth(qreal w) const { return w; //FIXME: we shouldn't assume squareness but actually calculate based on text and what not } bool Icon::hasWidthForHeight() const { return true; } qreal Icon::widthForHeight(qreal h) const { return h; //FIXME: we shouldn't assume squareness but actually calculate based on text and what not } QRectF Icon::geometry() const { return boundingRect(); } void Icon::setGeometry(const QRectF &r) { // TODO: this is wrong, but we should probably never call setGeometry anyway! setIconSize(r.size()); setPos(r.x(),r.y()); } */ } // namespace Plasma #include "icon.moc"