The issue is that we are using a QProxyWidget, and it seems that QWidgets don't have a sensible size() until they're shown for the first time. So we use sizeHint() (or effectiveSizeHint() in this case) instead. The only issue I can see is that if the widget passed to the dialog is in a layout, its size() and effectiveSizeHint(Qt::PreferredSize) might not match. Is this something we need to deal with? If so, how? CCMAIL: plasma-devel@kde.org svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=859660
libplasma Commit Rules: * If your patch is not an obvious or trivial bug fix, have it peer reviewed by another Plasma developer * All code MUST follow the kdelibs coding style, as found at: http://techbase.kde.org/Policies/Kdelibs_Coding_Style * All new public API MUST have apidox written before committing Unit tests are next to godliness. (Though as you can see, right now libplasma is hellbound.) This directory contains the classes making up libplasma, which provides the core framework used by Plasma and its components. This includes applet and extension definitions and loading, common GUI elements, etc. Domain specific sets of functionality, e.g. for network awareness or sensors, are not found here but in one of the Plasma Engines. Please refer to the Plasma website (http://plasma.kde.org) and Plasma wiki (http://techbase.kde.org/Projects/Plasma) for API documentation and design documents regarding this library.
Description
Languages
C++
63.9%
QML
29.4%
CMake
3.3%
Shell
1.3%
Python
1%
Other
1%