amphp
/
sql
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use assert() instead of comments

This commit is contained in:
Aaron Piotrowski 2018-07-10 17:54:04 -05:00
parent f50c02e39f
commit 9130acd08c
No known key found for this signature in database
GPG Key ID: ADD1EF783EDE9EEB
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/StatementPool.php
View File

@ -54,8 +54,8 @@ abstract class StatementPool implements Statement
$idleTimeout = ((int) ($pool->getIdleTimeout() / 10)) ?: 1;
while (!$statements->isEmpty()) {
/** @var Statement $statement */
$statement = $statements->bottom();
\assert($statement instanceof Statement);
if ($statement->lastUsedAt() + $idleTimeout > $now) {
return;
@ -134,15 +134,17 @@ abstract class StatementPool implements Statement
protected function pop(): \Generator
{
while (!$this->statements->isEmpty()) {
/** @var Statement $statement */
$statement = $this->statements->shift();
\assert($statement instanceof Statement);
if ($statement->isAlive()) {
return $statement;
}
}
return yield ($this->prepare)($this->sql);
$statement = yield ($this->prepare)($this->sql);
\assert($statement instanceof Statement);
return $statement;
}
/** {@inheritdoc} */