From 29210cca80856750dcded6d706a6184d8952ca4f Mon Sep 17 00:00:00 2001 From: Andrea Cavalli Date: Thu, 7 Apr 2022 22:19:11 +0200 Subject: [PATCH] More stats --- .../database/disk/AbstractRocksDBColumn.java | 14 +++++++------- .../database/disk/LLLocalKeyValueDatabase.java | 3 +++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/main/java/it/cavallium/dbengine/database/disk/AbstractRocksDBColumn.java b/src/main/java/it/cavallium/dbengine/database/disk/AbstractRocksDBColumn.java index ad480e2..0453892 100644 --- a/src/main/java/it/cavallium/dbengine/database/disk/AbstractRocksDBColumn.java +++ b/src/main/java/it/cavallium/dbengine/database/disk/AbstractRocksDBColumn.java @@ -128,7 +128,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "no") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "disabled") .register(meterRegistry); this.readValueNotFoundWithBloomBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -136,7 +136,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "hit.notfound") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "enabled", "bloom.mayexist", "false") .register(meterRegistry); this.readValueNotFoundWithMayExistBloomBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -144,7 +144,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "hit.wrong") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "false", "bloom", "enabled", "bloom.mayexist", "true", "bloom.mayexist.result", "notexists", "bloom.mayexist.cached", "false") .register(meterRegistry); this.readValueFoundWithBloomUncachedBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -152,7 +152,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "hit.found") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "enabled", "bloom.mayexist", "true", "bloom.mayexist.result", "exists", "bloom.mayexist.cached", "false") .register(meterRegistry); this.readValueFoundWithBloomCacheBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -160,7 +160,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "hit.cachedvalue") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "enabled", "bloom.mayexist", "true", "bloom.mayexist.result", "exists", "bloom.mayexist.cached", "true") .register(meterRegistry); this.readValueFoundWithBloomSimpleBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -168,7 +168,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "hit") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "enabled", "bloom.mayexist", "true", "bloom.mayexist.result", "exists", "bloom.mayexist.cached", "false") .register(meterRegistry); this.readValueFoundWithoutBloomBufferSize = DistributionSummary .builder("buffer.size.distribution") @@ -176,7 +176,7 @@ public sealed abstract class AbstractRocksDBColumn implements .baseUnit("bytes") .scale(1) .publishPercentileHistogram() - .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "no") + .tags("db.name", databaseName, "db.column", columnName, "buffer.type", "val.read", "found", "true", "bloom", "disabled") .register(meterRegistry); this.writeValueBufferSize = DistributionSummary .builder("buffer.size.distribution") diff --git a/src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java b/src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java index b215aaf..5a75a7f 100644 --- a/src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java +++ b/src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java @@ -420,6 +420,9 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase { try { return database.getAggregatedLongProperty(propertyName); } catch (RocksDBException e) { + if ("NotFound".equals(e.getMessage())) { + return 0d; + } throw new RuntimeException(e); } }