andreacavalli/CavalliumDBEngine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add debug option to disable snapshots, optimize iterate bounds

Browse Source
This commit is contained in:
Andrea Cavalli 2023-05-23 00:19:47 +02:00
parent dc03d25fdc
commit 7e7e1c410b
3 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/main/java/it/cavallium/dbengine/database/disk/AbstractRocksDBColumn.java
View File

@ -231,18 +231,6 @@ public sealed abstract class AbstractRocksDBColumn<T extends RocksDB> implements
this.keyMayExistGetter = new DBColumnKeyMayExistGetter();
}
/**
* This method should not modify or move the writerIndex/readerIndex of the key
*/
static void setIterateBound(LLReadOptions readOpts, IterateBound boundType, Buf key) {
byte[] slice = key != null ? requireNonNull(LLUtils.asArray(key)) : null;
if (boundType == IterateBound.LOWER) {
readOpts.setIterateLowerBound(slice);
} else {
readOpts.setIterateUpperBound(slice);
}
}
/**
* This method should not modify or move the writerIndex/readerIndex of the buffers inside the range
*/
@ -557,8 +545,10 @@ public sealed abstract class AbstractRocksDBColumn<T extends RocksDB> implements
try {
ensureOpen();
ensureOwned(readOptions);
setIterateBound(readOptions, IterateBound.LOWER, min);
setIterateBound(readOptions, IterateBound.UPPER, max);
assert !readOptions.hasIterateLowerBound() : "ReadOptions has already a range!";
assert !readOptions.hasIterateUpperBound() : "ReadOptions has already a range!";
readOptions.setIterateLowerBound(min != null ? requireNonNull(LLUtils.asArray(min)) : null);
readOptions.setIterateUpperBound(max != null ? requireNonNull(LLUtils.asArray(max)) : null);
return readOptions.newIterator(db, cfh, iteratorMetrics);
} finally {
closeLock.unlockRead(closeReadLock);

1
src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java
View File

@ -1462,6 +1462,7 @@ public class LLLocalKeyValueDatabase extends Backuppable implements LLKeyValueDa
@Override
public LLSnapshot takeSnapshot() {
if (!ALLOW_SNAPSHOTS) throw new UnsupportedOperationException("Snapshots are disabled!");
var closeReadLock = closeLock.readLock();
try {
ensureOpen();

8
src/main/java/it/cavallium/dbengine/database/disk/rocksdb/LLReadOptions.java
View File

@ -140,4 +140,12 @@ public final class LLReadOptions extends SimpleResource {
public Snapshot snapshot() {
return val.snapshot();
}
public boolean hasIterateLowerBound() {
return val.iterateLowerBound() != null;
}
public boolean hasIterateUpperBound() {
return val.iterateUpperBound() != null;
}
}