andreacavalli/CavalliumDBEngine
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Code cleanup, bigger compaction trigger l0

Browse Source
This commit is contained in:
Andrea Cavalli 2022-05-01 15:42:51 +02:00
parent c72e4d5a83
commit d9c2e8a5f9
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/it/cavallium/dbengine/database/disk/LLLocalKeyValueDatabase.java
View File

@ -107,8 +107,6 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase {
} }
protected static final Logger logger = LogManager.getLogger(LLLocalKeyValueDatabase.class); protected static final Logger logger = LogManager.getLogger(LLLocalKeyValueDatabase.class);
private static final ColumnFamilyDescriptor DEFAULT_COLUMN_FAMILY
= new ColumnFamilyDescriptor(RocksDB.DEFAULT_COLUMN_FAMILY);
private final BufferAllocator allocator; private final BufferAllocator allocator;
private final MeterRegistry meterRegistry; private final MeterRegistry meterRegistry;
@ -122,7 +120,6 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase {
private final Path dbPath; private final Path dbPath;
private final String name; private final String name;
private final DatabaseOptions databaseOptions; private final DatabaseOptions databaseOptions;
private final boolean nettyDirect;
private final boolean enableColumnsBug; private final boolean enableColumnsBug;
private RocksDB db; private RocksDB db;
@ -147,7 +144,7 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase {
DatabaseOptions databaseOptions) throws IOException { DatabaseOptions databaseOptions) throws IOException {
this.name = name; this.name = name;
this.allocator = allocator; this.allocator = allocator;
this.nettyDirect = databaseOptions.allowNettyDirect() && allocator.getAllocationType() == OFF_HEAP; boolean nettyDirect = databaseOptions.allowNettyDirect() && allocator.getAllocationType() == OFF_HEAP;
this.meterRegistry = meterRegistry; this.meterRegistry = meterRegistry;
this.snapshotTime = Timer this.snapshotTime = Timer
@ -216,17 +213,13 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase {
if (isDisableAutoCompactions()) { if (isDisableAutoCompactions()) {
columnFamilyOptions.setDisableAutoCompactions(true); columnFamilyOptions.setDisableAutoCompactions(true);
} }
boolean dynamicLevelBytes;
// This option is not supported with multiple db paths // This option is not supported with multiple db paths
if (databaseOptions.volumes().size() <= 1) { // https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html
// https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html // https://github.com/facebook/rocksdb/wiki/Tuning-RocksDB-on-Spinning-Disks
// https://github.com/facebook/rocksdb/wiki/Tuning-RocksDB-on-Spinning-Disks boolean dynamicLevelBytes = databaseOptions.volumes().size() <= 1;
dynamicLevelBytes = true;
} else {
dynamicLevelBytes = false;
}
if (dynamicLevelBytes) { if (dynamicLevelBytes) {
columnFamilyOptions.setLevelCompactionDynamicLevelBytes(dynamicLevelBytes); columnFamilyOptions.setLevelCompactionDynamicLevelBytes(true);
} else { } else {
// https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html // https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html
// https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.html // https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.html
@ -237,9 +230,9 @@ public class LLLocalKeyValueDatabase implements LLKeyValueDatabase {
if (isDisableAutoCompactions()) { if (isDisableAutoCompactions()) {
columnFamilyOptions.setLevel0FileNumCompactionTrigger(-1); columnFamilyOptions.setLevel0FileNumCompactionTrigger(-1);
} else { } else {
// https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html // ArangoDB uses a value of 2: https://www.arangodb.com/docs/stable/programs-arangod-rocksdb.html
// Higher values speed up writes, but slow down reads // Higher values speed up writes, but slow down reads
columnFamilyOptions.setLevel0FileNumCompactionTrigger(2); columnFamilyOptions.setLevel0FileNumCompactionTrigger(4);
} }
if (isDisableSlowdown()) { if (isDisableSlowdown()) {
columnFamilyOptions.setLevel0SlowdownWritesTrigger(-1); columnFamilyOptions.setLevel0SlowdownWritesTrigger(-1);