From 013b6e68ec416124193dbc1306b353605b0bdacd Mon Sep 17 00:00:00 2001 From: LoveSy Date: Tue, 13 Apr 2021 06:15:42 +0800 Subject: [PATCH] Fix perfect forwarding --- native/jni/core/module.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/native/jni/core/module.cpp b/native/jni/core/module.cpp index 117aba458..fcc3e6e1c 100644 --- a/native/jni/core/module.cpp +++ b/native/jni/core/module.cpp @@ -156,14 +156,14 @@ public: // Return inserted node or null if rejected template - T *emplace(string_view name, Args &...args) { + T *emplace(string_view name, Args &&...args) { return iter_to_node(insert(children.find(name), type_id(), [&](auto _) { return new T(std::forward(args)...); })); } // Return inserted node, existing node with same rank, or null template - T *emplace_or_get(string_view name, Args &...args) { + T *emplace_or_get(string_view name, Args &&...args) { return iter_to_node(insert(children.find(name), type_id(), [&](auto _) { return new T(std::forward(args)...); }, true)); } @@ -205,7 +205,7 @@ protected: map_iter insert(map_iter it, uint8_t type, Func fn, bool allow_same = false); template - map_iter upgrade(map_iter it, Args &...args) { + map_iter upgrade(map_iter it, Args &&...args) { return insert(it, type_id(), [&](node_entry *&ex) -> node_entry * { if (!ex) return nullptr;