From 0a37d1c15cf9aa1615308debe4ddc0b3dfe4d611 Mon Sep 17 00:00:00 2001 From: topjohnwu Date: Tue, 8 Nov 2016 00:04:22 +0800 Subject: [PATCH] Merge UI code into async --- .../java/com/topjohnwu/magisk/LogFragment.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/com/topjohnwu/magisk/LogFragment.java b/app/src/main/java/com/topjohnwu/magisk/LogFragment.java index a35461d50..295c53ab7 100644 --- a/app/src/main/java/com/topjohnwu/magisk/LogFragment.java +++ b/app/src/main/java/com/topjohnwu/magisk/LogFragment.java @@ -57,7 +57,7 @@ public class LogFragment extends Fragment { txtLog.setTextIsSelectable(true); - reloadErrorLog(); + new LogManager().read(); return view; } @@ -66,7 +66,7 @@ public class LogFragment extends Fragment { public void onResume() { super.onResume(); setHasOptionsMenu(true); - reloadErrorLog(); + new LogManager().read(); } @Override @@ -79,7 +79,7 @@ public class LogFragment extends Fragment { mClickedMenuItem = item; switch (item.getItemId()) { case R.id.menu_refresh: - reloadErrorLog(); + new LogManager().read(); return true; case R.id.menu_send: new LogManager().send(); @@ -95,12 +95,6 @@ public class LogFragment extends Fragment { } } - private void reloadErrorLog() { - new LogManager().read(); - svLog.post(() -> svLog.scrollTo(0, txtLog.getHeight())); - hsvLog.post(() -> hsvLog.scrollTo(0, 0)); - } - @Override public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) { super.onRequestPermissionsResult(requestCode, permissions, grantResults); @@ -197,6 +191,8 @@ public class LogFragment extends Fragment { txtLog.setText(R.string.log_is_empty); else txtLog.setText(llog); + svLog.post(() -> svLog.scrollTo(0, txtLog.getHeight())); + hsvLog.post(() -> hsvLog.scrollTo(0, 0)); break; case 2: bool = (boolean) o;