From b067105660ef3db4a35fffdf5ac06ecbbb6cecbe Mon Sep 17 00:00:00 2001
From: topjohnwu <topjohnwu@gmail.com>
Date: Thu, 26 Jan 2017 03:45:05 +0800
Subject: [PATCH] Fix bug where no info is available

---
 .../topjohnwu/magisk/adapters/ModulesAdapter.java    | 12 ++++++++----
 app/src/main/res/layout/list_item_module.xml         |  3 ---
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/com/topjohnwu/magisk/adapters/ModulesAdapter.java b/app/src/main/java/com/topjohnwu/magisk/adapters/ModulesAdapter.java
index 65504c34c..6b802b970 100644
--- a/app/src/main/java/com/topjohnwu/magisk/adapters/ModulesAdapter.java
+++ b/app/src/main/java/com/topjohnwu/magisk/adapters/ModulesAdapter.java
@@ -40,11 +40,15 @@ public class ModulesAdapter extends RecyclerView.Adapter<ModulesAdapter.ViewHold
         Context context = holder.itemView.getContext();
         final Module module = mList.get(position);
 
-        holder.title.setText(module.getName());
-        holder.versionName.setText(module.getVersion());
+        String version = module.getVersion();
         String author = module.getAuthor();
-        holder.author.setText(TextUtils.isEmpty(author) ? null : context.getString(R.string.author, author));
-        holder.description.setText(module.getDescription());
+        String description = module.getDescription();
+        String noInfo = context.getString(R.string.no_info_provided);
+
+        holder.title.setText(module.getName());
+        holder.versionName.setText( TextUtils.isEmpty(version) ? noInfo : version);
+        holder.author.setText( TextUtils.isEmpty(author) ? noInfo : context.getString(R.string.author, author));
+        holder.description.setText( TextUtils.isEmpty(description) ? noInfo : description);
 
         holder.checkBox.setOnCheckedChangeListener(null);
         holder.checkBox.setChecked(module.isEnabled());
diff --git a/app/src/main/res/layout/list_item_module.xml b/app/src/main/res/layout/list_item_module.xml
index 6c0b70774..afd6d6831 100644
--- a/app/src/main/res/layout/list_item_module.xml
+++ b/app/src/main/res/layout/list_item_module.xml
@@ -40,7 +40,6 @@
             android:layout_alignParentStart="true"
             android:layout_below="@id/title"
             android:textAppearance="?android:attr/textAppearanceSmall"
-            android:text="@string/no_info_provided"
             android:textColor="@android:color/tertiary_text_dark"
             android:textIsSelectable="false"
             android:textStyle="bold|italic"/>
@@ -51,7 +50,6 @@
             android:layout_height="wrap_content"
             android:layout_alignParentStart="true"
             android:layout_below="@id/version_name"
-            android:text="@string/no_info_provided"
             android:textAppearance="?android:attr/textAppearanceSmall"
             android:textColor="@android:color/tertiary_text_dark"
             android:textIsSelectable="false"
@@ -63,7 +61,6 @@
             android:layout_height="wrap_content"
             android:layout_below="@id/author"
             android:layout_gravity="center_vertical"
-            android:text="@string/no_info_provided"
             android:textAppearance="?android:attr/textAppearanceSmall"
             android:textIsSelectable="false"/>