andreacavalli
/
Magisk
forked from MarcoBuster/Magisk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,096 Commits 1 Branch 0 Tags 61 MiB
Commit Graph

2762 Commits

Author SHA1 Message Date
Rikka 95a5b57265
Remove "Flashing" overlay 
Fix #3579, fix #3250
 2021-01-15 21:28:59 -08:00
vvb2060 20be99ec8a Restore mistakenly deleted codes 2021-01-15 19:59:55 -08:00
topjohnwu 79dfdb29e7 Minor tweaks for patching tar files 2021-01-11 19:47:36 -08:00
Hen Ry fe8997efae Fix 2021-01-10 20:17:20 -08:00
Arbri çoçka 23455c722c fix in Values-sq 2021-01-10 20:16:57 -08:00
topjohnwu 5ce29c30d2 Fix sepolicy copying 2021-01-10 20:16:02 -08:00
Björn Engel 872ab2e99b Change translation for next 
Nächste sounds a little bit strange.
 2020-12-30 16:41:22 -08:00
kubalav 90b8813bb7 Fixed typo 2020-12-30 16:41:01 -08:00
Arbri çoçka 88d0f63294 Fix text in strings_sq 2020-12-30 16:40:47 -08:00
topjohnwu 79fa0d3a90 Hide selection improvements 2020-12-30 16:40:22 -08:00
topjohnwu 8e61080a4a Preparation for hiding isolated processes 2020-12-30 15:55:53 -08:00
topjohnwu b6144ae582 Add v21.2 release notes 2020-12-28 15:35:09 -08:00
Arbri çoçka afe17c73b4 Update strings.xml 
Fix same text in Values-sq
 2020-12-28 15:29:27 -08:00
dark-basic 107a2a6682
Update String-es 2020-12-27 22:08:34 -08:00
Arbri çoçka 56b4ab6672 Fix any text in strings sq 2020-12-27 22:07:44 -08:00
topjohnwu f983bfc883 Embed keys into dex files 2020-12-26 21:33:30 -08:00
topjohnwu 45cdb3fdb0 Update dependencies 2020-12-26 17:05:12 -08:00
topjohnwu 9a707236b8 Move signing code into main app sources 2020-12-26 17:03:10 -08:00
topjohnwu 8a2a6d9232 Make versionCode unconfigurable 2020-12-25 05:34:15 -08:00
topjohnwu 12aa6d86e4 Make config.prop optional 2020-12-24 04:46:31 -08:00
topjohnwu 7d08969d28 Fix strings 2020-12-23 01:33:46 -08:00
Fs00 dda4aa8488 Translate missing Italian strings 2020-12-22 23:33:20 -08:00
Arbri çoçka dc0882e043 fixing some errors in sq strings 2020-12-22 23:31:40 -08:00
amninder singh c811f015ef Added Punjabi Translation 
- Written in Gurmukhi Script containing different foreign punctuations both inscript and Phonetic
 2020-12-22 23:31:12 -08:00
topjohnwu d089698475 Don't use root for logging getprop 
Might contain sensitive info that shouldn't be shared
 2020-12-19 23:09:36 -08:00
vvb2060 8ed2dd6687 Skip query for log files and patched boot file 2020-12-19 22:26:10 -08:00
vvb2060 50305ca1fe Support save manager log 2020-12-19 22:25:44 -08:00
vvb2060 3e91567636 Add a suffix to magisk_patched.img 
prevent it from being used as input file
 2020-12-19 21:53:16 -08:00
vvb2060 6ce9225f52 Check block dev ro status 
magisk is shared object, use static busybox instead
 2020-12-19 14:12:12 -08:00
vvb2060 984f32f994 Move copy_sepolicy_rules to manager 
We don’t need it when patch boot
 2020-12-19 13:58:53 -08:00
topjohnwu 1232113772 Update preference migration implementation 
Only try to read preference through content provider when the app
is fresh install and a previous package ID is set. Also catch all
Exceptions to prevent crashing the app.

This prevents malicious settings injection and crashes when multiple
manager is installed.

Fix #3542
 2020-12-09 02:07:58 -08:00
vvb2060 039d4936cb Disable superuser fragment properly 2020-12-09 01:16:30 -08:00
topjohnwu 784dd80965 Update MediaStoreUtils 2020-12-09 01:15:56 -08:00
vvb2060 1ffe9bd83b Fix update channel without description on release build 2020-12-09 00:40:33 -08:00
vvb2060 ec1af9dc1e Delete useless arrays 2020-12-09 00:17:58 -08:00
vvb2060 ff4cea229a Check environment on emulator 
We need to test modules on emulator.
 2020-12-09 00:16:27 -08:00
vvb2060 3f81f9371f Disable installation while downloading metadata 2020-12-09 00:16:13 -08:00
vvb2060 60e89a7d22 Ignore manager not installed state 2020-12-09 00:15:58 -08:00
vvb2060 c50daa5c9e Allow restore boot when no network 2020-12-09 00:15:41 -08:00
topjohnwu 58d00ab863 Remove some warnings 2020-12-07 00:06:02 -08:00
topjohnwu ce916459c5 Fix strings 2020-12-07 00:04:41 -08:00
Antikruk 4094d560ab
Belarusian update 2020-12-06 23:50:33 -08:00
RikkaW 4dbf7eb04b Fix spacing in module filter list 2020-12-06 23:49:23 -08:00
RikkaW a39577c44d Fix extra spacing in module list 2020-12-06 23:49:23 -08:00
Hafitz Setya a687d1347b Tidying up IN 2020-12-06 23:48:01 -08:00
Arbri çoçka 6d9db20614 Create strings.xml 2020-12-06 23:46:18 -08:00
topjohnwu a848f10bba Update Kotlin 2020-11-23 12:35:24 -08:00
topjohnwu 1385d2a4f4 Fix strings 2020-11-19 23:34:02 -08:00
RikkaW 3b5c9abf7a Remove filterTouchesWhenObscured in Magisk dialog 
Fix #3363
 2020-11-19 23:32:23 -08:00
tzagim e0fa032bd3
Update HE strings and fix typos 2020-11-19 23:29:47 -08:00
omerakgoz34 7b69650fcd
app: Update Turkish translations 2020-11-19 23:27:54 -08:00
kubalav 08a8df489f Slovak language formating 2020-11-19 23:27:07 -08:00
cristisilaghi 9f35a8a520 Update Romanian 2020-11-19 23:26:38 -08:00
RikkaW 0df891b336 Handle window insets with a new way 
For example, switching pages in home should only have scale and alpha animations, but a "translate y" animation shows. This is because Data Binding is triggered later (like "in the next frame"), causing the animation runs before view attribute changes.

This commit introduces WindowInsetsHelper class and use it to handle all window insets. With the help of LayoutInflaterFactory from the previous commit, we can control insets behavior by adding our attributes to the XML and anything is done by WindowInsetsHelper class.

As changes are highly coupling, this commit also contains new ItemDecoration for lists, replacing the random combination of padding and empty drawable. And "fixEdgeEffect" extension for RecyclerView, making edge effects respect padding.
 2020-11-19 23:24:39 -08:00
RikkaW 385853a290 Introduce LayoutInflaterFactory 
This add the ability touch layout XML instantiates process. And most importantly, we can access AttributeSet, making custom view attribute possible.

Some other changes requires this.
 2020-11-19 23:24:39 -08:00
RikkaW fa3ef8a1c1 Significantly simplify MagiskDialog layout 
The goal of original implementation, wrap view again and again, seems to be use the shadow and customizable round corners from MaterialCardView. But this can be done with use MaterialShapeDrawable which used in MaterialCardView directly. This will significantly simplify the layout and MagiskDialog class.
 2020-11-19 23:21:36 -08:00
RikkaW c93ada03c7 Implement Edge-to-edge with newer APIs 
The implementation adds a "Base" family styles, making creating themes across multiple API versions more clearer and easier.
 2020-11-19 23:21:36 -08:00
topjohnwu 2d5cf8a6fe Push release notes 2020-11-13 04:32:20 -08:00
topjohnwu 290959f74c Fix strings resources 2020-11-13 04:22:06 -08:00
Ilya Kushnir 4d9f58ee72
Update RU strings & tidying up EN 2020-11-13 03:03:35 -08:00
topjohnwu 9241246de6 Only use MediaStore APIs on Android 11+ 
Fix #3428
 2020-11-13 02:53:30 -08:00
Heimen Stoffels 58a5d52b78
Updated Dutch translation 2020-11-13 02:34:49 -08:00
Rom 2906178ac3
Update French translation 2020-11-13 02:34:21 -08:00
topjohnwu 50be50cf6a Update dependencies 2020-11-13 00:58:41 -08:00
topjohnwu 2739d3cb67 Update PayPal link 2020-11-07 15:10:10 -08:00
vvb2060 e9759a5868 Update HideViewModel 2020-11-07 14:47:44 -08:00
AdiityaAndre e7ab802498 Update Indonesian translation 2020-11-07 14:43:46 -08:00
kubalav 42672c2e27 Update Slovak translation 2020-11-07 14:43:21 -08:00
孟武.尼德霍格.龍 e65d61d313 更新繁體中文字串 
更新繁體中文字串
 2020-11-07 14:42:48 -08:00
Taras 076da5c7c4
Update Ukrainian translation 2020-11-07 14:42:11 -08:00
vvb2060 9deaf2507c Update zh-rCN translation 2020-11-07 14:41:32 -08:00
kam821 5c114c67de Update Polish translation 
- Add missing strings
- Small corrections.
- Changed "Magisk Manager" translation to form which better reflects the original meaning in Polish.
 2020-11-07 14:40:56 -08:00
programminghoch10 d904cb0441 Updated german translations 2020-11-07 14:40:02 -08:00
topjohnwu 16e4c67992 Significantly broaden sepolicy.rule compatibility 
Previously, Magisk uses persist or cache for storing modules' custom
sepolicy rules. In this commit, we significantly broaden its
compatibility and also prevent mounting errors.

The persist partition is non-standard and also critical for Snapdragon
devices, so we prefer not to use it by default.

We will go through the following logic to find the best suitable
non-volatile, writable location to store and load sepolicy.rule files:

Unencrypted data -> FBE data unencrypted dir -> cache -> metadata -> persist

This should cover almost all possible cases: very old devices have
cache partitions; newer devices will use FBE; latest devices will use
metadata FBE (which guarantees a metadata parition); and finally,
all Snapdragon devices have the persist partition (as a last resort).

Fix #3179
 2020-11-02 23:20:38 -08:00
topjohnwu 0d11f73a1d Handle unexpected exceptions 
Fix #3276
 2020-10-22 03:09:05 -07:00
vvb2060 533cb8eb58 Tapjacking protection 2020-10-22 02:40:47 -07:00
loading 8ac1181e9a
Update Hindi translations 2020-10-21 00:43:15 -07:00
Ilya Kushnir 5ca1892eb0 Update RU strings 2020-10-21 00:42:09 -07:00
kubalav 82fff615d6 Update Slovak translation 2020-10-21 00:40:36 -07:00
Rom 24a8f0808d
Update French translation 2020-10-21 00:40:08 -07:00
vvb2060 4a7c3c06bc Disable hide/restore when no remote info 2020-10-20 23:56:44 -07:00
vvb2060 da93bbc1fe Fix network 2020-10-20 23:56:21 -07:00
topjohnwu fa2dbe981e Handle retrofit errors 2020-10-20 03:03:40 -07:00
topjohnwu 7b26e8b818 Update dependencies 2020-10-17 06:46:36 -07:00
topjohnwu a079966f97 Migrate to AGP 4.1.0 2020-10-17 06:32:49 -07:00
vvb2060 468796c23d Add option to show OS apps 2020-10-17 05:57:43 -07:00
vvb2060 5833aadef5 Silence kotlin warnings 2020-10-17 05:57:35 -07:00
vvb2060 eb261c8026 Fix antlr warning 
https://issuetracker.google.com/issues/150106190
 2020-10-17 05:57:20 -07:00
vvb2060 a4c48847d1 Cancel vibration to sync with notification channel 2020-10-17 05:56:07 -07:00
vvb2060 43288be091 Prevent dot in the first position 2020-10-17 05:55:58 -07:00
vvb2060 1ad7a6fe93 Update activity display when download fails 2020-10-17 05:54:34 -07:00
topjohnwu 4e0a3f5e72 Fix compile errors 2020-10-17 04:28:20 -07:00
Davy Defaud d7c33f647d Fix a typo and use the proper Unicode characters 
- fix a French typo: raccourcis → raccourci
- French orthotypography: use a thin space before a question mark, and a true (non breaking) hyphen instead of a dash.
 2020-10-17 04:18:00 -07:00
topjohnwu 9087207dc0 Minor changes 2020-10-17 04:14:12 -07:00
vvb2060 2760f37e6b Add userspace reboot 2020-10-17 03:54:51 -07:00
Miguel Cruces 3fa3426032 Spanish translations update 2020-10-17 03:54:17 -07:00
topjohnwu 2e4dc91b96 Better stub hiding experience 2020-10-17 03:40:43 -07:00
topjohnwu 735b65c50c Update DoH implementation 2020-10-11 15:19:19 -07:00
topjohnwu efb1eab327 Silence some warnings 2020-10-11 05:47:47 -07:00
topjohnwu 49d4785da0 Fix strings 2020-10-11 05:26:50 -07:00
RoySchutte 28e65ce383 Update strings.xml 
I don't know who else is translating Magisk Manager, but I noticed some weird translations. Fixed a couple of them in this update.
 2020-10-11 05:24:16 -07:00
Antikruk c3b6a48373
belarusian 2020-10-11 05:23:51 -07:00
omerakgoz34 a42ebd429b
Update Turkish(TR) Translation 2020-10-11 05:22:01 -07:00
MASVA 8f89010752
Update croatian language 2020-10-11 05:20:34 -07:00
topjohnwu eb04ca4c4a Make provider boot aware 
Close #3322
 2020-10-11 05:19:05 -07:00
topjohnwu 6092d7ca88 Minor cleanups 2020-10-11 05:10:02 -07:00
topjohnwu 0a14f43f9c Refactor class names 2020-10-10 22:40:57 -07:00
topjohnwu 311c1f0dfd Switch to new repo format 2020-10-10 14:31:30 -07:00
topjohnwu fbcbb20178 Update app changelog 2020-10-08 01:06:37 -07:00
topjohnwu 0914700fc6 Fix string resources 2020-10-08 00:50:21 -07:00
vvb2060 eeced2fb5b Only care about the main process when not expanded 2020-10-08 00:30:34 -07:00
topjohnwu 6509e3d4f5 Use ProgressDialog when restoring images 
Close #3287
 2020-10-08 00:27:16 -07:00
AdiityaAndre 317052604b Translation: Update and improve Indonesian strings 
* Added new strings
* Decapitalized wording
 2020-10-08 00:16:29 -07:00
Wagg13 5538f7168c Update PT-BR translation 2020-10-08 00:15:56 -07:00
vvb2060 dcb9e4cd93 Update zh-rCN translation 2020-10-08 00:15:29 -07:00
topjohnwu d9382f59bf Fix logical error 2020-10-08 00:14:51 -07:00
topjohnwu 403a0c770a Fix typo 2020-10-07 20:15:23 -07:00
topjohnwu f0f1cdc501 Disable LoggingInterceptor 2020-10-07 04:01:50 -07:00
topjohnwu 4e272b70ef Download GitHub files through CDN 2020-10-07 04:01:03 -07:00
topjohnwu 8dc62a0232 Update docs and README 2020-10-06 05:10:19 -07:00
topjohnwu 9225b47568 Tidy up network services 
Add jsdelivr CDN for several files
 2020-10-06 04:58:46 -07:00
topjohnwu d462873e74 Prevent UI loop on low memory device 
Fix #3215, close #3216
 2020-10-06 02:21:57 -07:00
topjohnwu fc19b50290 Cleanup ActivityResult callbacks 2020-10-06 02:04:19 -07:00
JoanVC100 333fe6da0e
Update catalan 2020-10-06 00:45:17 -07:00
Madis Otenurm 75fcda9f81
Estonian update 2020-10-06 00:43:31 -07:00
kam821 44ba2a9903 Update Polish translation 
Added missing strings.
 2020-10-06 00:42:48 -07:00
Fs00 2fceb1ad96 Improve accuracy and correctness of Italian translation 2020-10-06 00:41:59 -07:00
vvb2060 bacb5fa462 Truncate existing file when openOutputStream 2020-10-06 00:41:21 -07:00
topjohnwu 67f8dc494e Properly patch vbmeta.img 
Close #3241
 2020-10-06 00:40:57 -07:00
topjohnwu 64effe9385 Add v21.0 release notes 2020-10-03 03:30:22 -07:00
topjohnwu 716f06846b Use GitHub pages URLs for public channel JSONs 2020-10-03 02:51:51 -07:00
topjohnwu 241f2656fa Prepare for public release 2020-10-03 02:42:02 -07:00
Jarl-Penguin e973d49517 Fix Korean translation typo 2020-10-03 02:41:47 -07:00
Taewan Park c3bf9a095b Update korean translation 
Update Magisk Manager app translation
 - Korean translation updated
(Translation based on "en" strings.xml)
 2020-10-03 02:03:24 -07:00
cristisilaghi abfc28db32 Update Romanian 2020-10-03 02:02:58 -07:00
Vladimír Kubala d6dbab53cd Update Slovak translation 2020-09-28 04:47:23 -07:00
topjohnwu 46de1ed968 Better handling of data encryption 2020-09-28 04:45:56 -07:00
topjohnwu 9bebe07d5a Better network connection observing 2020-09-27 21:21:38 -07:00
topjohnwu ee4db43136 Update proguard rules 
Fix #3190
 2020-09-27 04:49:49 -07:00
topjohnwu efac220998 Fix strings 2020-09-27 04:40:07 -07:00
Ludovico Latini 31026b43f4 Update strings.xml 2020-09-27 04:35:05 -07:00
Rikka bc3fbe09f5
Update several colors in themes 
* Change color for Mew theme

The original color looks like disabled color.

* Change color for Zapdos theme

The original colors have extremely poor readability. For yellow colors, it is difficult to balance readability and beauty, maybe remove it is a better choice?

* Change colors

- Use original colors for dark themes
- Adjust light colors

* Change colorError for dark themes
 2020-09-27 04:34:38 -07:00
vvb2060 7ac55068db Catch ActivityNotFoundException 2020-09-27 04:33:46 -07:00
topjohnwu 2f232fc670 Support modern Samsung AP.tar patching 2020-09-26 13:32:51 -07:00
topjohnwu 41f5c8d96c Magisk Manager always have to be upgraded first 2020-09-24 03:16:43 -07:00
Viktor De Pasquale 63a9a7d643 Fixed bottom bar not hiding on device without root 2020-09-24 00:51:08 -07:00
vvb2060 a63d6c03fd Update dependencies 2020-09-23 20:57:19 -07:00
vvb2060 fd552e68a9 Don't hide app with uid < 10000 2020-09-23 20:57:19 -07:00
vvb2060 de4e26b488 Allow download modules when Magisk is not installed 2020-09-23 20:57:19 -07:00
vvb2060 fa3865e962 Check command result 2020-09-23 20:57:19 -07:00
vvb2060 a6950b8aca Add failed state 2020-09-23 20:57:19 -07:00
vvb2060 8df96ff664 Fix string 2020-09-23 20:57:19 -07:00
Ilya Kushnir 8b29267ad6 Update RU strings 2020-09-23 05:08:05 -07:00
topjohnwu 0ef92a4866 Hide OTA option on Pixel devices 2020-09-23 04:49:38 -07:00
topjohnwu 85bef8fa96 Fix install fragment changelog 2020-09-23 04:49:38 -07:00
topjohnwu ca9f9fee9a Update device state detection 2020-09-23 04:49:38 -07:00
Viktor De Pasquale b59e05c63e Added a check against view being initialized in its behavior 
The view will be simply hidden if not
 2020-09-22 20:40:28 -07:00
Viktor De Pasquale 3c0630bfc0 Added forced checks on view being attached to window before performing hiding on it 2020-09-22 20:40:28 -07:00
Viktor De Pasquale bf84dd6518 Added hiding bottom bar when magisk is not active 2020-09-22 20:40:28 -07:00
nikk f575155a41
Fix focus on main elements in Modern UI 
Co-authored-by: John Wu <topjohnwu@gmail.com>
 2020-09-21 03:27:29 -07:00
AdiityaAndre bd240ba48c Update Indonesian translations 2020-09-21 03:18:29 -07:00
孟武.尼德霍格.龍 106a2bb7df 更新繁體字串 
新增部分字串
修正部分字串標點符號
 2020-09-21 03:17:52 -07:00
Rom 82bbbe05b2 Update French translation 
According to 765b51285a
 2020-09-21 03:17:08 -07:00
Vladimír Kubala 9956dc0995 Update Slovak translation 2020-09-21 03:16:44 -07:00
RikkaW fc76673802 Black splash screen background for dark theme 2020-09-21 03:15:59 -07:00
topjohnwu 9908dfd79a Hide MagiskHide entry when disabled 2020-09-20 14:30:57 -07:00
topjohnwu 2dbaf9595c Remove strokes from most cards 2020-09-17 02:27:43 -07:00
topjohnwu 9a16ab1bd7 Always show install button 
Fix #3172
 2020-09-16 23:55:50 -07:00
topjohnwu 9e5cb6cb91 Proper way to setup attr colors 2020-09-16 22:16:28 -07:00
vvb2060 8c19654d20 Update zh-rCN translation 2020-09-13 15:13:33 -07:00
RikkaW d5a7a75d9d Set android:windowContentOverlay to null so that there will be not "shadow" on pre-21 2020-09-13 12:40:40 -07:00
topjohnwu 851b676077 Remove custom fonts 2020-09-13 06:51:17 -07:00
topjohnwu 765b51285a Add settings to disable DoH 
Close #3130
 2020-09-13 04:34:00 -07:00
topjohnwu 8a338de696 Hide MagiskHide pre Kitkat 2020-09-13 03:55:12 -07:00
topjohnwu 8a61ae621d Disable DoH upon failure 2020-09-13 03:46:06 -07:00
topjohnwu 60e1e07e87 Proper SafetyNet UI databinding 2020-09-13 00:23:23 -07:00
topjohnwu e51a3dacb9 Support theme switching pre SDK 21 2020-09-12 18:42:05 -07:00
topjohnwu 9a8a27dbb9 Do not access color attributes in background 
Workaround with ImageView tints
 2020-09-12 03:17:21 -07:00
topjohnwu 2eb001876a Code cleanup 2020-09-11 03:17:43 -07:00
topjohnwu b510dc51ac Fix su request auto response 2020-09-11 03:09:01 -07:00
topjohnwu d7f7508fa2 Move setContentView out of onCreate 2020-09-11 02:31:41 -07:00
Rom e66b0bf3b2 Little French translation update 2020-09-10 01:13:20 -07:00
AioiLight 0555b73a19 Update strings.xml 2020-09-10 01:12:52 -07:00
RoySchutte 877a297de4 Update strings.xml 
Fixed 1 grammatical error, and changed a string to the proper translation.
 2020-09-10 01:12:17 -07:00
vvb2060 49559ec0ec try root if adb install fail 2020-09-10 01:02:50 -07:00
topjohnwu 434efec860 Use FIFO for su request communication 
Fix #3159
 2020-09-10 00:38:29 -07:00
topjohnwu 5022f00a55 Cleanup homescreen 2020-09-08 23:40:44 -07:00
topjohnwu 8aac373ca3 Fix network status detection 2020-09-08 21:55:43 -07:00
topjohnwu 013a2e1336 Minor code changes 2020-08-31 04:02:47 -07:00
topjohnwu fbaf2bded6 Patch AndroidManifest.xml properly 
Parse and rebuild the string pool of the AXML format for patching
string in AndroidManifest.xml
 2020-08-31 03:39:20 -07:00
o4x 38a34a7eeb Add persian language 2020-08-30 12:57:03 -07:00
vvb2060 70174e093b
Optimize network status display 2020-08-30 12:56:36 -07:00
vvb2060 0333e82e86 Fix string 2020-08-30 12:46:22 -07:00
peter9811 36a8839cf8 Update strings.xml 2020-08-30 12:46:03 -07:00
peter9811 d0ed6e7fe3 Update spanish 2020-08-30 12:46:03 -07:00
孟武.尼德霍格.龍 72dfbf5e44 更新繁體中文字串 
更新繁體字串到適用v295的版本及以後
 2020-08-30 12:45:19 -07:00
topjohnwu 114a3c037f Some minor UI tweaks 2020-08-29 22:55:18 -07:00
topjohnwu 782adc9a9f Cleanup some styles 2020-08-29 21:42:05 -07:00
vvb2060 e0642b018d Update zh-rCN translation 2020-08-28 04:54:32 -07:00
topjohnwu 6bd4006652 Rename method 2020-08-28 04:50:46 -07:00