Commit Graph

13 Commits

Author SHA1 Message Date
Chris Vest
53a8d71c64 Fix numerous review comments
- Mostly javadocs have been fixed or added.
- A couple of small code changes in ByteBufAdaptor to better cope with unlikely exceptions.
2021-05-28 16:23:35 +02:00
Chris Vest
78b30a1b37 Convert ByteBufAdaptorTests to JUnit 5, and fix the MemSeg test skipping for Java 11 2021-05-28 15:13:47 +02:00
Chris Vest
ecbd2476e1 Use correct assume function for JUnit4 tests 2021-05-28 14:08:55 +02:00
Chris Vest
af119de4a7 Implement BufferIntegratable for Nio- and UnsafeBuffer 2021-05-28 14:08:55 +02:00
Chris Vest
a6b81c89ef Fix test failures in ByteToMessageDecoderTest 2021-05-28 12:23:16 +02:00
Chris Vest
b1b2c983f8 Do less aggressive test sampling when running tests locally
Instead of filtering out 95% of test samples, now only filter out 85%.
2021-05-27 17:38:38 +02:00
Chris Vest
05d76c27c1 Hide isOwned, countBorrows, and acquire from the public API, even on CompositeBuffer 2021-05-27 17:34:40 +02:00
Chris Vest
1c25fa88b7 Fix test failures coming from removal of slice and introduction of copy. 2021-05-27 17:06:30 +02:00
Chris Vest
707e5e2afb Remove the slice methods, add copy methods 2021-05-27 14:07:31 +02:00
Chris Vest
bfa8fd0b1f Make tests pass after removing acquire from the public API 2021-05-27 11:39:57 +02:00
Chris Vest
f0ee2e1467 Remove acquire from the public API
This is a step toward effectively eliminating reference counting.
Reference counting is only needed when the memory in buffers can be shared.
If we remove all forms of sharing, then the buffers would be in an owned state at all times.
Then we would no longer need to worry about the state of the buffers before calling, e.g. `ensureWritable` and methods like that.

Just removing `acquire` is not enough; we also need to remove the `slice` method.
In this commit we are, however, starting with `acquire` because doing so requires rearranging the type hierarchy and the generics we have in play.
This was not an easy exercise, but for the purpose of record keeping, it's useful to have that work separate from the work of removing `slice`.
2021-05-26 17:19:26 +02:00
Chris Vest
9dc1d533e3 Fix remaining tests and make the build work on Java 11 2021-05-21 17:28:07 +02:00
Chris Vest
1143223407 First draft of splitting the repo into multiple modules and allowing builds with Java 11 2021-05-21 14:04:23 +02:00