From 017dfff5273a2a37eca36f0c6e91a56fdc3a9e4b Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Wed, 3 Dec 2008 08:09:10 +0000 Subject: [PATCH] Fixed incorrect conditional statements --- .../netty/handler/codec/embedder/AbstractCodecEmbedder.java | 2 +- .../jboss/netty/handler/codec/embedder/DecoderEmbedder.java | 4 ++-- .../jboss/netty/handler/codec/embedder/EncoderEmbedder.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/jboss/netty/handler/codec/embedder/AbstractCodecEmbedder.java b/src/main/java/org/jboss/netty/handler/codec/embedder/AbstractCodecEmbedder.java index d76171e8ad..1c98b193b6 100644 --- a/src/main/java/org/jboss/netty/handler/codec/embedder/AbstractCodecEmbedder.java +++ b/src/main/java/org/jboss/netty/handler/codec/embedder/AbstractCodecEmbedder.java @@ -55,7 +55,7 @@ abstract class AbstractCodecEmbedder implements CodecEmbedder { fireChannelDisconnected(context, channel); fireChannelUnbound(context, channel); fireChannelClosed(context, channel); - return context.productQueue.isEmpty(); + return !context.productQueue.isEmpty(); } @SuppressWarnings("unchecked") diff --git a/src/main/java/org/jboss/netty/handler/codec/embedder/DecoderEmbedder.java b/src/main/java/org/jboss/netty/handler/codec/embedder/DecoderEmbedder.java index abb99e29b5..066fc96bd7 100644 --- a/src/main/java/org/jboss/netty/handler/codec/embedder/DecoderEmbedder.java +++ b/src/main/java/org/jboss/netty/handler/codec/embedder/DecoderEmbedder.java @@ -38,7 +38,7 @@ public class DecoderEmbedder extends AbstractCodecEmbedder { } public boolean offer(Object input) { - fireMessageReceived(context.getChannel(), input); - return context.productQueue.isEmpty(); + fireMessageReceived(context, context.getChannel(), input); + return !context.productQueue.isEmpty(); } } diff --git a/src/main/java/org/jboss/netty/handler/codec/embedder/EncoderEmbedder.java b/src/main/java/org/jboss/netty/handler/codec/embedder/EncoderEmbedder.java index 61965cfc44..54725d1fe2 100644 --- a/src/main/java/org/jboss/netty/handler/codec/embedder/EncoderEmbedder.java +++ b/src/main/java/org/jboss/netty/handler/codec/embedder/EncoderEmbedder.java @@ -41,6 +41,6 @@ public class EncoderEmbedder extends AbstractCodecEmbedder { public boolean offer(Object input) { Channel channel = context.getChannel(); write(context, channel, succeededFuture(channel), input); - return context.productQueue.isEmpty(); + return !context.productQueue.isEmpty(); } }