andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename ChannelHandlerContext#fireUserEventTriggered() argument from event to evt so it matches the ChannelInboundHandler#userEventTriggered() argument's name.

Browse Source 
Motivation

When I override ChannelHandler methods I usually (always) refire events myself via
ChannelHandlerContext instead of relieing on calling the super method (say
`super.write(ctx, ...)`). This works great and the IDE actually auto completes/generates
the right code for it except `#fireUserEventTriggered()` and `#userEventTriggered()`
which have a mismatching argument names and I have to manually "intervene".

Modification

Rename `ChannelHandlerContext#fireUserEventTriggered()` argument from `event` to `evt`
to match its handler counterpart.

Result

The IDE's auto generated code will reference the correct variable.
This commit is contained in:
Roger Kapsi 2016-07-07 08:57:19 -04:00 committed by Norman Maurer
parent 29fdb160f3
commit 02850da480
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/ChannelHandlerContext.java
View File

@ -169,7 +169,7 @@ public interface ChannelHandlerContext extends AttributeMap, ChannelInboundInvok
ChannelHandlerContext fireExceptionCaught(Throwable cause); ChannelHandlerContext fireExceptionCaught(Throwable cause);
@Override @Override
ChannelHandlerContext fireUserEventTriggered(Object event); ChannelHandlerContext fireUserEventTriggered(Object evt);
@Override @Override
ChannelHandlerContext fireChannelRead(Object msg); ChannelHandlerContext fireChannelRead(Object msg);