andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

HttpUtil#is100ContinueExpected clean up (#8740)

Browse Source 
Motivation:

Current implementation extract header value as String. We have an idiomatic way for checking presence of a header value.

Modification:

Use HttpHeaders#contains for checking if if contains Expect: 100-continue.

Result:

Use idiomatic way + simplify boolean logic.
This commit is contained in:
Stephane Landelle 2019-01-22 08:49:43 +01:00 committed by Norman Maurer
parent cf03ed0478
commit 0431368621
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
View File

@ -251,13 +251,9 @@ public final class HttpUtil {
* present * present
*/ */
public static boolean is100ContinueExpected(HttpMessage message) { public static boolean is100ContinueExpected(HttpMessage message) {
if (!isExpectHeaderValid(message)) { return isExpectHeaderValid(message)
return false; // unquoted tokens in the expect header are case-insensitive, thus 100-continue is case insensitive
} && message.headers().contains(HttpHeaderNames.EXPECT, HttpHeaderValues.CONTINUE, true);
final String expectValue = message.headers().get(HttpHeaderNames.EXPECT);
// unquoted tokens in the expect header are case-insensitive, thus 100-continue is case insensitive
return HttpHeaderValues.CONTINUE.toString().equalsIgnoreCase(expectValue);
} }
/** /**