andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2720] Check if /proc/sys/net/core/somaxconn exists before try to parse it

Browse Source 
Motivation:

As /proc/sys/net/core/somaxconn does not exists on non-linux platforms you see a noisy stacktrace when debug level is enabled while the static method of NetUtil is executed.

Modifications:

Check if the file exists before try to parse it.

Result:

Less noisy logging on non-linux platforms.
This commit is contained in:
Norman Maurer 2014-07-31 18:05:18 -07:00
parent c5ae3e3dcb
commit 045f9ff0ed
1 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
common/src/main/java/io/netty/util/NetUtil.java
View File

@ -20,6 +20,7 @@ import io.netty.util.internal.logging.InternalLogger;
import io.netty.util.internal.logging.InternalLoggerFactory;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.net.Inet4Address;
import java.net.Inet6Address;
@ -180,21 +181,26 @@ public final class NetUtil {
// Determine the default somaxconn (server socket backlog) value of the platform.
int somaxconn = 3072;
BufferedReader in = null;
try {
in = new BufferedReader(new FileReader("/proc/sys/net/core/somaxconn"));
somaxconn = Integer.parseInt(in.readLine());
logger.debug("/proc/sys/net/core/somaxconn: {}", somaxconn);
} catch (Exception e) {
logger.debug("Failed to get SOMAXCONN", e);
} finally {
if (in != null) {
try {
in.close();
} catch (Exception e) {
// Ignored.
File file = new File("/proc/sys/net/core/somaxconn");
if (file.exists()) {
BufferedReader in = null;
try {
in = new BufferedReader(new FileReader("/proc/sys/net/core/somaxconn"));
somaxconn = Integer.parseInt(in.readLine());
logger.debug("/proc/sys/net/core/somaxconn: {}", somaxconn);
} catch (Exception e) {
logger.debug("Failed to get SOMAXCONN", e);
} finally {
if (in != null) {
try {
in.close();
} catch (Exception e) {
// Ignored.
}
}
}
} else {
logger.debug("/proc/sys/net/core/somaxconn not exists. Use default-value: {}", somaxconn);
}
SOMAXCONN = somaxconn;