andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change Timeout.cancel() to return a boolean value, true on a successful cancel

Browse Source 
As requested in the javadoc for HashedWheelTimer
This commit is contained in:
Cruz Julian Bishop 2012-06-29 21:59:48 +10:00
parent c35f90f920
commit 04cf836cf0
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/src/main/java/io/netty/util/HashedWheelTimer.java
View File

@ -501,13 +501,13 @@ public class HashedWheelTimer implements Timer {
} }
@Override @Override
public void cancel() { public boolean cancel() {
if (!state.compareAndSet(ST_INIT, ST_CANCELLED)) { if (!state.compareAndSet(ST_INIT, ST_CANCELLED)) {
// TODO return false return false;
return;
} }
wheel[stopIndex].remove(this); wheel[stopIndex].remove(this);
return true;
} }
@Override @Override

10
common/src/main/java/io/netty/util/Timeout.java
View File

@ -44,9 +44,11 @@ public interface Timeout {
boolean isCancelled(); boolean isCancelled();
/** /**
* Cancels the {@link TimerTask} associated with this handle. It the * Attempts to cancel the {@link TimerTask} associated with this handle.
* task has been executed or cancelled already, it will return with no * If the task has been executed or cancelled already, it will return with
* side effect. * no side effect.
*
* @return True if the cancellation completed successfully, otherwise false
*/ */
void cancel(); boolean cancel();
} }