andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Check for NPE and also optimze HashSet allocation

Browse Source
This commit is contained in:
Norman Maurer 2013-03-10 21:06:59 +01:00
parent 0ac5fd9f18
commit 0504a442ae
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
transport/src/main/java/io/netty/channel/ChannelPromiseAggregator.java
View File

@ -32,16 +32,31 @@ public final class ChannelPromiseAggregator implements ChannelFutureListener {
private Set<ChannelPromise> pendingPromises;
public ChannelPromiseAggregator(ChannelPromise aggregatePromise) {
if (aggregatePromise == null) {
throw new NullPointerException("aggregatePromise");
}
this.aggregatePromise = aggregatePromise;
}
/**
* Add the given {@link ChannelPromise}s to the aggregator.
*/
public ChannelPromiseAggregator add(ChannelPromise... promises) {
if (promises == null) {
throw new NullPointerException("promises");
}
if (promises.length == 0) {
return this;
}
synchronized (this) {
if (pendingPromises == null) {
pendingPromises = new HashSet<ChannelPromise>();
int size;
if (promises.length > 1) {
size = promises.length;
} else {
size = 2;
}
pendingPromises = new HashSet<ChannelPromise>(size);
}
for (ChannelPromise p: promises) {
if (p == null) {