From 05f959335228938d3fa2c46ae743363c2be689a6 Mon Sep 17 00:00:00 2001 From: JongYoon Lim Date: Thu, 30 Apr 2015 14:02:32 +0900 Subject: [PATCH] Remove the unreachable checking code Motivation: 'length2 == 0' is not reachable because length1 and length2 are same at this point. Motification: Removed 'length2 == 0'. Result: Cleaner code. --- common/src/main/java/io/netty/util/AsciiString.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java index 9878126cd4..92b1db52ac 100644 --- a/common/src/main/java/io/netty/util/AsciiString.java +++ b/common/src/main/java/io/netty/util/AsciiString.java @@ -959,9 +959,7 @@ public final class AsciiString extends ByteString implements CharSequence, Compa int length2 = cs.length(); if (length1 != length2) { return false; - } - - if (length1 == 0 && length2 == 0) { + } else if (length1 == 0) { return true; // since both are empty strings }