From 07a641900c55652d71018c0c1474aba20059432a Mon Sep 17 00:00:00 2001
From: Scott Mitchell <scott_mitchell@apple.com>
Date: Tue, 27 Jun 2017 15:54:04 -0400
Subject: [PATCH] transport-native-kqueue libraries should not lazy link

Motivation:
We rely upon the linker being non-lazy to test compatibility the native library compatibility for kqueue, but the default mode of operation is to lazy link.

Modifications:
- We should modify the build scripts to inform the linker that this library should not be lazy linked
- Error messages changes
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime

java.lang.UnsatisfiedLinkError: unsupported JNI version 0xFFFFFFFF required by .../libnetty-transport-native-kqueue.dylib

Result:
Link errors are detected upon library load time.
---
 transport-native-kqueue/pom.xml      | 6 +++++-
 transport-native-unix-common/pom.xml | 4 ++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/transport-native-kqueue/pom.xml b/transport-native-kqueue/pom.xml
index 5a0d83ba2f..c6bdda2874 100644
--- a/transport-native-kqueue/pom.xml
+++ b/transport-native-kqueue/pom.xml
@@ -79,6 +79,10 @@
                   <configureArgs>
                     <arg>${jni.compiler.args.ldflags}</arg>
                     <arg>${jni.compiler.args.cflags}</arg>
+                    <!-- support for __attribute__((weak_import)) by the linker was added in 10.2 so ensure we
+                         explicitly set the target platform. Otherwise we may get fatal link errors due to weakly linked
+                         methods which are not expected to be present on MacOS (e.g. accept4). -->
+                    <arg>MACOSX_DEPLOYMENT_TARGET=10.2</arg>
                   </configureArgs>
                 </configuration>
                 <goals>
@@ -353,7 +357,7 @@
     <unix.common.lib.unpacked.dir>${unix.common.lib.dir}/META-INF/native/lib</unix.common.lib.unpacked.dir>
     <unix.common.include.unpacked.dir>${unix.common.lib.dir}/META-INF/native/include</unix.common.include.unpacked.dir>
     <jni.compiler.args.cflags>CFLAGS=-O3 -Werror -fno-omit-frame-pointer -Wunused-variable -I${unix.common.include.unpacked.dir}</jni.compiler.args.cflags>
-    <jni.compiler.args.ldflags>LDFLAGS=-L${unix.common.lib.unpacked.dir} -Wl,--whole-archive -l${unix.common.lib.name} -Wl,--no-whole-archive</jni.compiler.args.ldflags>
+    <jni.compiler.args.ldflags>LDFLAGS=-z now -L${unix.common.lib.unpacked.dir} -Wl,--whole-archive -l${unix.common.lib.name} -Wl,--no-whole-archive</jni.compiler.args.ldflags>
     <skipTests>true</skipTests>
   </properties>
 
diff --git a/transport-native-unix-common/pom.xml b/transport-native-unix-common/pom.xml
index 3f14ae1e06..66f9578c6a 100644
--- a/transport-native-unix-common/pom.xml
+++ b/transport-native-unix-common/pom.xml
@@ -102,6 +102,10 @@
                       <env key="CFLAGS" value="-O3 -Werror -Wno-attributes -fPIC -fno-omit-frame-pointer -Wunused-variable" />
                       <env key="LDFLAGS" value="-Wl,--no-as-needed -lrt" />
                       <env key="LIB_NAME" value="${nativeLibName}" />
+                      <!-- support for __attribute__((weak_import)) by the linker was added in 10.2 so ensure we
+                           explicitly set the target platform. Otherwise we may get fatal link errors due to weakly linked
+                           methods which are not expected to be present on MacOS (e.g. accept4). -->
+                      <env key="MACOSX_DEPLOYMENT_TARGET" value="10.2" />
                     </exec>
                   </target>
                 </configuration>