andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Less memory copy for OIO datagram transport

Browse Source
This commit is contained in:
Trustin Lee 2009-06-12 02:08:58 +00:00
parent ee3ae043dc
commit 08107683b3
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/org/jboss/netty/channel/socket/oio/OioDatagramWorker.java
View File

@ -28,6 +28,7 @@ import java.io.InterruptedIOException;
import java.net.DatagramPacket;
import java.net.MulticastSocket;
import java.net.SocketAddress;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import org.jboss.netty.buffer.ChannelBuffer;
@ -113,16 +114,26 @@ class OioDatagramWorker implements Runnable {
OioDatagramChannel channel, ChannelFuture future,
Object message, SocketAddress remoteAddress) {
try {
// FIXME: Avoid extra copy.
ChannelBuffer a = (ChannelBuffer) message;
byte[] b = new byte[a.readableBytes()];
a.getBytes(0, b);
DatagramPacket packet = new DatagramPacket(b, b.length);
ChannelBuffer buf = (ChannelBuffer) message;
int length = buf.readableBytes();
ByteBuffer nioBuf = buf.toByteBuffer();
DatagramPacket packet;
if (nioBuf.hasArray()) {
// Avoid copy if the buffer is backed by an array.
packet = new DatagramPacket(
nioBuf.array(), nioBuf.arrayOffset(), length);
} else {
// Otherwise it will be expensive.
byte[] arrayBuf = new byte[length];
buf.getBytes(0, arrayBuf);
packet = new DatagramPacket(arrayBuf, length);
}
if (remoteAddress != null) {
packet.setSocketAddress(remoteAddress);
}
channel.socket.send(packet);
fireWriteComplete(channel, b.length);
fireWriteComplete(channel, length);
future.setSuccess();
} catch (Throwable t) {
future.setFailure(t);