From 0ac8835e36ca20c33dc58d4710b23d95525b696d Mon Sep 17 00:00:00 2001 From: Riley Park Date: Thu, 27 May 2021 06:59:36 -0700 Subject: [PATCH] Migrate testsuite-shading tests to JUnit 5 (#11323) Motivation: JUnit 5 is more expressive, extensible, and composable in many ways, and it's better able to run tests in parallel. Modifications: Use JUnit5 in tests Result: Related to https://github.com/netty/netty/issues/10757 --- .../test/java/io/netty/testsuite/shading/ShadingIT.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/testsuite-shading/src/test/java/io/netty/testsuite/shading/ShadingIT.java b/testsuite-shading/src/test/java/io/netty/testsuite/shading/ShadingIT.java index 7fceeed244..d0ff617ffb 100644 --- a/testsuite-shading/src/test/java/io/netty/testsuite/shading/ShadingIT.java +++ b/testsuite-shading/src/test/java/io/netty/testsuite/shading/ShadingIT.java @@ -16,11 +16,12 @@ package io.netty.testsuite.shading; import io.netty.util.internal.PlatformDependent; -import org.junit.Test; -import org.junit.Assume; +import org.junit.jupiter.api.Test; import java.lang.reflect.Method; +import static org.junit.jupiter.api.Assumptions.assumeFalse; + public class ShadingIT { private static final String SHADING_PREFIX = System.getProperty("shadingPrefix2"); @@ -29,7 +30,7 @@ public class ShadingIT { @Test public void testShadingNativeTransport() throws Exception { // Skip on windows. - Assume.assumeFalse(PlatformDependent.isWindows()); + assumeFalse(PlatformDependent.isWindows()); String className = PlatformDependent.isOsx() ? "io.netty.channel.kqueue.KQueue" : "io.netty.channel.epoll.Epoll"; @@ -40,7 +41,7 @@ public class ShadingIT { @Test public void testShadingTcnative() throws Exception { // Skip on windows. - Assume.assumeFalse(PlatformDependent.isWindows()); + assumeFalse(PlatformDependent.isWindows()); String className = "io.netty.handler.ssl.OpenSsl"; testShading0(SHADING_PREFIX, className);