From 0adccfdb50e69b96ce0384e67782540a9df1be7a Mon Sep 17 00:00:00 2001
From: Norman Maurer <norman_maurer@apple.com>
Date: Fri, 16 Mar 2018 21:48:54 +0100
Subject: [PATCH] Simplify DefaultChannelGroup.contains(...) and so remove one
 instanceof check.

Motivation:

DefaultChannelGroup.contains(...) did one more instanceof check then needed.

Modifications:

Simplify contains(...) and remove one instanceof check.

Result:

Simplier and cheaper implementation.
---
 .../netty/channel/group/DefaultChannelGroup.java   | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java b/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
index 9f64ad07ca..71f217a174 100644
--- a/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
+++ b/transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
@@ -126,16 +126,12 @@ public class DefaultChannelGroup extends AbstractSet<Channel> implements Channel
 
     @Override
     public boolean contains(Object o) {
-        if (o instanceof Channel) {
-            Channel c = (Channel) o;
-            if (o instanceof ServerChannel) {
-                return serverChannels.containsValue(c);
-            } else {
-                return nonServerChannels.containsValue(c);
-            }
-        } else {
-            return false;
+        if (o instanceof ServerChannel) {
+            return serverChannels.containsValue(o);
+        } else if (o instanceof Channel) {
+            return nonServerChannels.containsValue(o);
         }
+        return false;
     }
 
     @Override