andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix unnecessary boxing and incorrect Serializable

Browse Source 
Motivation:

- AbstractHttp2ConnectionHandlerBuilder.encoderEnforceMaxConcurrentStreams can be the primitive boolean
- SpdySession.StreamComparator should not be Serializable since SpdySession is not Serializable

Modifications:

Use boolean instead and remove Serializable

Result:

- Minor improvement for AbstractHttp2ConnectionHandlerBuilder
- StreamComparator is not Serializable any more
This commit is contained in:
Xiaoyan Lin 2015-12-30 21:44:42 -08:00 committed by Norman Maurer
parent 0b16c3c513
commit 0ae6f17285
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-http/src/main/java/io/netty/handler/codec/spdy/SpdySession.java
View File

@ -323,9 +323,7 @@ final class SpdySession {
} }
} }
private final class StreamComparator implements Comparator<Integer>, Serializable { private final class StreamComparator implements Comparator<Integer> {
private static final long serialVersionUID = 1161471649740544848L;
StreamComparator() { } StreamComparator() { }

4
codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java
View File

@ -94,7 +94,7 @@ public abstract class AbstractHttp2ConnectionHandlerBuilder<T extends Http2Conne
// * OK to use with server() and connection() // * OK to use with server() and connection()
private Http2FrameLogger frameLogger; private Http2FrameLogger frameLogger;
private SensitivityDetector headerSensitivityDetector; private SensitivityDetector headerSensitivityDetector;
private Boolean encoderEnforceMaxConcurrentStreams; private boolean encoderEnforceMaxConcurrentStreams;
/** /**
* Returns if HTTP headers should be validated according to * Returns if HTTP headers should be validated according to
@ -268,7 +268,7 @@ public abstract class AbstractHttp2ConnectionHandlerBuilder<T extends Http2Conne
* would otherwise be exceeded. * would otherwise be exceeded.
*/ */
protected boolean encoderEnforceMaxConcurrentStreams() { protected boolean encoderEnforceMaxConcurrentStreams() {
return encoderEnforceMaxConcurrentStreams != null ? encoderEnforceMaxConcurrentStreams : false; return encoderEnforceMaxConcurrentStreams;
} }
/** /**