andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IdleStateHandler volatile member variables

Browse Source 
Motivation:
IdleStateHandler has a number of volatile member variables which are only accessed from the EventLoop thread. These do not have to be volatile. The accessibility of these member variables are not consistent between private and package private. The state variable can also use a byte instead of an int.

Modifications:
- Remove volatile from member variables
- Change access to private for member variables
- Change state from int to byte

Result:
IdleStateHandler member variables cleaned up.
This commit is contained in:
Scott Mitchell 2016-09-13 17:03:05 -07:00
parent 908464f161
commit 0b5e75a614
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
View File

@ -110,19 +110,19 @@ public class IdleStateHandler extends ChannelDuplexHandler {
private final long writerIdleTimeNanos; private final long writerIdleTimeNanos;
private final long allIdleTimeNanos; private final long allIdleTimeNanos;
volatile ScheduledFuture<?> readerIdleTimeout; private ScheduledFuture<?> readerIdleTimeout;
volatile long lastReadTime; private long lastReadTime;
private boolean firstReaderIdleEvent = true; private boolean firstReaderIdleEvent = true;
volatile ScheduledFuture<?> writerIdleTimeout; private ScheduledFuture<?> writerIdleTimeout;
volatile long lastWriteTime; private long lastWriteTime;
private boolean firstWriterIdleEvent = true; private boolean firstWriterIdleEvent = true;
volatile ScheduledFuture<?> allIdleTimeout; private ScheduledFuture<?> allIdleTimeout;
private boolean firstAllIdleEvent = true; private boolean firstAllIdleEvent = true;
private volatile int state; // 0 - none, 1 - initialized, 2 - destroyed private byte state; // 0 - none, 1 - initialized, 2 - destroyed
private volatile boolean reading; private boolean reading;
/** /**
* Creates a new instance firing {@link IdleStateEvent}s. * Creates a new instance firing {@link IdleStateEvent}s.