andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleaner resource leak report by excluding noisy stack trace elements

Browse Source
This commit is contained in:
Trustin Lee 2014-01-29 11:52:28 +09:00
parent 293e34e13f
commit 0bf5ca22cb
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
common/src/main/java/io/netty/util/ResourceLeakDetector.java
View File

@ -259,13 +259,13 @@ public final class ResourceLeakDetector<T> {
private DefaultResourceLeak prev;
private DefaultResourceLeak next;
public DefaultResourceLeak(Object referent) {
DefaultResourceLeak(Object referent) {
super(referent, referent != null? refQueue : null);
if (referent != null) {
Level level = getLevel();
if (level.ordinal() >= Level.ADVANCED.ordinal()) {
creationRecord = newRecord();
creationRecord = newRecord(3);
} else {
creationRecord = null;
}
@ -288,7 +288,7 @@ public final class ResourceLeakDetector<T> {
@Override
public void record() {
if (creationRecord != null) {
String value = newRecord();
String value = newRecord(2);
synchronized (lastRecords) {
int size = lastRecords.size();
@ -352,17 +352,33 @@ public final class ResourceLeakDetector<T> {
}
}
private static String newRecord() {
private static final String[] STACK_TRACE_ELEMENT_EXCLUSIONS = {
"io.netty.buffer.AbstractByteBufAllocator.toLeakAwareBuffer(",
};
static String newRecord(int recordsToSkip) {
StringBuilder buf = new StringBuilder(4096);
StackTraceElement[] array = new Throwable().getStackTrace();
int recordsToSkip = 3;
for (StackTraceElement e: array) {
if (recordsToSkip > 0) {
recordsToSkip --;
} else {
buf.append('\t');
buf.append(e.toString());
buf.append(NEWLINE);
String estr = e.toString();
// Strip the noisy stack trace elements.
boolean excluded = false;
for (String exclusion: STACK_TRACE_ELEMENT_EXCLUSIONS) {
if (estr.startsWith(exclusion)) {
excluded = true;
break;
}
}
if (!excluded) {
buf.append('\t');
buf.append(estr);
buf.append(NEWLINE);
}
}
}