andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Resolved issue: NETTY-346 ReplayingDecoderBuffer doesn't support array()

Browse Source 
* Added ReplayingDecoder.internalBuffer() so that a brave user accesses the internal buffer directly at one's own risk
This commit is contained in:
Trustin Lee 2010-08-30 06:02:08 +00:00
parent d4438170c9
commit 0cc728a9f0
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/main/java/org/jboss/netty/handler/codec/replay/ReplayingDecoder.java
View File

@ -20,6 +20,7 @@ import java.util.concurrent.atomic.AtomicReference;
import org.jboss.netty.buffer.ChannelBuffer; import org.jboss.netty.buffer.ChannelBuffer;
import org.jboss.netty.buffer.ChannelBufferFactory; import org.jboss.netty.buffer.ChannelBufferFactory;
import org.jboss.netty.buffer.ChannelBuffers;
import org.jboss.netty.channel.Channel; import org.jboss.netty.channel.Channel;
import org.jboss.netty.channel.ChannelHandler; import org.jboss.netty.channel.ChannelHandler;
import org.jboss.netty.channel.ChannelHandlerContext; import org.jboss.netty.channel.ChannelHandlerContext;
@ -365,17 +366,26 @@ public abstract class ReplayingDecoder<T extends Enum<T>>
} }
/** /**
* Returns the actual number of readable bytes in the cumulative buffer * Returns the actual number of readable bytes in the internal cumulative
* of this decoder. You do not need to rely on this value to write a * buffer of this decoder. You usually do not need to rely on this value
* decoder. Use it only when necessary. * to write a decoder. Use it only when you muse use it at your own risk.
* This method is a shortcut to {@link #internalBuffer() internalBuffer().readableBytes()}.
*/ */
protected int actualReadableBytes() { protected int actualReadableBytes() {
ChannelBuffer buf = cumulation.get(); return internalBuffer().readableBytes();
if (buf == null) {
return 0;
} }
return buf.readableBytes(); /**
* Returns the internal cumulative buffer of this decoder. You usually
* do not need to access the internal buffer directly to write a decoder.
* Use it only when you must use it at your own risk.
*/
protected ChannelBuffer internalBuffer() {
ChannelBuffer buf = cumulation.get();
if (buf == null) {
return ChannelBuffers.EMPTY_BUFFER;
}
return buf;
} }
/** /**