From 0cf3f54a8d284d76726150a72d1b109969f8b72a Mon Sep 17 00:00:00 2001 From: fenik17 Date: Tue, 14 Feb 2017 01:48:33 +0500 Subject: [PATCH] Adding 'final' keyword for private fields where possible Motivation Missing 'final' keyword for fields Modifications Add 'final' for fields where possible Result More safe and consistent code --- .../java/io/netty/buffer/ByteBufInputStream.java | 2 +- .../codec/http2/DefaultHttp2GoAwayFrame.java | 2 +- .../handler/codec/redis/FixedRedisMessagePool.java | 14 +++++++------- .../src/main/java/io/netty/util/ConstantPool.java | 2 +- .../helloworld/client/Http2SettingsHandler.java | 2 +- .../helloworld/client/HttpResponseHandler.java | 2 +- .../java/io/netty/channel/DefaultChannelId.java | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java index e36b936a5a..e82a55f08a 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBufInputStream.java @@ -50,7 +50,7 @@ public class ByteBufInputStream extends InputStream implements DataInput { * However in future releases ownership should always be transferred and callers of this class should call * {@link ReferenceCounted#retain()} if necessary. */ - private boolean releaseOnClose; + private final boolean releaseOnClose; /** * Creates a new stream which reads data from the specified {@code buffer} diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2GoAwayFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2GoAwayFrame.java index e9cbf97429..8f54b8e329 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2GoAwayFrame.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2GoAwayFrame.java @@ -27,7 +27,7 @@ import io.netty.util.internal.UnstableApi; public final class DefaultHttp2GoAwayFrame extends DefaultByteBufHolder implements Http2GoAwayFrame { private final long errorCode; - private int lastStreamId; + private final int lastStreamId; private int extraStreamIds; /** diff --git a/codec-redis/src/main/java/io/netty/handler/codec/redis/FixedRedisMessagePool.java b/codec-redis/src/main/java/io/netty/handler/codec/redis/FixedRedisMessagePool.java index fc165fced1..0508f2e3dc 100644 --- a/codec-redis/src/main/java/io/netty/handler/codec/redis/FixedRedisMessagePool.java +++ b/codec-redis/src/main/java/io/netty/handler/codec/redis/FixedRedisMessagePool.java @@ -71,13 +71,13 @@ public final class FixedRedisMessagePool implements RedisMessagePool { public static final FixedRedisMessagePool INSTANCE = new FixedRedisMessagePool(); // internal caches. - private Map byteBufToSimpleStrings; - private Map stringToSimpleStrings; - private Map byteBufToErrors; - private Map stringToErrors; - private Map byteBufToIntegers; - private LongObjectMap longToIntegers; - private LongObjectMap longToByteBufs; + private final Map byteBufToSimpleStrings; + private final Map stringToSimpleStrings; + private final Map byteBufToErrors; + private final Map stringToErrors; + private final Map byteBufToIntegers; + private final LongObjectMap longToIntegers; + private final LongObjectMap longToByteBufs; /** * Creates a {@link FixedRedisMessagePool} instance. diff --git a/common/src/main/java/io/netty/util/ConstantPool.java b/common/src/main/java/io/netty/util/ConstantPool.java index 66e723438b..881f1910e3 100644 --- a/common/src/main/java/io/netty/util/ConstantPool.java +++ b/common/src/main/java/io/netty/util/ConstantPool.java @@ -31,7 +31,7 @@ public abstract class ConstantPool> { private final ConcurrentMap constants = PlatformDependent.newConcurrentHashMap(); - private AtomicInteger nextId = new AtomicInteger(1); + private final AtomicInteger nextId = new AtomicInteger(1); /** * Shortcut of {@link #valueOf(String) valueOf(firstNameComponent.getName() + "#" + secondNameComponent)}. diff --git a/example/src/main/java/io/netty/example/http2/helloworld/client/Http2SettingsHandler.java b/example/src/main/java/io/netty/example/http2/helloworld/client/Http2SettingsHandler.java index 0867cb2c83..9c20b7ca0c 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/client/Http2SettingsHandler.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/client/Http2SettingsHandler.java @@ -25,7 +25,7 @@ import java.util.concurrent.TimeUnit; * Reads the first {@link Http2Settings} object and notifies a {@link io.netty.channel.ChannelPromise} */ public class Http2SettingsHandler extends SimpleChannelInboundHandler { - private ChannelPromise promise; + private final ChannelPromise promise; /** * Create new instance diff --git a/example/src/main/java/io/netty/example/http2/helloworld/client/HttpResponseHandler.java b/example/src/main/java/io/netty/example/http2/helloworld/client/HttpResponseHandler.java index 057e84e9f4..5ba8c9ebf2 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/client/HttpResponseHandler.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/client/HttpResponseHandler.java @@ -35,7 +35,7 @@ import java.util.concurrent.TimeUnit; */ public class HttpResponseHandler extends SimpleChannelInboundHandler { - private Map> streamidPromiseMap; + private final Map> streamidPromiseMap; public HttpResponseHandler() { // Use a concurrent map because we add and iterate from the main thread (just for the purposes of the example), diff --git a/transport/src/main/java/io/netty/channel/DefaultChannelId.java b/transport/src/main/java/io/netty/channel/DefaultChannelId.java index adf37128b0..1409bcbadd 100644 --- a/transport/src/main/java/io/netty/channel/DefaultChannelId.java +++ b/transport/src/main/java/io/netty/channel/DefaultChannelId.java @@ -154,7 +154,7 @@ public final class DefaultChannelId implements ChannelId { } private final byte[] data; - private int hashCode; + private final int hashCode; private transient String shortValue; private transient String longValue;