andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add task before starting thread in SingleThreadEventExecutor.execute (#7841)

Browse Source 
Motivation:

Minor performance optimisation that prevents thread from blocking due to task not having been added to queue. Discussed #7815.

Modification:

add task to the queue before starting the thread.

Result:

No additional tests.
This commit is contained in:
Dave Moten 2018-04-05 15:57:21 +10:00 committed by Norman Maurer
parent 0a61f055f5
commit 0f4001d598
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
View File

@ -762,11 +762,9 @@ public abstract class SingleThreadEventExecutor extends AbstractScheduledEventEx
} }
boolean inEventLoop = inEventLoop(); boolean inEventLoop = inEventLoop();
if (inEventLoop) { addTask(task);
addTask(task); if (!inEventLoop) {
} else {
startThread(); startThread();
addTask(task);
if (isShutdown() && removeTask(task)) { if (isShutdown() && removeTask(task)) {
reject(); reject();
} }