andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Http2FrameLogger frame labels incorrect

Browse Source 
Motivation:
The labels identifying the frame types in Http2FrameLogger are not always correct.

Modification:
- Correct the string labels to indicate the right frame type in Http2FrameLogger

Result:
Logs are more correct.
This commit is contained in:
Scott Mitchell 2017-08-07 08:19:32 -07:00
parent 918fde82f8
commit 0f8ecdcad5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java
View File

@ -62,19 +62,19 @@ public class Http2FrameLogger extends ChannelHandlerAdapter {
public void logData(Direction direction, ChannelHandlerContext ctx, int streamId, ByteBuf data, int padding, public void logData(Direction direction, ChannelHandlerContext ctx, int streamId, ByteBuf data, int padding,
boolean endStream) { boolean endStream) {
logger.log(level, "{} {} PRIORITY: streamId={} padding={} endStream={} length={} bytes={}", ctx.channel(), logger.log(level, "{} {} DATA: streamId={} padding={} endStream={} length={} bytes={}", ctx.channel(),
direction.name(), streamId, padding, endStream, data.readableBytes(), toString(data)); direction.name(), streamId, padding, endStream, data.readableBytes(), toString(data));
} }
public void logHeaders(Direction direction, ChannelHandlerContext ctx, int streamId, Http2Headers headers, public void logHeaders(Direction direction, ChannelHandlerContext ctx, int streamId, Http2Headers headers,
int padding, boolean endStream) { int padding, boolean endStream) {
logger.log(level, "{} {} PRIORITY: streamId={} headers={} padding={} endStream={}", ctx.channel(), logger.log(level, "{} {} HEADERS: streamId={} headers={} padding={} endStream={}", ctx.channel(),
direction.name(), streamId, headers, padding, endStream); direction.name(), streamId, headers, padding, endStream);
} }
public void logHeaders(Direction direction, ChannelHandlerContext ctx, int streamId, Http2Headers headers, public void logHeaders(Direction direction, ChannelHandlerContext ctx, int streamId, Http2Headers headers,
int streamDependency, short weight, boolean exclusive, int padding, boolean endStream) { int streamDependency, short weight, boolean exclusive, int padding, boolean endStream) {
logger.log(level, "{} {} PRIORITY: streamId={} headers={} streamDependency={} weight={} exclusive={} " + logger.log(level, "{} {} HEADERS: streamId={} headers={} streamDependency={} weight={} exclusive={} " +
"padding={} endStream={}", ctx.channel(), "padding={} endStream={}", ctx.channel(),
direction.name(), streamId, headers, streamDependency, weight, exclusive, padding, endStream); direction.name(), streamId, headers, streamDependency, weight, exclusive, padding, endStream);
} }