From 100b397ca8ed7081ba6e93fb2b49631c6e8f066c Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Fri, 22 Jul 2016 21:33:23 +0200 Subject: [PATCH] [#5551] Fix sporadic GlobalEventExecutorTest.testAutomaticStartStop test failure Motivation: We saw some sporadic test failures for GlobalEventExecutorTest.testAutomaticStartStop test. This is caused parallel execution of tests in combination with assert checks that will be affected. Modifications: Remove fragile assert checks. Result: No more sporadic test failures --- .../java/io/netty/util/concurrent/GlobalEventExecutorTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/common/src/test/java/io/netty/util/concurrent/GlobalEventExecutorTest.java b/common/src/test/java/io/netty/util/concurrent/GlobalEventExecutorTest.java index 9c9c3898b1..35c2a59cd4 100644 --- a/common/src/test/java/io/netty/util/concurrent/GlobalEventExecutorTest.java +++ b/common/src/test/java/io/netty/util/concurrent/GlobalEventExecutorTest.java @@ -61,7 +61,6 @@ public class GlobalEventExecutorTest { // Ensure the thread stopped itself after running the task. assertThat(thread.isAlive(), is(false)); assertThat(task.ran.get(), is(true)); - assertThat(e.thread, sameInstance(thread)); // Ensure another new thread starts again. task.ran.set(false); @@ -74,7 +73,6 @@ public class GlobalEventExecutorTest { // Ensure the thread stopped itself after running the task. assertThat(thread.isAlive(), is(false)); assertThat(task.ran.get(), is(true)); - assertThat(e.thread, sameInstance(thread)); } @Test @@ -93,7 +91,6 @@ public class GlobalEventExecutorTest { // Now it should be stopped. assertThat(thread.isAlive(), is(false)); - assertThat(e.thread, sameInstance(thread)); } // ensure that when a task submission causes a new thread to be created, the thread inherits the thread group of the