Small fixes and improvements

Motivation:

Fix some typos in Netty.

Modifications:

- Fix potentially dangerous use of non-short-circuit logic in Recycler.transfer(Stack<?>).
- Removed double 'the the' in javadoc of EmbeddedChannel.
- Write to log an exception message if we can not get SOMAXCONN in the NetUtil's static block.
This commit is contained in:
Idel Pivnitskiy 2014-07-20 00:40:45 +04:00 committed by Norman Maurer
parent a7f0fdfa9c
commit 13569481bf
3 changed files with 4 additions and 4 deletions

View File

@ -186,7 +186,7 @@ public final class NetUtil {
somaxconn = Integer.parseInt(in.readLine()); somaxconn = Integer.parseInt(in.readLine());
logger.debug("/proc/sys/net/core/somaxconn: {}", somaxconn); logger.debug("/proc/sys/net/core/somaxconn: {}", somaxconn);
} catch (Exception e) { } catch (Exception e) {
// Failed to get SOMAXCONN logger.debug("Failed to get SOMAXCONN", e);
} finally { } finally {
if (in != null) { if (in != null) {
try { try {

View File

@ -232,7 +232,7 @@ public abstract class Recycler<T> {
} }
to.size = size; to.size = size;
if (end == LINK_CAPACITY & head.next != null) { if (end == LINK_CAPACITY && head.next != null) {
this.head = head.next; this.head = head.next;
} }

View File

@ -156,7 +156,7 @@ public class EmbeddedChannel extends AbstractChannel {
* *
* @param msgs the messages to be written * @param msgs the messages to be written
* *
* @return {@code true} if the write operation did add something to the the inbound buffer * @return {@code true} if the write operation did add something to the inbound buffer
*/ */
public boolean writeInbound(Object... msgs) { public boolean writeInbound(Object... msgs) {
ensureOpen(); ensureOpen();
@ -178,7 +178,7 @@ public class EmbeddedChannel extends AbstractChannel {
* Write messages to the outbound of this {@link Channel}. * Write messages to the outbound of this {@link Channel}.
* *
* @param msgs the messages to be written * @param msgs the messages to be written
* @return bufferReadable returns {@code true} if the write operation did add something to the the outbound buffer * @return bufferReadable returns {@code true} if the write operation did add something to the outbound buffer
*/ */
public boolean writeOutbound(Object... msgs) { public boolean writeOutbound(Object... msgs) {
ensureOpen(); ensureOpen();