diff --git a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java b/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java index c65eabd3d7..ecbf8263c1 100644 --- a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java @@ -98,7 +98,7 @@ public abstract class AbstractSniHandler extends ByteToMessageDecoder impleme // SSLv3 or TLS if (majorVersion == 3) { final int packetLength = in.getUnsignedShort(readerIndex + 3) + - SslUtils.SSL_RECORD_HEADER_LENGTH; + SslUtils.SSL_RECORD_HEADER_LENGTH; if (readableBytes < packetLength) { // client hello incomplete; try again to decode once more data is ready. @@ -185,7 +185,7 @@ public abstract class AbstractSniHandler extends ByteToMessageDecoder impleme } final String hostname = in.toString(offset, serverNameLength, - CharsetUtil.US_ASCII); + CharsetUtil.US_ASCII); try { select(ctx, hostname.toLowerCase(Locale.US)); @@ -208,7 +208,10 @@ public abstract class AbstractSniHandler extends ByteToMessageDecoder impleme break loop; } } - } catch (Throwable e) { + } catch (NotSslRecordException e) { + // Just rethrow as in this case we also closed the channel and this is consistent with SslHandler. + throw e; + } catch (Exception e) { // unexpected encoding, ignore sni and use default if (logger.isDebugEnabled()) { logger.debug("Unexpected client hello packet: " + ByteBufUtil.hexDump(in), e); diff --git a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java index 3ba1c0ca6f..a6dceb364e 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java @@ -140,6 +140,42 @@ public class SniHandlerTest { this.provider = provider; } + @Test + public void testNonSslRecord() throws Exception { + SslContext nettyContext = makeSslContext(provider, false); + try { + final AtomicReference evtRef = + new AtomicReference(); + SniHandler handler = new SniHandler(new DomainNameMappingBuilder(nettyContext).build()); + EmbeddedChannel ch = new EmbeddedChannel(handler, new ChannelInboundHandlerAdapter() { + @Override + public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception { + if (evt instanceof SslHandshakeCompletionEvent) { + assertTrue(evtRef.compareAndSet(null, (SslHandshakeCompletionEvent) evt)); + } + } + }); + + try { + byte[] bytes = new byte[1024]; + bytes[0] = SslUtils.SSL_CONTENT_TYPE_ALERT; + + try { + ch.writeInbound(Unpooled.wrappedBuffer(bytes)); + fail(); + } catch (DecoderException e) { + assertTrue(e.getCause() instanceof NotSslRecordException); + } + assertFalse(ch.finish()); + } finally { + ch.finishAndReleaseAll(); + } + assertTrue(evtRef.get().cause() instanceof NotSslRecordException); + } finally { + releaseAll(nettyContext); + } + } + @Test public void testServerNameParsing() throws Exception { SslContext nettyContext = makeSslContext(provider, false);