andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Http2ConnectionHandler channelInactive sequencing

Browse Source 
Motivation:
ByteToMessageDecoder may call decode after channelInactive is called. This will lead to a NPE.

Modifications:
- Call super.channelInactive() before we process the event in Http2ConnectionHandler

Result:
No more NPE in decode.
This commit is contained in:
Scott Mitchell 2015-08-20 19:23:37 -07:00
parent e280251b15
commit 14dc571956
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
View File

@ -417,11 +417,12 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
@Override @Override
public void channelInactive(ChannelHandlerContext ctx) throws Exception { public void channelInactive(ChannelHandlerContext ctx) throws Exception {
// Call super class first, as this may result in decode being called.
super.channelInactive(ctx);
if (byteDecoder != null) { if (byteDecoder != null) {
encoder.flowController().channelHandlerContext(null); encoder.flowController().channelHandlerContext(null);
decoder.flowController().channelHandlerContext(null); decoder.flowController().channelHandlerContext(null);
byteDecoder.channelInactive(ctx); byteDecoder.channelInactive(ctx);
super.channelInactive(ctx);
byteDecoder = null; byteDecoder = null;
} }
} }