andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* Changed the sort order of LocalAddress.compareTo()

Browse Source 
* Added a FIXME to LocalAddress.compareTo()
* Modified LocalAddress.compareTo() to throw an Error when impacted by the known bug in compareTo() - will fix this bug in the next major feature release since it will break the backward compatibility
This commit is contained in:
Trustin Lee 2010-04-12 10:53:49 +00:00
parent 2fc539a9bc
commit 17a222e397
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/main/java/org/jboss/netty/channel/local/LocalAddress.java
View File

@ -26,7 +26,7 @@ import java.net.SocketAddress;
*
* An ephemeral address is an anonymous address which is assigned temporarily
* and is released as soon as the connection is closed. All ephemeral addresses
* have the same ID, {@code "ephemeral"}, but they are not equals to each other.
* have the same ID, {@code "ephemeral"}, but they are not equal to each other.
*
* @author <a href="http://www.jboss.org/netty/">The Netty Project</a>
* @author Andy Taylor (andy.taylor@jboss.org)
@ -100,9 +100,17 @@ public final class LocalAddress extends SocketAddress implements Comparable<Loca
}
}
// FIXME: This comparison is broken! Assign distinct port numbers for
// ephemeral ports, just like O/S does for port number 0. It will
// break backward compatibility though.
public int compareTo(LocalAddress o) {
if (ephemeral) {
if (o.ephemeral) {
if (this == o){
return 0;
}
int a = System.identityHashCode(this);
int b = System.identityHashCode(this);
if (a < b) {
@ -110,14 +118,16 @@ public final class LocalAddress extends SocketAddress implements Comparable<Loca
} else if (a > b) {
return 1;
} else {
return 0;
throw new Error(
"Two different ephemeral addresses have " +
"same identityHashCode.");
}
} else {
return -1;
return 1;
}
} else {
if (o.ephemeral) {
return 1;
return -1;
} else {
return getId().compareTo(o.getId());
}