andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Stop calling BIO_write once internal buffer is full.

Browse Source 
Motivation:

Previous we called BIO_write until either everything was written into it or it returned an error, which meant that the buffer is full. This then needed a ERR_clear_error() call which is expensive.

Modifications:

Break out of writing loop once we detect that not everything was written and so the buffer is full.

Result:

Less overhead when writing more data then the internal buffer can take.
This commit is contained in:
Norman Maurer 2015-07-03 23:07:41 +02:00
parent a9d2b5cef0
commit 18356911ab
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java
View File

@ -664,6 +664,11 @@ public final class OpenSslEngine extends SSLEngine {
if (written == remaining) { if (written == remaining) {
srcsOffset ++; srcsOffset ++;
} else {
// We were not able to write everything into the BIO so break the write loop as otherwise
// we will produce an error on the next write attempt, which will trigger a SSL.clearError()
// later.
break;
} }
} else { } else {
// BIO_write returned a negative or zero number, this means we could not complete the write // BIO_write returned a negative or zero number, this means we could not complete the write