andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#698] ExceptionEvent could be swallowed if last handler in pipeline is a ChannelDownstreamHandler

Browse Source
This commit is contained in:
Norman Maurer 2012-11-02 20:15:17 +01:00
parent 6cd7a2743e
commit 19104e8774
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/main/java/org/jboss/netty/channel/SimpleChannelUpstreamHandler.java
View File

@ -19,6 +19,8 @@ import org.jboss.netty.buffer.ChannelBuffer;
import org.jboss.netty.logging.InternalLogger; import org.jboss.netty.logging.InternalLogger;
import org.jboss.netty.logging.InternalLoggerFactory; import org.jboss.netty.logging.InternalLoggerFactory;
import java.util.List;
/** /**
* A {@link ChannelUpstreamHandler} which provides an individual handler method * A {@link ChannelUpstreamHandler} which provides an individual handler method
@ -135,7 +137,22 @@ public class SimpleChannelUpstreamHandler implements ChannelUpstreamHandler {
*/ */
public void exceptionCaught( public void exceptionCaught(
ChannelHandlerContext ctx, ExceptionEvent e) throws Exception { ChannelHandlerContext ctx, ExceptionEvent e) throws Exception {
if (this == ctx.getPipeline().getLast()) { ChannelPipeline pipeline = ctx.getPipeline();
ChannelHandler last = pipeline.getLast();
if (!(last instanceof ChannelUpstreamHandler) && ctx instanceof DefaultChannelPipeline) {
// The names comes in the order of which they are insert when using DefaultChannelPipeline
List<String> names = ctx.getPipeline().getNames();
for (int i = names.size() - 1; i >= 0; i--) {
ChannelHandler handler = ctx.getPipeline().get(names.get(i));
if (handler instanceof ChannelUpstreamHandler) {
// find the last handler
last = handler;
break;
}
}
}
if (this == last) {
logger.warn( logger.warn(
"EXCEPTION, please implement " + getClass().getName() + "EXCEPTION, please implement " + getClass().getName() +
".exceptionCaught() for proper handling.", e.getCause()); ".exceptionCaught() for proper handling.", e.getCause());