andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1708] Correctly set the writerIndex in ReadOnlyByteBufferBuf if it is constructed with a buffer which has non zero position

Browse Source
This commit is contained in:
Norman Maurer 2013-08-08 06:54:32 +02:00
parent b934b6009c
commit 194b64cff1
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
buffer/src/main/java/io/netty/buffer/ReadOnlyByteBufferBuf.java
View File

@ -45,7 +45,7 @@ class ReadOnlyByteBufferBuf extends AbstractReferenceCountedByteBuf {
this.allocator = allocator;
this.buffer = buffer.slice().order(ByteOrder.BIG_ENDIAN);
writerIndex(buffer.limit());
writerIndex(this.buffer.limit());
leak = leakDetector.open(this);
}

10
buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java
View File

@ -184,4 +184,14 @@ public class ReadOnlyDirectByteBufferBufTest {
Assert.assertEquals(buf.slice(1, 9), copy);
}
// Test for https://github.com/netty/netty/issues/1708
@Test
public void testWrapBufferWithNonZeroPosition() {
ByteBuf buf = buffer(((ByteBuffer) allocate(16).putLong(1).flip().position(1)).asReadOnlyBuffer());
buffers.add(buf);
ByteBuf slice = buf.slice();
Assert.assertEquals(buf, slice);
}
}