From 198f8fa95e3b8e975e389f1b0c4fea90329b0f85 Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Sun, 23 Nov 2014 20:43:10 -0500 Subject: [PATCH] HTTP/2 throw statement missed Motivation: The DefaultHttp2FrameWriter has an exception generated but is missing the throw keyword. Modifications: Insert the missing throw keyword. Result: Exception thrown when it was intended to be thrown. --- .../io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java index 5a5a371a1f..998bc2816a 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java @@ -86,7 +86,7 @@ public class DefaultHttp2FrameWriter implements Http2FrameWriter, Http2FrameSize @Override public void maxFrameSize(int max) throws Http2Exception { if (!isMaxFrameSizeValid(max)) { - connectionError(FRAME_SIZE_ERROR, "Invalid MAX_FRAME_SIZE specified in sent settings: %d", max); + throw connectionError(FRAME_SIZE_ERROR, "Invalid MAX_FRAME_SIZE specified in sent settings: %d", max); } maxFrameSize = max; }