andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Only set lastReadTime if an read actually happened before in IdleStateHandler.

Browse Source 
Motivation:

IdleStateHandler and ReadTimeoutHandler could mistakely not fire an event even if no channelRead(...) call happened.

Modifications:

Only set lastReadTime if a read happened before.

Result:

More correct IdleStateHandler / ReadTimeoutHandler.
This commit is contained in:
Norman Maurer 2016-09-11 10:33:43 +02:00
parent ad71fd54c9
commit 1a457ec269
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
View File

@ -268,7 +268,7 @@ public class IdleStateHandler extends ChannelDuplexHandler {
@Override @Override
public void channelReadComplete(ChannelHandlerContext ctx) throws Exception { public void channelReadComplete(ChannelHandlerContext ctx) throws Exception {
if (readerIdleTimeNanos > 0 || allIdleTimeNanos > 0) { if ((readerIdleTimeNanos > 0 || allIdleTimeNanos > 0) && reading) {
lastReadTime = System.nanoTime(); lastReadTime = System.nanoTime();
reading = false; reading = false;
} }