andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unnecessary reference to AbstractChannel from AbstractChannelHandlerContext

Browse Source 
Motivation:

We not need to store another reference to AbstractChannel as we can access it through DefaultChannelHandlerContext.

Modifications:

Remove reference.

Result:

Cleaner code.
This commit is contained in:
Norman Maurer 2015-11-16 11:49:45 -08:00
parent ab66b1daba
commit 1ba3a66ff7
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
View File

@ -209,7 +209,6 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
volatile AbstractChannelHandlerContext next;
volatile AbstractChannelHandlerContext prev;
private final AbstractChannel channel;
private final DefaultChannelPipeline pipeline;
private final String name;
private boolean removed;
@ -242,7 +241,6 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
throw new NullPointerException("name");
}
channel = pipeline.channel;
this.pipeline = pipeline;
this.name = name;
this.invoker = invoker;
@ -251,7 +249,7 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
@Override
public final Channel channel() {
return channel;
return pipeline.channel();
}
@Override
@ -301,12 +299,12 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
@Override
public <T> Attribute<T> attr(AttributeKey<T> key) {
return channel.attr(key);
return channel().attr(key);
}
@Override
public <T> boolean hasAttr(AttributeKey<T> key) {
return channel.hasAttr(key);
return channel().hasAttr(key);
}
@Override
@ -528,7 +526,7 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
@Override
public ChannelPromise voidPromise() {
return channel.voidPromise();
return channel().voidPromise();
}
void setRemoved() {
@ -547,7 +545,7 @@ abstract class AbstractChannelHandlerContext implements ChannelHandlerContext, R
@Override
public String toString() {
return StringUtil.simpleClassName(ChannelHandlerContext.class) + '(' + name + ", " + channel + ')';
return StringUtil.simpleClassName(ChannelHandlerContext.class) + '(' + name + ", " + channel() + ')';
}
private final class PausableChannelEventExecutor0 extends PausableChannelEventExecutor {