From 1bcc0709436100c62cfa19ef744f486a5295de4a Mon Sep 17 00:00:00 2001 From: Dmitriy Dumanskiy Date: Tue, 9 Aug 2016 10:44:31 +0300 Subject: [PATCH] cleanup, duplicated static final fields Motivation: There are few duplicated byte[] CRLF fields in code. Modifications: Removed duplicated fields as they could be inherited from parent encoder. Result: Less static fields. --- .../java/io/netty/handler/codec/http/HttpObjectEncoder.java | 2 +- .../java/io/netty/handler/codec/http/HttpRequestEncoder.java | 1 - .../java/io/netty/handler/codec/http/HttpResponseEncoder.java | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java index c3e65dc616..dba6f01de2 100755 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java @@ -47,7 +47,7 @@ import static io.netty.handler.codec.http.HttpConstants.LF; * implement all abstract methods properly. */ public abstract class HttpObjectEncoder extends MessageToMessageEncoder { - private static final byte[] CRLF = { CR, LF }; + static final byte[] CRLF = { CR, LF }; private static final byte[] ZERO_CRLF = { '0', CR, LF }; private static final byte[] ZERO_CRLF_CRLF = { '0', CR, LF, CR, LF }; private static final ByteBuf CRLF_BUF = unreleasableBuffer(directBuffer(CRLF.length).writeBytes(CRLF)); diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java index 1847043686..a40a9fdf17 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java @@ -31,7 +31,6 @@ import static io.netty.handler.codec.http.HttpConstants.SP; public class HttpRequestEncoder extends HttpObjectEncoder { private static final char SLASH = '/'; private static final char QUESTION_MARK = '?'; - private static final byte[] CRLF = { CR, LF }; @Override public boolean acceptOutboundMessage(Object msg) throws Exception { diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java index 5a4c7c5cc3..2e1e51a60d 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java @@ -24,7 +24,6 @@ import static io.netty.handler.codec.http.HttpConstants.*; * a {@link ByteBuf}. */ public class HttpResponseEncoder extends HttpObjectEncoder { - private static final byte[] CRLF = { CR, LF }; @Override public boolean acceptOutboundMessage(Object msg) throws Exception {