diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java index d2998289c9..b1fec81e0d 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java @@ -61,7 +61,7 @@ public class WebSocketServerProtocolHandler extends WebSocketProtocolHandler { } private static final AttributeKey HANDSHAKER_ATTR_KEY = - new AttributeKey(WebSocketServerHandshaker.class.getName()); + AttributeKey.valueOf(WebSocketServerHandshaker.class.getName() + ".HANDSHAKER"); private final String websocketPath; private final String subprotocols; diff --git a/codec/src/main/java/io/netty/handler/codec/DecoderResult.java b/codec/src/main/java/io/netty/handler/codec/DecoderResult.java index 0c122160b1..d9d10295ff 100644 --- a/codec/src/main/java/io/netty/handler/codec/DecoderResult.java +++ b/codec/src/main/java/io/netty/handler/codec/DecoderResult.java @@ -19,8 +19,8 @@ import io.netty.util.Signal; public class DecoderResult { - protected static final Signal SIGNAL_UNFINISHED = new Signal(DecoderResult.class.getName() + ".UNFINISHED"); - protected static final Signal SIGNAL_SUCCESS = new Signal(DecoderResult.class.getName() + ".SUCCESS"); + protected static final Signal SIGNAL_UNFINISHED = Signal.valueOf(DecoderResult.class.getName() + ".UNFINISHED"); + protected static final Signal SIGNAL_SUCCESS = Signal.valueOf(DecoderResult.class.getName() + ".SUCCESS"); public static final DecoderResult UNFINISHED = new DecoderResult(SIGNAL_UNFINISHED); public static final DecoderResult SUCCESS = new DecoderResult(SIGNAL_SUCCESS); diff --git a/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java b/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java index 4f8e90a24c..dc442e01e0 100644 --- a/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec/ReplayingDecoder.java @@ -266,7 +266,7 @@ import java.util.List; */ public abstract class ReplayingDecoder extends ByteToMessageDecoder { - static final Signal REPLAY = new Signal(ReplayingDecoder.class.getName() + ".REPLAY"); + static final Signal REPLAY = Signal.valueOf(ReplayingDecoder.class.getName() + ".REPLAY"); private final ReplayingDecoderBuffer replayable = new ReplayingDecoderBuffer(); private S state; diff --git a/codec/src/main/java/io/netty/handler/codec/marshalling/ContextBoundUnmarshallerProvider.java b/codec/src/main/java/io/netty/handler/codec/marshalling/ContextBoundUnmarshallerProvider.java index 1a74d9731b..333c9bded9 100644 --- a/codec/src/main/java/io/netty/handler/codec/marshalling/ContextBoundUnmarshallerProvider.java +++ b/codec/src/main/java/io/netty/handler/codec/marshalling/ContextBoundUnmarshallerProvider.java @@ -20,7 +20,6 @@ import io.netty.channel.ChannelHandler; import io.netty.channel.ChannelHandlerContext; import io.netty.util.Attribute; import io.netty.util.AttributeKey; - import org.jboss.marshalling.MarshallerFactory; import org.jboss.marshalling.MarshallingConfiguration; import org.jboss.marshalling.Unmarshaller; @@ -35,8 +34,8 @@ import org.jboss.marshalling.Unmarshaller; */ public class ContextBoundUnmarshallerProvider extends DefaultUnmarshallerProvider { - private static final AttributeKey UNMARSHALLER = new AttributeKey( - ContextBoundUnmarshallerProvider.class.getName() + ".unmarshaller"); + private static final AttributeKey UNMARSHALLER = AttributeKey.valueOf( + ContextBoundUnmarshallerProvider.class.getName() + ".UNMARSHALLER"); public ContextBoundUnmarshallerProvider(MarshallerFactory factory, MarshallingConfiguration config) { super(factory, config); diff --git a/codec/src/main/java/io/netty/handler/codec/serialization/CompatibleObjectEncoder.java b/codec/src/main/java/io/netty/handler/codec/serialization/CompatibleObjectEncoder.java index 92a8886460..505f154b92 100644 --- a/codec/src/main/java/io/netty/handler/codec/serialization/CompatibleObjectEncoder.java +++ b/codec/src/main/java/io/netty/handler/codec/serialization/CompatibleObjectEncoder.java @@ -37,7 +37,7 @@ import java.io.Serializable; public class CompatibleObjectEncoder extends MessageToByteEncoder { private static final AttributeKey OOS = - new AttributeKey(CompatibleObjectEncoder.class.getName() + ".oos"); + AttributeKey.valueOf(CompatibleObjectEncoder.class.getName() + ".OOS"); private final int resetInterval; private int writtenObjects; diff --git a/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java b/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java index bc88a6b725..792546a82f 100644 --- a/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java +++ b/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java @@ -39,8 +39,8 @@ public class DefaultPromise extends AbstractFuture implements Promise { return 0; } }; - private static final Signal SUCCESS = new Signal(DefaultPromise.class.getName() + ".SUCCESS"); - private static final Signal UNCANCELLABLE = new Signal(DefaultPromise.class.getName() + ".UNCANCELLABLE"); + private static final Signal SUCCESS = Signal.valueOf(DefaultPromise.class.getName() + ".SUCCESS"); + private static final Signal UNCANCELLABLE = Signal.valueOf(DefaultPromise.class.getName() + ".UNCANCELLABLE"); private final EventExecutor executor; private volatile Object result; diff --git a/common/src/test/java/io/netty/util/DefaultAttributeMapTest.java b/common/src/test/java/io/netty/util/DefaultAttributeMapTest.java index a7c61cc9a4..7fe574ce57 100644 --- a/common/src/test/java/io/netty/util/DefaultAttributeMapTest.java +++ b/common/src/test/java/io/netty/util/DefaultAttributeMapTest.java @@ -15,11 +15,11 @@ */ package io.netty.util; -import static org.junit.Assert.*; - import org.junit.Before; import org.junit.Test; +import static org.junit.Assert.*; + public class DefaultAttributeMapTest { private DefaultAttributeMap map; @@ -36,7 +36,7 @@ public class DefaultAttributeMapTest { @Test public void testGetSetString() { - AttributeKey key = new AttributeKey("Nothing"); + AttributeKey key = AttributeKey.valueOf("Nothing"); Attribute one = map.attr(key); assertSame(one, map.attr(key)); @@ -53,7 +53,7 @@ public class DefaultAttributeMapTest { @Test public void testGetSetInt() { - AttributeKey key = new AttributeKey("Nada"); + AttributeKey key = AttributeKey.valueOf("Nada"); Attribute one = map.attr(key); assertSame(one, map.attr(key)); diff --git a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java index 3a05e40af6..743a51527c 100644 --- a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java +++ b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java @@ -73,8 +73,10 @@ public abstract class AbstractTrafficShapingHandler extends ChannelDuplexHandler */ protected long checkInterval = DEFAULT_CHECK_INTERVAL; // default 1 s - private static final AttributeKey READ_SUSPENDED = new AttributeKey("readSuspended"); - private static final AttributeKey REOPEN_TASK = new AttributeKey("reopenTask"); + private static final AttributeKey READ_SUSPENDED = AttributeKey.valueOf( + AbstractTrafficShapingHandler.class.getName() + ".READ_SUSPENDED"); + private static final AttributeKey REOPEN_TASK = AttributeKey.valueOf( + AbstractTrafficShapingHandler.class.getName() + ".REOPEN_TASK"); /** *