andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use special exception when failing because the SSLEngine was closed (#10783)

Browse Source 
Motivation:

Sometimes it would be helpful to easily detect if an operation failed due the SSLEngine already be closed.

Modifications:

Add special exception that is used when the engine was closed

Result:

Easier to detect a failure caused by a closed exception
This commit is contained in:
Norman Maurer 2020-11-09 15:33:14 +01:00 committed by GitHub
parent b27d837974
commit 1c37c8f072
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
handler/src/main/java/io/netty/handler/ssl/SslClosedEngineException.java Normal file
View File

@ -0,0 +1,31 @@
/*
* Copyright 2020 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.handler.ssl;
import javax.net.ssl.SSLException;
/**
* {@link SSLException} which signals that the exception was caused by an {@link javax.net.ssl.SSLEngine} which was
* closed already.
*/
public final class SslClosedEngineException extends SSLException {
private static final long serialVersionUID = -5204207600474401904L;
public SslClosedEngineException(String reason) {
super(reason);
}
}

2
handler/src/main/java/io/netty/handler/ssl/SslHandler.java
View File

@ -851,7 +851,7 @@ public class SslHandler extends ByteToMessageDecoder implements ChannelOutboundH
if (exception == null) {
exception = sslClosePromise.cause();
if (exception == null) {
exception = new SSLException("SSLEngine closed already");
exception = new SslClosedEngineException("SSLEngine closed already");
}
}
promise.tryFailure(exception);